Skip to content

[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_checkbox_test
Jun 30, 2026
Merged

[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_checkbox_test

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removes the cross-import of widgets/semantics_tester.dart from checkbox_test.dart.
  • Replaces the remaining SemanticsTester usages with SemanticsHandle and direct tester.getSemantics expectations.
  • Removes the @Skip annotation and moves the file to the test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 30, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 30, 2026
@QuncCccccc
QuncCccccc requested review from chunhtai and justinmc June 30, 2026 00:08
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip annotation from checkbox_test.dart and refactors the semantics tests to use tester.ensureSemantics() and matchesSemantics instead of SemanticsTester. The reviewer feedback recommends replacing the fragile find.byType(Focus).last finder with a more robust scoped descendant finder to target the Focus widget associated with CupertinoCheckbox.

Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
@QuncCccccc
QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from f1b7719 to ef99acd Compare June 30, 2026 00:12
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc
QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from ef99acd to d763ace Compare June 30, 2026 00:34
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
chunhtai
chunhtai reviewed Jun 30, 2026
View reviewed changes
Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated

testWidgets('has semantics for tristate', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

@chunhtai chunhtai Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

@QuncCccccc QuncCccccc Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! Thanks!

Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
},
);
final semanticsTester = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

@chunhtai chunhtai Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@QuncCccccc
QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from d763ace to 2103776 Compare June 30, 2026 00:43
justinmc
justinmc approved these changes Jun 30, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus @chunhtai's point about ensureSemantics 👍

@QuncCccccc
QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from 2103776 to d050f49 Compare June 30, 2026 19:14
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc

QuncCccccc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

LGTM minus @chunhtai's point about ensureSemantics 👍

Updated! Thanks!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026
@auto-submit
auto-submit Bot merged commit 563f68f into flutter:main Jun 30, 2026
89 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2026
Merged
pull Bot pushed a commit to safarmer/flutter that referenced this pull request Jul 1, 2026
@engine-flutter-autoroll
Roll Packages from 274ed3e0f9f6 to e74210630ab8 (18 revisions) (flutt…
ca62cc7 
…er#188863)

flutter/packages@274ed3e...e742106

2026-07-01 [email protected] [cupertino_ui] Re-enable
`tab_scaffold_test.dart` (flutter/packages#12064)
2026-07-01 [email protected] [material_ui] Port flutter/flutter
flutter#184808 "Remove semantics_tester import from card_test.dart"
(flutter/packages#11965)
2026-07-01 [email protected] [cupertino_ui] Migrate
`sliding_segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11979)
2026-07-01 [email protected] [cupertino_ui] Migrate
`route_test.dart` to `SemanticsHandle` (flutter/packages#11993)
2026-07-01 [email protected] [cupertino_ui] Migrate
`nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980)
2026-07-01 [email protected] [cupertino_ui] Migrate
`segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11982)
2026-07-01 [email protected] [cupertino_ui] Re-enable
`text_field_test.dart` (flutter/packages#12067)
2026-06-30 [email protected] [camera_android_camerax] Pass
targetVideoEncodingBitRate to Recorder (flutter/packages#11960)
2026-06-30 [email protected]
[camera_android_camerax] Migrate check-readiness skill from bash to Dart
(flutter/packages#11943)
2026-06-30 [email protected] [material_ui]
Enable `time_picker_test` (flutter/packages#12061)
2026-06-30 [email protected] [cupertino_ui]
Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065)
2026-06-30 [email protected] [image_picker]
Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully
(flutter/packages#11825)
2026-06-30 [email protected] [cross_file] Document native
mimeType behavior (flutter/packages#11662)
2026-06-30 [email protected] [material_ui]
Remove `image_data.dart` imports from `circle_avatar_test.dart`,
`color_scheme_test.dart` (flutter/packages#12059)
2026-06-30 [email protected] [cupertino_ui]
Remove `image_data.dart` import from `scaffold_test.dart`
(flutter/packages#12060)
2026-06-30 [email protected] [cupertino_ui]
Remove widgets import from menu_anchor_test.dart
(flutter/packages#12068)
2026-06-30 [email protected] [material_ui]
Enable `checkbox_list_tile_test` (flutter/packages#12007)
2026-06-30 [email protected] [in_app_purchase_storekit] Expose
quantity in Transactions (flutter/packages#11879)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai left review comments
@justinmc justinmc justinmc approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @justinmc @chunhtai