[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart#12002
Merged
auto-submit[bot] merged 1 commit intoJun 26, 2026
Conversation
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotations from dialog_test.dart, dropdown_menu_test.dart, and sliver_app_bar_test.dart to re-enable these test files. It also updates import paths, reorders imports, and wraps several asynchronous dialog-showing functions in unawaited calls in dialog_test.dart. There are no review comments, so I have no feedback to provide.
Contributor
Author
|
Used |
QuncCccccc
force-pushed
the
enable_dialog_sliver_dropdown_menu_tests
branch
from
June 25, 2026 20:24
f4aa3bc to
e70deeb
Compare
QuncCccccc
added
the
autosubmit
Rushikesh1414
pushed a commit
to Rushikesh1414/flutter
that referenced
this pull request
Jun 29, 2026
…er#188728) flutter/packages@c1f7d92...656ccaa 2026-06-26 [email protected] [material_ui] Enable `icon_button_test` (flutter/packages#12015) 2026-06-26 [email protected] [material_ui] Enable `list_tile_test` (flutter/packages#12017) 2026-06-26 [email protected] [material_ui] Enable `calendar_date_picker_test` (flutter/packages#12006) 2026-06-26 [email protected] [material_ui] Enable `filter_chip_test` (flutter/packages#12013) 2026-06-26 [email protected] [material_ui] Enable `ink_well_test` (flutter/packages#12016) 2026-06-26 [email protected] [material_ui] Enable `radio_list_tile_test` (flutter/packages#12019) 2026-06-26 [email protected] [material_ui] Enable `tabs_test` (flutter/packages#12021) 2026-06-26 [email protected] [material_ui] Remove widgets import in `bottom_sheet_test.dart` (flutter/packages#12001) 2026-06-26 [email protected] [material_ui] Remove widgets import in `dialog_test.dart`, `dropdown_menu_test.dart` and `sliver_app_bar_test.dart` (flutter/packages#12002) 2026-06-26 [email protected] [various] Check in auto-upgrade to analysis options (flutter/packages#11969) 2026-06-26 [email protected] [video_player_platform_interface] Add preventsDisplaySleepDuringVideoPlayback option (flutter/packages#11546) 2026-06-26 [email protected] [video_player_avfoundation] Add video track selection support (flutter/packages#11476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart.semantics_tester.darthas existed in material_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).