Skip to content

[in_app_purchase_storekit] Expose quantity in Transactions#11879

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
LouiseHsu:one-shot-sk2-quantity
Jun 30, 2026
Merged

[in_app_purchase_storekit] Expose quantity in Transactions#11879
auto-submit[bot] merged 3 commits into
flutter:mainfrom
LouiseHsu:one-shot-sk2-quantity

Conversation

@LouiseHsu

@LouiseHsu LouiseHsu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#186490

Part of an attempt to one-shot iap issues, inspired by camera work for flutter android

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 9, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label Jun 9, 2026
@LouiseHsu
LouiseHsu marked this pull request as ready for review June 9, 2026 21:43
@LouiseHsu
LouiseHsu requested a review from LongCatIsLooong June 9, 2026 21:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the in_app_purchase_storekit package to expose the actual purchased quantity in SK2Transaction by mapping purchasedQuantity from SK2TransactionMessage. It also updates the fake platform and adds tests to verify this behavior. Review feedback suggests using a null-coalescing operator when assigning purchasedQuantity to prevent null-safety compilation errors, and initializing list variables directly in the fake platform instead of using late to avoid potential LateInitializationErrors.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 10, 2026
@LouiseHsu LouiseHsu added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 25, 2026
@auto-submit
auto-submit Bot merged commit a4ec356 into flutter:main Jun 30, 2026
87 checks passed
pull Bot pushed a commit to ZainCheung/flutter that referenced this pull request Jul 1, 2026
…er#188863)

flutter/packages@274ed3e...e742106

2026-07-01 [email protected] [cupertino_ui] Re-enable
`tab_scaffold_test.dart` (flutter/packages#12064)
2026-07-01 [email protected] [material_ui] Port flutter/flutter
flutter#184808 "Remove semantics_tester import from card_test.dart"
(flutter/packages#11965)
2026-07-01 [email protected] [cupertino_ui] Migrate
`sliding_segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11979)
2026-07-01 [email protected] [cupertino_ui] Migrate
`route_test.dart` to `SemanticsHandle` (flutter/packages#11993)
2026-07-01 [email protected] [cupertino_ui] Migrate
`nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980)
2026-07-01 [email protected] [cupertino_ui] Migrate
`segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11982)
2026-07-01 [email protected] [cupertino_ui] Re-enable
`text_field_test.dart` (flutter/packages#12067)
2026-06-30 [email protected] [camera_android_camerax] Pass
targetVideoEncodingBitRate to Recorder (flutter/packages#11960)
2026-06-30 [email protected]
[camera_android_camerax] Migrate check-readiness skill from bash to Dart
(flutter/packages#11943)
2026-06-30 [email protected] [material_ui]
Enable `time_picker_test` (flutter/packages#12061)
2026-06-30 [email protected] [cupertino_ui]
Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065)
2026-06-30 [email protected] [image_picker]
Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully
(flutter/packages#11825)
2026-06-30 [email protected] [cross_file] Document native
mimeType behavior (flutter/packages#11662)
2026-06-30 [email protected] [material_ui]
Remove `image_data.dart` imports from `circle_avatar_test.dart`,
`color_scheme_test.dart` (flutter/packages#12059)
2026-06-30 [email protected] [cupertino_ui]
Remove `image_data.dart` import from `scaffold_test.dart`
(flutter/packages#12060)
2026-06-30 [email protected] [cupertino_ui]
Remove widgets import from menu_anchor_test.dart
(flutter/packages#12068)
2026-06-30 [email protected] [material_ui]
Enable `checkbox_list_tile_test` (flutter/packages#12007)
2026-06-30 [email protected] [in_app_purchase_storekit] Expose
quantity in Transactions (flutter/packages#11879)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: in_app_purchase platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] SK2Transaction should have real purchased quantity not default value 1

2 participants