[google_maps_flutter] Add Android and iOS attribution ID#11731
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: can't be meaningfully tested; no client-discernable effect |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds internal usage attribution IDs for the Google Maps SDK across Android and various iOS implementations, including standard, SDK 9, and SDK 10 versions. The changes involve calling addInternalUsageAttributionId in the Android plugin and conditionally calling addInternalUsageAttributionID in the iOS plugins. Version numbers and changelogs have been updated accordingly. I have no feedback to provide.
stuartmorgan-g
added
the
autosubmit
…r#187114) flutter/packages@69cf959...fc795e5 2026-05-26 [email protected] Roll Flutter from e03b91f to f3a4b98 (63 revisions) (flutter/packages#11789) 2026-05-26 [email protected] [google_maps_flutter] Add Android and iOS attribution ID (flutter/packages#11731) 2026-05-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20251224 to 20260522 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#11776) 2026-05-26 [email protected] [google_maps_flutter] Add a pinned-SDK web example app (flutter/packages#11761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Adds an attribution ID to allow association of Google Maps usage to this plugin in backend metrics. Known caveats:
This can't be meaningfully tested because they are setters on static SDK objects that aren't inspectable. In theory we could make wrappers and then inject replacement global objects but the untestable parts of that setup would be more complex than the code in question so there's no value in doing that. Instead this will be verified on the backend. This call has no user-facing effect, so regression risk is also extremely low.
Part of flutter/flutter#168529
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2