[google_maps_flutter] Use super parameters in more places in examples#11517
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates numerous example files across the Google Maps Flutter packages to utilize the super.key constructor parameter shorthand. A review comment suggests moving the super.key parameter to the beginning of the parameter list in advanced_marker_icons.dart to maintain consistency with Flutter conventions and other constructors in the repository.
|
@stuartmorgan-g would this change require a bump? It only affects example code, and is a runtime no-op. |
|
The tool is correctly identifying that it doesn't require a version bump (since it doesn't change example/lib/main.dart), it's just flagging it to evaluate whether it warrants a CHANGELOG entry. This doesn't, since it's not showing anything relevant to package clients—the tool errs on the side of false positives, since some unpublished example changes are still relevant (e.g., if a new version of Android requires a plugin to put an new permission in it manifest, we would mention that in the CHANGELOG). |
stuartmorgan-g
added
the
override: no changelog needed
stuartmorgan-g
added
autosubmit
…er#185287) flutter/packages@c2e3d1f...01c505f 2026-04-20 [email protected] Roll Flutter from 8e8a194 to 2844af6 (13 revisions) (flutter/packages#11531) 2026-04-17 [email protected] [google_maps_fluter] Switch to Kotlin Pigeon (flutter/packages#11522) 2026-04-17 [email protected] Roll Flutter (stable) from db50e20 to cc0734a (8 revisions) (flutter/packages#11525) 2026-04-17 [email protected] Roll Flutter from 31f1802 to 8e8a194 (22 revisions) (flutter/packages#11523) 2026-04-17 [email protected] [google_maps_flutter] Fix various Java warnings (flutter/packages#11516) 2026-04-16 [email protected] [google_maps_flutter] Use super parameters in more places in examples (flutter/packages#11517) 2026-04-16 [email protected] Roll Flutter from c1b14e9 to 31f1802 (46 revisions) (flutter/packages#11518) 2026-04-15 [email protected] [tool] Update java formatter (flutter/packages#11508) 2026-04-15 [email protected] [quick_actions] Remove manual thread hop in Android response (flutter/packages#11445) 2026-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.6.0 to 1.7.0 in the all-github-actions group (flutter/packages#11510) 2026-04-14 [email protected] Skip dependabot updates for minor versions of gradle and kotlin (flutter/packages#11509) 2026-04-14 [email protected] [go_router] Fix pop() restoring stale configuration when route has onExit (flutter/packages#11241) 2026-04-14 [email protected] [url_launcher] Switch to Kotlin Pigeon (flutter/packages#11473) 2026-04-14 [email protected] [pr-fix] Run all flutter/packages macOS tests using Xcode 26 and iOS 26 simulator (flutter/packages#10635) 2026-04-14 [email protected] [camera_platform_interface] Add setJpegImageQuality method (flutter/packages#11454) 2026-04-14 [email protected] Roll Flutter from 2fa45e0 to c1b14e9 (19 revisions) (flutter/packages#11506) 2026-04-14 [email protected] [local_auth] Switch to Kotlin Pigeon (flutter/packages#11482) 2026-04-13 [email protected] Sync release-go_router to main (flutter/packages#11499) 2026-04-13 [email protected] [mustache_template] Fix auto-generated specification tests, run with `dart test` (flutter/packages#11056) 2026-04-13 [email protected] Roll Flutter from bf18e39 to 2fa45e0 (19 revisions) (flutter/packages#11497) 2026-04-10 [email protected] Roll Flutter from 81c87ea to bf18e39 (18 revisions) (flutter/packages#11488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…flutter#11517) Changes to the Dart analyzer will catch more situations where super-parameters should be used, for the `use_super_parameters` lint rule. We need to clean up this example code before it can land. Work towards dart-lang/sdk#58729 ## Pre-Review Checklist
…flutter#11517) Changes to the Dart analyzer will catch more situations where super-parameters should be used, for the `use_super_parameters` lint rule. We need to clean up this example code before it can land. Work towards dart-lang/sdk#58729 ## Pre-Review Checklist
2 participants
Changes to the Dart analyzer will catch more situations where super-parameters should be used, for the
use_super_parameterslint rule. We need to clean up this example code before it can land.Work towards dart-lang/sdk#58729
Pre-Review Checklist
[shared_preferences]///).