Skip to content

[camera] Remove unused test file#10966

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:camera-dead-test-file
Feb 5, 2026
Merged

[camera] Remove unused test file#10966
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:camera-dead-test-file

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

This test file doesn't appear to ever have been part of a project, so was never run, and was testing a utility method that no longer exists.

This test file doesn't appear to ever have been part of a project, so
was never run, and was testing a utility method that no longer exists.
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

Found by accident only because it imports OCMock... which it doesn't use 🙃

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraUtilTests.m file. The file contained Objective-C tests for a utility method that is no longer present in the codebase.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2026
@auto-submit auto-submit Bot merged commit 7bd2fd1 into flutter:main Feb 5, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2026
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Feb 6, 2026
flutter/packages@c197455...7805d3e

2026-02-06 [email protected] [flutter_svg] Convert example app to
Swift (flutter/packages#10968)
2026-02-05 [email protected] [camera] Remove unused test file
(flutter/packages#10966)
2026-02-05 [email protected] [camera_avfoundation] Handle
startWriting errors (flutter/packages#10921)
2026-02-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia
from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android
(flutter/packages#10950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
…r#182016)

flutter/packages@c197455...7805d3e

2026-02-06 [email protected] [flutter_svg] Convert example app to
Swift (flutter/packages#10968)
2026-02-05 [email protected] [camera] Remove unused test file
(flutter/packages#10966)
2026-02-05 [email protected] [camera_avfoundation] Handle
startWriting errors (flutter/packages#10921)
2026-02-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia
from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android
(flutter/packages#10950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
…r#182016)

flutter/packages@c197455...7805d3e

2026-02-06 [email protected] [flutter_svg] Convert example app to
Swift (flutter/packages#10968)
2026-02-05 [email protected] [camera] Remove unused test file
(flutter/packages#10966)
2026-02-05 [email protected] [camera_avfoundation] Handle
startWriting errors (flutter/packages#10921)
2026-02-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia
from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android
(flutter/packages#10950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
…r#182016)

flutter/packages@c197455...7805d3e

2026-02-06 [email protected] [flutter_svg] Convert example app to
Swift (flutter/packages#10968)
2026-02-05 [email protected] [camera] Remove unused test file
(flutter/packages#10966)
2026-02-05 [email protected] [camera_avfoundation] Handle
startWriting errors (flutter/packages#10921)
2026-02-05 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia
from 3.38.0 to 3.39.0 in /packages/interactive_media_ads/android
(flutter/packages#10950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants