-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings #10649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses three analyzer warnings from Xcode 26.2 by updating a preprocessor macro, removing an unused variable, and changing a mutable variable to a constant. The CHANGELOG.md has also been updated. One minor style issue regarding indentation has been pointed out for improvement.
...rchase/in_app_purchase_storekit/example/shared/RunnerTests/FIAPPaymentQueueDeleteTests.swift
Outdated
Show resolved
Hide resolved
| plugin.purchase(id: "consumable", options: nil) { result in | ||
| switch result { | ||
| case .success(let purchase): | ||
| case .success(_): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are failing - Im guessing you might need to keep the "let purchase" because of IAP sandbox shennanigans. I think if you dont handle the VerificationResult it freaks out. Maybe we can do this instead
case .success(let purchase):
_ = purchase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, this test passes on Xcode 26.2 locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also passed on 16.4 locally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thats scary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it passed in CI when run a second time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh the tests are flaky :( thats not good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c8f9c1b to
150a2aa
Compare
Seen in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8695102947197916049/+/u/Run_package_tests/native_test/stdout
I opened in Xcode 26.2 and let it "Fix".
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3