Skip to content

Fix html in webview_flutter doc comment#10634

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
athomas:html-in-doc
Jan 7, 2026
Merged

Fix html in webview_flutter doc comment#10634
auto-submit[bot] merged 5 commits into
flutter:mainfrom
athomas:html-in-doc

Conversation

@athomas

@athomas athomas commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

This adds 10 points to the score on pub.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses a documentation formatting issue in the webview_flutter package. Specifically, it escapes angle brackets in a doc comment to ensure correct rendering, which contributes to an improved score on pub.dev.

@bparrishMines bparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026
@auto-submit

auto-submit Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/10634, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026
@bparrishMines

Copy link
Copy Markdown
Contributor

@stuartmorgan-g or @tarrinneal for secondary review

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026
@auto-submit
auto-submit Bot merged commit 39d8eee into flutter:main Jan 7, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2026
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Jan 8, 2026
flutter/packages@9705815...039a026

2026-01-07 [email protected] Manual roll Flutter (stable)
from 66dd93f to f6ff152 (2 revisions) (flutter/packages#10746)
2026-01-07 [email protected] [ci] release
action uses sub action for installing flutter (flutter/packages#10747)
2026-01-07 [email protected] Fix html in webview_flutter doc comment
(flutter/packages#10634)
2026-01-07 [email protected]
[camera_web] Fixed crashing bug on camera_web 0.3.5 for Safari
(flutter/packages#10595)
2026-01-07 [email protected] Roll Flutter from
13b2b91 to 01d37bc (74 revisions) (flutter/packages#10745)
2026-01-07 [email protected] [ci] adjust github
action, need to checkout repo before using local action
(flutter/packages#10744)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants