-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Redistribute package ownership among Android team #10569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CODEOWNERS file to redistribute ownership of the quick_actions_android and video_player_android packages. The change itself is straightforward. I've provided one comment to improve the formatting and alignment within the CODEOWNERS file for better readability and maintainability. Additionally, I noticed the PR title doesn't follow the repository's convention of starting with a package name, as indicated in the pre-review checklist.
| packages/in_app_purchase/in_app_purchase_android/** @gmackall | ||
| packages/local_auth/local_auth_android/** @mboetger | ||
| packages/path_provider/path_provider_android/** @camsim99 | ||
| packages/quick_actions/quick_actions_android/** @reidbaker | ||
| packages/quick_actions/quick_actions_android/** @jesswrd | ||
| packages/shared_preferences/shared_preferences_android/** @jesswrd | ||
| packages/url_launcher/url_launcher_android/** @gmackall | ||
| packages/video_player/video_player_android/** @reidbaker | ||
| packages/video_player/video_player_android/** @mboetger | ||
| # Owned by ecosystem team for now during the wrapper evaluation. | ||
| packages/webview_flutter/webview_flutter_android/** @bparrishMines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and consistency with other entries in this file, could you please align the owner names in this block? This improves the overall maintainability of the file.
packages/in_app_purchase/in_app_purchase_android/** @gmackall
packages/local_auth/local_auth_android/** @mboetger
packages/path_provider/path_provider_android/** @camsim99
packages/quick_actions/quick_actions_android/** @jesswrd
packages/shared_preferences/shared_preferences_android/** @jesswrd
packages/url_launcher/url_launcher_android/** @gmackall
packages/video_player/video_player_android/** @mboetger
# Owned by ecosystem team for now during the wrapper evaluation.
packages/webview_flutter/webview_flutter_android/** @bparrishMines
flutter/packages@338ecd3...74a5a53 2025-12-10 [email protected] [ci] Rewrites branch exists without external dependencies (flutter/packages#10594) 2025-12-10 [email protected] [rfw] Add Flexible widget support to core widgets (flutter/packages#9750) 2025-12-09 [email protected] Redistribute package ownership among Android team (flutter/packages#10569) 2025-12-09 [email protected] [camera_android_camerax] Updates pigeon generation to prevent crash when objects call to Dart after a hot restart (flutter/packages#10571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Redistribute package ownership among Android team.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).