Skip to content

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Dec 4, 2025

Redistribute package ownership among Android team.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to redistribute ownership of the quick_actions_android and video_player_android packages. The change itself is straightforward. I've provided one comment to improve the formatting and alignment within the CODEOWNERS file for better readability and maintainability. Additionally, I noticed the PR title doesn't follow the repository's convention of starting with a package name, as indicated in the pre-review checklist.

Comment on lines 76 to 84
packages/in_app_purchase/in_app_purchase_android/** @gmackall
packages/local_auth/local_auth_android/** @mboetger
packages/path_provider/path_provider_android/** @camsim99
packages/quick_actions/quick_actions_android/** @reidbaker
packages/quick_actions/quick_actions_android/** @jesswrd
packages/shared_preferences/shared_preferences_android/** @jesswrd
packages/url_launcher/url_launcher_android/** @gmackall
packages/video_player/video_player_android/** @reidbaker
packages/video_player/video_player_android/** @mboetger
# Owned by ecosystem team for now during the wrapper evaluation.
packages/webview_flutter/webview_flutter_android/** @bparrishMines

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency with other entries in this file, could you please align the owner names in this block? This improves the overall maintainability of the file.

packages/in_app_purchase/in_app_purchase_android/**          @gmackall
packages/local_auth/local_auth_android/**                    @mboetger
packages/path_provider/path_provider_android/**              @camsim99
packages/quick_actions/quick_actions_android/**              @jesswrd
packages/shared_preferences/shared_preferences_android/**    @jesswrd
packages/url_launcher/url_launcher_android/**                @gmackall
packages/video_player/video_player_android/**                @mboetger
# Owned by ecosystem team for now during the wrapper evaluation.
packages/webview_flutter/webview_flutter_android/**          @bparrishMines

@mboetger mboetger marked this pull request as ready for review December 8, 2025 18:46
@mboetger mboetger requested a review from jmagman December 8, 2025 18:50
@mboetger mboetger requested a review from jesswrd December 8, 2025 19:49
@mboetger mboetger requested a review from a team December 9, 2025 23:32
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2025
@auto-submit auto-submit bot merged commit cfe2fe2 into flutter:main Dec 9, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 10, 2025
flutter/packages@338ecd3...74a5a53

2025-12-10 [email protected] [ci] Rewrites
branch exists without external dependencies (flutter/packages#10594)
2025-12-10 [email protected] [rfw] Add
Flexible widget support to core widgets (flutter/packages#9750)
2025-12-09 [email protected] Redistribute package ownership among
Android team (flutter/packages#10569)
2025-12-09 [email protected]
[camera_android_camerax] Updates pigeon generation to prevent crash when
objects call to Dart after a hot restart (flutter/packages#10571)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants