[two_dimensional_scrollables] Update test for deprecation #10525
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tests that use the deprecated `Color.withOpacity` to use `Color.withValues(alpha:)` instead. Fixes flutter/flutter#159733
github-actions
bot
added
p: two_dimensional_scrollables
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the test files to replace the deprecated Color.withOpacity with the recommended Color.withValues(alpha:). The changes are straightforward and address the deprecation as intended. I have added one comment regarding code duplication, suggesting the extraction of a repeated color value into a variable to improve maintainability.
| height: 200, | ||
| width: 200, | ||
| color: Colors.grey.withOpacity(0.5), | ||
| color: Colors.grey.withValues(alpha: 0.5), |
There was a problem hiding this comment.
This color Colors.grey.withValues(alpha: 0.5) is used four times across two tests in this file. To improve maintainability and reduce duplication, consider extracting it into a final variable at the group level and reusing it.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 3, 2025
flutter/packages@148dcd2...8cb4903 2025-12-02 [email protected] Remove `no_adjacent_strings_in_list` from enabled lint rules. (flutter/packages#7878) 2025-12-02 [email protected] Roll Flutter from 05d6005 to 5545bb3 (28 revisions) (flutter/packages#10551) 2025-12-02 [email protected] [two_dimensional_scrollables] Update test for deprecation (flutter/packages#10525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…r#179407) flutter/packages@148dcd2...8cb4903 2025-12-02 [email protected] Remove `no_adjacent_strings_in_list` from enabled lint rules. (flutter/packages#7878) 2025-12-02 [email protected] Roll Flutter from 05d6005 to 5545bb3 (28 revisions) (flutter/packages#10551) 2025-12-02 [email protected] [two_dimensional_scrollables] Update test for deprecation (flutter/packages#10525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests that use the deprecated
Color.withOpacityto useColor.withValues(alpha:)instead.Fixes flutter/flutter#159733
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3