Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Rolls Pigeon to 26.1.2 in webview_flutter_android to pick up a fix for a Kotlin 1.8 compatibility issue.

Fixes flutter/flutter#178756

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Rolls Pigeon to 26.1.2 in `webview_flutter_android` to pick up a fix for
a Kotlin 1.8 compatibility issue.

Fixes flutter/flutter#178756
@stuartmorgan-g
Copy link
Collaborator Author

test-exempt: rolling dependencies

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a Kotlin 1.8 compatibility issue by updating the Pigeon dependency to version 26.1.2 in the webview_flutter_android package. The changes are well-executed, including the necessary updates to pubspec.yaml, CHANGELOG.md, and the regenerated Pigeon files. The code is clean and the changes are consistent with the PR's objective. I have no further comments; the PR is ready for merging.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 21, 2025
@auto-submit auto-submit bot merged commit 6f2dd54 into flutter:main Nov 21, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 24, 2025
flutter/packages@e67b6be...e019cf9

2025-11-24 [email protected] [Android 16] Bump Packages to
Robolectric 4.16 (flutter/packages#10492)
2025-11-24 [email protected] Roll Flutter from
c8cfb2b to 3f553f6 (11 revisions) (flutter/packages#10510)
2025-11-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 6 directories with
2 updates (flutter/packages#10500)
2025-11-22 [email protected] Roll Flutter from
d438df3 to c8cfb2b (21 revisions) (flutter/packages#10494)
2025-11-21 [email protected] [webview_flutter] Update Pigeon for
Kotlin 1.8 compat (flutter/packages#10486)
2025-11-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 19 directories with 1
update (flutter/packages#10456)
2025-11-21 [email protected] [file_selector] Add parameter to
control whether the new folders button is visible in the file dialog
(flutter/packages#9965)
2025-11-21 [email protected] Roll Flutter from
9f383e0 to d438df3 (18 revisions) (flutter/packages#10491)
2025-11-21 [email protected] Roll Flutter (stable) from
f5a8537 to 19074d1 (2 revisions) (flutter/packages#10489)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
flutter/packages@e67b6be...e019cf9

2025-11-24 [email protected] [Android 16] Bump Packages to
Robolectric 4.16 (flutter/packages#10492)
2025-11-24 [email protected] Roll Flutter from
c8cfb2b to 3f553f6 (11 revisions) (flutter/packages#10510)
2025-11-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 6 directories with
2 updates (flutter/packages#10500)
2025-11-22 [email protected] Roll Flutter from
d438df3 to c8cfb2b (21 revisions) (flutter/packages#10494)
2025-11-21 [email protected] [webview_flutter] Update Pigeon for
Kotlin 1.8 compat (flutter/packages#10486)
2025-11-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 19 directories with 1
update (flutter/packages#10456)
2025-11-21 [email protected] [file_selector] Add parameter to
control whether the new folders button is visible in the file dialog
(flutter/packages#9965)
2025-11-21 [email protected] Roll Flutter from
9f383e0 to d438df3 (18 revisions) (flutter/packages#10491)
2025-11-21 [email protected] Roll Flutter (stable) from
f5a8537 to 19074d1 (2 revisions) (flutter/packages#10489)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
flutter/packages@e67b6be...e019cf9

2025-11-24 [email protected] [Android 16] Bump Packages to
Robolectric 4.16 (flutter/packages#10492)
2025-11-24 [email protected] Roll Flutter from
c8cfb2b to 3f553f6 (11 revisions) (flutter/packages#10510)
2025-11-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 6 directories with
2 updates (flutter/packages#10500)
2025-11-22 [email protected] Roll Flutter from
d438df3 to c8cfb2b (21 revisions) (flutter/packages#10494)
2025-11-21 [email protected] [webview_flutter] Update Pigeon for
Kotlin 1.8 compat (flutter/packages#10486)
2025-11-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 19 directories with 1
update (flutter/packages#10456)
2025-11-21 [email protected] [file_selector] Add parameter to
control whether the new folders button is visible in the file dialog
(flutter/packages#9965)
2025-11-21 [email protected] Roll Flutter from
9f383e0 to d438df3 (18 revisions) (flutter/packages#10491)
2025-11-21 [email protected] Roll Flutter (stable) from
f5a8537 to 19074d1 (2 revisions) (flutter/packages#10489)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webview_flutter_android fails compilation on Kotlin 1.8

2 participants