[tool] Remove code analysis from podspec-check #10484
Merged
+11
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the full build-and-analyze version of `pod lib lint` with the `--quick` version. This means that this step no longer does native code analysis (which `analyze` covers), so it no longer needs an exclusion list for packages with warnings. As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing. Fixes flutter/flutter#178806
stuartmorgan-g
commented
Nov 20, 2025
| print(frameworkResult.stdout); | ||
| print(frameworkResult.stderr); | ||
|
|
||
| // Lint plugin as library. |
Collaborator
Author
There was a problem hiding this comment.
The difference only matters when building, so we don't need to run both modes.
| 'lint', | ||
| podspecPath, | ||
| '--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices. | ||
| '--skip-tests', |
Collaborator
Author
There was a problem hiding this comment.
These flags aren't used in --quick mode.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the podspec-check command to use pod lib lint --quick instead of a full pod lib lint. This removes the dual-pass linting for library and framework styles and removes the --exclude flag from the CI configuration. The corresponding tests are updated to reflect the new single-pass linting process. My review includes a suggestion to remove a comment that has become obsolete due to these changes.
vashworth
approved these changes
Nov 25, 2025
Contributor
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
Thanks for doing this!
stuartmorgan-g
added
the
autosubmit
agrapine
pushed a commit
to swipelab/flutter_packages
that referenced
this pull request
Nov 26, 2025
Replaces the full build-and-analyze version of `pod lib lint` with the `--quick` version. This means that this step no longer does native code analysis (which `analyze` covers), so it no longer needs an exclusion list for packages with warnings. As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing. Fixes flutter/flutter#178806
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2025
flutter/packages@cc3dca6...5d8d954 2025-11-26 [email protected] [video_player_avfoundation] Create a Dart player instance (flutter/packages#10490) 2025-11-25 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 3.6.0 to 3.19.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#10390) 2025-11-25 [email protected] [path_provider] Revert iOS/macOS to plugin-based implementation (flutter/packages#10517) 2025-11-25 [email protected] [google_maps_flutter] Replace deprecated APIs (flutter/packages#10474) 2025-11-25 [email protected] [tool] Remove code analysis from podspec-check (flutter/packages#10484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
) flutter/packages@cc3dca6...5d8d954 2025-11-26 [email protected] [video_player_avfoundation] Create a Dart player instance (flutter/packages#10490) 2025-11-25 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 3.6.0 to 3.19.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#10390) 2025-11-25 [email protected] [path_provider] Revert iOS/macOS to plugin-based implementation (flutter/packages#10517) 2025-11-25 [email protected] [google_maps_flutter] Replace deprecated APIs (flutter/packages#10474) 2025-11-25 [email protected] [tool] Remove code analysis from podspec-check (flutter/packages#10484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
) flutter/packages@cc3dca6...5d8d954 2025-11-26 [email protected] [video_player_avfoundation] Create a Dart player instance (flutter/packages#10490) 2025-11-25 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 3.6.0 to 3.19.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#10390) 2025-11-25 [email protected] [path_provider] Revert iOS/macOS to plugin-based implementation (flutter/packages#10517) 2025-11-25 [email protected] [google_maps_flutter] Replace deprecated APIs (flutter/packages#10474) 2025-11-25 [email protected] [tool] Remove code analysis from podspec-check (flutter/packages#10484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the full build-and-analyze version of
pod lib lintwith the--quickversion. This means that this step no longer does native code analysis (whichanalyzecovers), so it no longer needs an exclusion list for packages with warnings.As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing.
Fixes flutter/flutter#178806