[ci] Add missing deps #10366
Merged
[ci] Add missing deps #10366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dependencies to Android CI configs to attempt to fix OOB build failures caused by Ubuntu bot downgrades. See flutter/flutter#178060
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds ninja as a dependency to the linux_android and linux_android_legacy CI configurations. This change is a direct response to build failures caused by recent Ubuntu bot downgrades, as detailed in the associated issue. The addition of this build tool is a logical fix for the described problem. The changes are correct and address the issue. I've added a couple of suggestions to sort the dependency lists alphabetically for better long-term maintainability.
Collaborator
Author
|
Still waiting for some tests to come back, but it looks like this may be enough to fix the OOB regression; requesting review optimistically. |
stuartmorgan-g
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
1 similar comment
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2025
flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dependencies to Android CI configs to attempt to fix OOB build failures caused by Ubuntu bot downgrades.
See flutter/flutter#178060