[file_selector] Remove use of Pigeon's Dart test generator #10315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
added
override: no versioning needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the tests for file_selector_ios, file_selector_macos, and file_selector_windows to remove the dependency on Pigeon's Dart test generator and the mockito package. This is achieved by introducing dependency injection for the platform-specific FileSelectorApi and using a simple fake implementation in tests. This change simplifies the test setup, reduces dependencies, and removes generated test files, improving the overall maintainability of the codebase. The changes are consistent across all affected packages and I've noted one opportunity for improvement.
Collaborator
Author
|
CHANGELOG/version overrides: While technically there is production code change here, it's just adding an optional, visibible-only-for-tests parameter, and moving one ivar initialization from the declaration to the constructor, so it's pretty clearly a no-op. |
stuartmorgan-g
commented
Oct 28, 2025
| final bool? selectMultiple; | ||
| } | ||
|
|
||
| @HostApi(dartHostTestHandler: 'TestFileSelectorApi') |
Collaborator
Author
There was a problem hiding this comment.
This wasn't being used, it was just copypasta from some other platform, which is why there are no other changes to file_selector_linux.
16 tasks
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2025
flutter/packages@3caa48b...4cec230 2025-11-08 [email protected] [google_maps_flutter] Replace deprecated methods (flutter/packages#10377) 2025-11-08 [email protected] [file_selector] Remove use of Pigeon's Dart test generator (flutter/packages#10315) 2025-11-07 [email protected] Update Gradle Version Formatting Validation (flutter/packages#10326) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@3caa48b...4cec230 2025-11-08 [email protected] [google_maps_flutter] Replace deprecated methods (flutter/packages#10377) 2025-11-08 [email protected] [file_selector] Remove use of Pigeon's Dart test generator (flutter/packages#10315) 2025-11-07 [email protected] Update Gradle Version Formatting Validation (flutter/packages#10326) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
flutter/packages@3caa48b...4cec230 2025-11-08 [email protected] [google_maps_flutter] Replace deprecated methods (flutter/packages#10377) 2025-11-08 [email protected] [file_selector] Remove use of Pigeon's Dart test generator (flutter/packages#10315) 2025-11-07 [email protected] Update Gradle Version Formatting Validation (flutter/packages#10326) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@3caa48b...4cec230 2025-11-08 [email protected] [google_maps_flutter] Replace deprecated methods (flutter/packages#10377) 2025-11-08 [email protected] [file_selector] Remove use of Pigeon's Dart test generator (flutter/packages#10315) 2025-11-07 [email protected] Update Gradle Version Formatting Validation (flutter/packages#10326) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
file_selector_ios,_macos, and_windowstests to use the same structure asfile_selector_linuxalready uses:mockitoin favor of a fake, since the fake is extremely simple to maintain and it makes the tests simpler.Part of flutter/flutter#159886
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3