feat(ios): add audio track selection support for AVFoundation #10313

nateshmbhat · 2025-10-28T15:06:34Z

Implemented getAudioTracks() method to retrieve available audio tracks from both HLS streams and regular video files

AVFoundation Platform PR for : #9925

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces audio track selection support for AVFoundation, enabling users to retrieve and select audio tracks from both HLS streams and regular video files. The changes include modifications to the CHANGELOG, platform-specific code (ObjC, Swift), example app, and test files. The minimum supported SDK versions have been updated, and new methods (getAudioTracks(), selectAudioTrack()) have been implemented. The code adheres to the repository's style guide, focusing on objective summaries and using code as the source of truth.

packages/video_player/video_player_avfoundation/CHANGELOG.md

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation.podspec

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Package.swift

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


Consider adding a comment explaining why nil options are skipped. This will help future developers understand the logic behind this check.

+1, why are we checking against NSNull or checking if the option is nil?

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+  }
+  // For asset tracks, we don't have a direct way to select them in AVFoundation
+  // This would require more complex track selection logic that's not commonly used


Add a comment explaining why direct selection isn't possible and what the limitations are. This will help future developers understand the current implementation and potential areas for improvement.

packages/video_player/video_player_avfoundation/example/ios/Flutter/AppFrameworkInfo.plist

packages/video_player/video_player_avfoundation/example/ios/Runner.xcodeproj/project.pbxproj

packages/video_player/video_player_avfoundation/example/macos/Podfile

packages/video_player/video_player_avfoundation/example/macos/Runner.xcodeproj/project.pbxproj

gemini-code-assist · 2025-10-28T15:12:31Z

packages/video_player/video_player_avfoundation/example/pubspec.yaml

  assets:
    - assets/flutter-mark-square-64.png
    - assets/Butterfly-209.mp4
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.


Per the repository style guide, the review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." ¹

Style Guide References

Footnotes

The review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." (link) ↩

- Added getAudioTracks() method supporting both HLS media selection and regular asset tracks - Added selectAudioTrack() method with support for both track selection mechanisms - Included comprehensive test coverage for audio track functionality with edge cases

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat · 2025-11-07T17:18:01Z

@LongCatIsLooong @tarrinneal could you please review this PR

tarrinneal · 2025-11-24T19:29:11Z

🥲

Sorry, I've been out as my wife is recovering from surgery. I'll try to get to this in the next couple days.

LongCatIsLooong · 2025-11-25T00:23:10Z

(just started reviewing this, I'll finish doing the review tomorrow, sorry for the delay I was working on a bugfix).

LongCatIsLooong

So far I've only looked at the objective-c implementation.
My biggest question: why is it required to drop down to lower-level AVAssetTrack stuff? I went to read a little about media selection group and my understanding is that it should be sufficient for most user-facing use cases. What are the use cases for the tracks information?

Additionally, track loading is lazy and asynchronous according to the documentation. I don't see logic that handles the asynchronism.

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

LongCatIsLooong · 2025-11-25T19:13:16Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+    NSMutableArray<FVPMediaSelectionAudioTrackData *> *mediaSelectionTracks =
+        [[NSMutableArray alloc] init];
+    AVMediaSelectionOption *currentSelection = nil;
+    if (@available(iOS 11.0, macOS 10.13, *)) {


I thought the plugin's lowest supported iOS version is 13.0 so we don't have to resort to the deprecated API?

yaa but The @available(iOS 11.0, macOS 10.13, *) syntax is already being used consistently in the codebase , lemme know if you want me to remove it.

The @available(iOS 11.0, macOS 10.13, *) syntax is already being used consistently in the codebase

There are zero instances in this repository where we check for a min OS version less than the minimum supported OS version.

If you mean that @available in general is used in the codebase, we consistently use it when we need different codepaths for different supported OS versions.

LongCatIsLooong · 2025-11-25T19:18:44Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


+1, why are we checking against NSNull or checking if the option is nil?

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

…layer_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m Co-authored-by: LongCatIsLooong <[email protected]>

- Remove _cachedAudioSelectionOptions instance variable - Fetch options from media selection group each time in selectAudioTrack - Address PR review feedback from LongCatIsLooong

- Remove unnecessary nil checks for AVMediaSelectionOption - Remove redundant equality check in isSelected comparison - Simplify commonMetadataTitle extraction - Remove try-catch block and type validation for format description parsing - Remove defensive checks for Core Media format descriptions - Streamline audio format description extraction logic

…ayer - Return FlutterError instead of empty data when video not loaded in getAudioTracks - Return FlutterError instead of silently failing in selectAudioTrack when no video loaded - Remove test for nil media selection option handling (no longer needed) - Add getAudioTracks and selectAudioTrack helper methods to _PlayerInstance - Apply dart format to fix code style inconsistencies

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat · 2025-11-27T08:19:26Z

@LongCatIsLooong thanks for the detailed review. Have addressed all the comments, can you please check ?

LongCatIsLooong · 2025-12-01T20:50:28Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m


+- (nullable FVPNativeAudioTrackData *)getAudioTracks:(FlutterError *_Nullable *_Nonnull)error {
+  AVPlayerItem *currentItem = _player.currentItem;
+  if (!currentItem) {


I don't think the code here is reachable. currentItem is set in init so you can assume it's not nil (so this should probably be removed, or use a NSAssert instead)

Same goes for the currentItem check in selectAudioTrackWithType

…methods - Replace FlutterError returns with NSAssert for nil currentItem checks in getAudioTracks and selectAudioTrack - Remove deprecated iOS 10/macOS 10.12 compatibility code for selectedMediaOptionInMediaSelectionGroup - Use currentMediaSelection API directly (available since iOS 11.0/macOS 10.13)

- Remove testGetAudioTracksWithNoCurrentItem test - Remove testGetAudioTracksWithNoAsset test - These tests are no longer needed after refactoring to use assertions instead of nil checks

…/flutter_packages into 28-oct-platform-avfoundation

Cherry-picked from upstream PR flutter#10313: - Implement getAudioTracks() to retrieve available audio tracks - Implement selectAudioTrack() to switch between tracks - Implement isAudioTrackSupportAvailable() for runtime capability detection - Support both HLS streams and regular video files - Add comprehensive tests for audio track functionality - Update Pigeon definitions for audio track interface - Bump minimum OS requirements (iOS 13+, macOS 10.15+) - Bump version to 2.9.0 Source: flutter#10313

nateshmbhat · 2025-12-09T16:07:53Z

any update on this guys ? 😄
The android PR got approved with all checks passing ✅ and is about to get merged. It would be great if this IOS PR also can be reviewed.

i'm willing to quickly address any comments and make required changes. please do the needful from your side and support in getting this PR landed.

stuartmorgan-g · 2025-12-09T17:15:26Z

any update on this guys ?

@nateshmbhat I have asked you several times on these PRs to stop pinging people for updates/reviews. We have a regular process for following up on reviews, and will handle reminders within the team as necessary.

please do the needful from your side and support in getting this PR landed.

Delays in review happen because everyone involved in the reviews has a lot of work they are balancing. The problem is not that the Flutter team does not understand what their jobs entail, and implying otherwise is disrespectful to the team.

tarrinneal

Seems like some of the repo lints have changed since you uploaded this. I noted a couple, but you'll need to update the formatting also.

My approval is for the dart code only. All darwin code will need approval from a member of the ios team before this can land.

packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat requested review from LongCatIsLooong and hellohuanlin as code owners October 28, 2025 15:06

github-actions bot added platform-ios platform-macos p: video_player labels Oct 28, 2025

nateshmbhat mentioned this pull request Oct 28, 2025

[video_player] Adds audio track metadata fetching and audio track selection feature #9925

Open

11 tasks

gemini-code-assist bot reviewed Oct 28, 2025

View reviewed changes

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Oct 28, 2025

nateshmbhat force-pushed the 28-oct-platform-avfoundation branch from 4784bd8 to 459e7f8 Compare November 7, 2025 16:32

nateshmbhat changed the title ~~feat(video): add audio track selection support for AVFoundation~~ feat(ios): add audio track selection support for AVFoundation Nov 7, 2025

chore(video_player): bump minimum OS versions for iOS and macOS

272ff1d

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat requested a review from tarrinneal as a code owner November 7, 2025 17:15

Merge branch 'main' into 28-oct-platform-avfoundation

6905f0a

This comment was marked as off-topic.

Sign in to view

nateshmbhat added 2 commits November 19, 2025 20:27

Merge branch 'main' into 28-oct-platform-avfoundation

b253fa4

Merge branch 'main' into 28-oct-platform-avfoundation

1bfefef

This comment was marked as off-topic.

Sign in to view

LongCatIsLooong reviewed Nov 25, 2025

View reviewed changes

nateshmbhat and others added 7 commits November 26, 2025 21:23

Update packages/video_player/video_player_avfoundation/darwin/video_p…

32ab95d

…layer_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m Co-authored-by: LongCatIsLooong <[email protected]>

Merge branch 'main' into 28-oct-platform-avfoundation

9f13dc2

refactor(ios): remove audio selection options caching

dcb886d

- Remove _cachedAudioSelectionOptions instance variable - Fetch options from media selection group each time in selectAudioTrack - Address PR review feedback from LongCatIsLooong

Merge branch 'main' into 28-oct-platform-avfoundation

3c8b5d4

Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…

aee5360

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat requested a review from LongCatIsLooong November 27, 2025 08:13

LongCatIsLooong reviewed Dec 1, 2025

View reviewed changes

nateshmbhat added 2 commits December 3, 2025 14:47

Merge branch 'main' into 28-oct-platform-avfoundation

4d78fb2

nateshmbhat requested review from LongCatIsLooong and stuartmorgan-g December 3, 2025 09:18

nateshmbhat added 3 commits December 4, 2025 21:22

test(ios): remove redundant nil-check tests for getAudioTracks

b77c751

- Remove testGetAudioTracksWithNoCurrentItem test - Remove testGetAudioTracksWithNoAsset test - These tests are no longer needed after refactoring to use assertions instead of nil checks

chore(video_player_avfoundation): bump version to 2.9.0

31858c4

Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…

d2f6def

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat requested a review from LouiseHsu as a code owner December 4, 2025 15:53

vashworth removed the request for review from hellohuanlin December 4, 2025 22:39

Merge branch 'main' into 28-oct-platform-avfoundation

f17d787

tarrinneal approved these changes Dec 10, 2025

View reviewed changes

packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart Outdated Show resolved Hide resolved

packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart Outdated Show resolved Hide resolved

nateshmbhat added 5 commits December 10, 2025 13:23

fixed lint warning

c9e9d42

Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…

4c7c534

…/flutter_packages into 28-oct-platform-avfoundation

Merge branch 'main' into 28-oct-platform-avfoundation

c60befb

Format avfoundation_video_player.dart

93989eb

Merge branch 'main' into 28-oct-platform-avfoundation

731400a

feat(ios): add audio track selection support for AVFoundation #10313

Are you sure you want to change the base?

feat(ios): add audio track selection support for AVFoundation #10313

Uh oh!

Conversation

nateshmbhat commented Oct 28, 2025

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

nateshmbhat commented Nov 7, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

tarrinneal commented Nov 24, 2025

Uh oh!

LongCatIsLooong commented Nov 25, 2025

Uh oh!

LongCatIsLooong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nateshmbhat commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nateshmbhat commented Dec 9, 2025

Uh oh!

stuartmorgan-g commented Dec 9, 2025

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment •

edited

Loading