[camera_android_camerax] Modify plugin to assume mp4 format for captured videos #10273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Oct 23, 2025
Contributor
There was a problem hiding this comment.
- If for some reason this is a catastrophic change, we can always revert. We could also pursue determining the format ourselves but I think raising the concern to the CameraX team is a more reliable solution long term.
I dont love the justification in #3 of the pr description. I think in practice we have spent time trying to find a situation where the extension is something other than mp4 and have not been successful.
camsim99
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/10273, because Pull request flutter/packages/10273 is not in a mergeable state. |
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2025
…or captured videos (flutter/packages#10273)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2025
flutter/packages@9ec29b6...53d6138 2025-10-23 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.37.0 to 3.38.0 in /packages/interactive_media_ads/android (flutter/packages#10262) 2025-10-23 [email protected] [camera_android_camerax] Modify plugin to assume mp4 format for captured videos (flutter/packages#10273) 2025-10-23 [email protected] [camera_android_x] Refactor ImageProxyUtils.planesToNV21 to prevent buffer issues (flutter/packages#10163) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@9ec29b6...53d6138 2025-10-23 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.37.0 to 3.38.0 in /packages/interactive_media_ads/android (flutter/packages#10262) 2025-10-23 [email protected] [camera_android_camerax] Modify plugin to assume mp4 format for captured videos (flutter/packages#10273) 2025-10-23 [email protected] [camera_android_x] Refactor ImageProxyUtils.planesToNV21 to prevent buffer issues (flutter/packages#10163) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the plugin to assume that recorded videos come in the mp4 format instead of using .temp, which we originally set because we aren't 100% sure of the file format.
This is an executive decision I want to make because:
Fixes flutter/flutter#148335.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3