Bumping CI to Test Against JDK 21 #10193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
I've reviewed the changes to update the JDK version in the CI configuration. The changes are straightforward and align with the goal of preparing for a Robolectric upgrade. I have a couple of suggestions to improve build reproducibility by pinning the JDK to a more specific version, which is a common best practice and seems to be followed for other dependencies in this file. Please see my detailed comments below.
github-actions
bot
added
p: camera
p: google_sign_in
p: local_auth
platform-android
labels
Contributor
|
Are changelogs needed? |
jesswrd
changed the title
Contributor
Author
Yes that would be good to add. This is meant to be in draft mb. |
jesswrd
changed the title
Contributor
Author
done |
This was referenced Nov 10, 2025
mboetger
approved these changes
Nov 10, 2025
Contributor
mboetger
left a comment
mboetger
left a comment
There was a problem hiding this comment.
nit: Could you add documentation why suppressing the this-escape warning is not a concern?
Contributor
Author
done |
jesswrd
added
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/10193, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jesswrd
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 12, 2025
flutter/packages@7063d75...e5ecaf7 2025-11-12 [email protected] [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 [email protected] [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 [email protected] [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 [email protected] Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@7063d75...e5ecaf7 2025-11-12 [email protected] [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 [email protected] [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 [email protected] [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 [email protected] Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
flutter/packages@7063d75...e5ecaf7 2025-11-12 [email protected] [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 [email protected] [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 [email protected] [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 [email protected] Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@7063d75...e5ecaf7 2025-11-12 [email protected] [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 [email protected] [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 [email protected] [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 [email protected] Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping CI to Test Against JDK 21. This is part of the setup to use a robolectric version that supports SDK 36. This new robolectric version requires JDK 21 at minimum.
Edit: On JDK 21+ an error is thrown for this-escape warning due to: https://bugs.openjdk.org/browse/JDK-8015831. Addressing the warning requires removing the abstract funciton
createExoPlayerEventListenerin base classVideoPlayer.java, which could cause unknown regressions. Keeping the behavior as-is since the plugin works as expected.Addresses flutter/flutter#163071
Addresses flutter/flutter#177674
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3