[go_router] Applies flutter package lints #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
changed the title
stuartmorgan-g
approved these changes
Mar 4, 2022
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one nit (and one question)
packages/go_router/CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| ## 3.0.4 | |||
|
|
|||
| - Applies flutter package lints. | |||
Collaborator
There was a problem hiding this comment.
I'm not sure "flutter package lints" really describes what's happening here; the lints aren't coming from a package (and not flutter_lints which is what this sort of sounds like). How about "Updates code for stricter analysis options."
|
|
||
| import 'src/auth.dart'; | ||
| import 'src/data/author.dart'; | ||
| import 'src/data/book.dart'; |
Collaborator
There was a problem hiding this comment.
Why were new imports needed?
Contributor
Author
There was a problem hiding this comment.
Something like this
var abc = getAuthor();
does not require importing package that contains the return type.
stuartmorgan-g
pushed a commit
that referenced
this pull request
Oct 31, 2024
Object.operator== takes an `Object`, and no Dart runtime passes a `null` value to an `==` implementation. SvgTheme's implementation should not have an expanded parameter type of `dynamic`. See flutter/flutter#117838 for the overarching issue for Flutter. Co-authored-by: Dan Field <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#98711
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.