Skip to content

[various] Standardize Gradle namespace #10084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 26, 2025
Merged

[various] Standardize Gradle namespace #10084

auto-submit merged 2 commits into from
Sep 26, 2025

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Sep 26, 2025

Standardizes namespace on the = form of property assignment, and updates the existing namespace check to require that version.

Also standardizes these lines on " rather than ' while touching them.

Part of flutter/flutter#176065

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@stuartmorgan-g
[various] Stanadrdize Gradle namespace
dd93392 
Standardizes namespace on the `=` form of property assignment, and
updates the existing namespace check to require that version.

Also standardizes these lines on `"` rather than `'` while touching
them.

Part of flutter/flutter#176065
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 26, 2025
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Sep 26, 2025

CHANGELOG/version override: this is a no-op style change, so doesn't impact clients.

stuartmorgan-g
stuartmorgan-g commented Sep 26, 2025
View reviewed changes
packages/two_dimensional_scrollables/example/android/app/build.gradle
signingConfig signingConfigs.debug
}
}
namespace 'com.example.example'
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example app had somehow ended up with two namespaces.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 26, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the Gradle namespace property to use the = assignment form and double quotes across numerous build.gradle files. It also updates the gradle-check tool to enforce this new convention. The changes are well-executed and improve consistency. I've found one issue in the test suite where a test case is not correctly asserting a failure, which could lead to undetected regressions.

reidbaker
reidbaker approved these changes Sep 26, 2025
View reviewed changes
script/tool/lib/src/gradle_check_command.dart
/// compatibility with apps that use AGP 8+.
bool _validateNamespace(RepositoryPackage package, String gradleContents,
{required bool isExample}) {
// Regex to validate that either of the following namespace definitions
Copy link
Contributor

@reidbaker reidbaker Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete "of"

Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to rewrite the sentence more than I did; I'm not sure what happened.

Piinks
Piinks approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 26, 2025

autosubmit label was removed for flutter/packages/10084, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

chunhtai
chunhtai approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2025
@stuartmorgan-g stuartmorgan-g changed the title [various] Stanadrdize Gradle namespace [various] Standardize Gradle namespace Sep 26, 2025
@auto-submit auto-submit bot merged commit b783df0 into flutter:main Sep 26, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
b783df0 [various] Standardize Gradle namespace (flutter/packages#10084
a9b68da 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
Roll Packages from 389c678 to 34eec78 (6 revisions) (#176205)
96fe3b3 
flutter/packages@389c678...34eec78

2025-09-29 [email protected] [camera_android_camerax] Implement
setDescriptionWhileRecording (flutter/packages#10030)
2025-09-29 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#10114)
2025-09-27 [email protected] [various] Standardize Java compat in
Gradle (flutter/packages#10091)
2025-09-26 [email protected] [various] Standardize gradle
dependencies (flutter/packages#10083)
2025-09-26 [email protected] [go_router_builder] Ignore upcoming
`experimental_member_use` warnings. (flutter/packages#10082)
2025-09-26 [email protected] [various] Standardize Gradle
`namespace` (flutter/packages#10084)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@engine-flutter-autoroll @reidbaker
Roll Packages from 389c678 to 34eec78 (6 revisions) (flutter#176205)
c2290e3 
flutter/packages@389c678...34eec78

2025-09-29 [email protected] [camera_android_camerax] Implement
setDescriptionWhileRecording (flutter/packages#10030)
2025-09-29 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#10114)
2025-09-27 [email protected] [various] Standardize Java compat in
Gradle (flutter/packages#10091)
2025-09-26 [email protected] [various] Standardize gradle
dependencies (flutter/packages#10083)
2025-09-26 [email protected] [go_router_builder] Ignore upcoming
`experimental_member_use` warnings. (flutter/packages#10082)
2025-09-26 [email protected] [various] Standardize Gradle
`namespace` (flutter/packages#10084)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@reidbaker reidbaker reidbaker approved these changes

@Piinks Piinks Piinks approved these changes

@chunhtai chunhtai chunhtai approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@ash2moon ash2moon Awaiting requested review from ash2moon

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@jesswrd jesswrd Awaiting requested review from jesswrd jesswrd is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@mboetger mboetger Awaiting requested review from mboetger mboetger is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_plugin_android_lifecycle p: flutter_svg p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: interactive_media_ads Plugin for IMA SDK p: local_auth p: path_provider p: pigeon p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartmorgan-g @domesticmouse @reidbaker @Piinks @chunhtai