[camera_android_camerax] Implement setDescriptionWhileRecording #10030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amera platform packages
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements setDescriptionWhileRecording for the camera_android_camerax package, allowing users to switch cameras during an active video recording. This is achieved by leveraging the experimental asPersistentRecording feature from CameraX. The changes span across the Dart plugin implementation, the native Android (Java/Kotlin) side, and the Pigeon communication layer. Documentation in the README has been updated to reflect the new feature and its usage, and new integration and unit tests have been added to verify the functionality. My review focuses on the core implementation logic and its potential side effects.
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
camsim99
reviewed
Sep 22, 2025
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Looks good but I did catch an error I think we should go ahead and fix and test + do the same for the Gemini suggestion. Thanks for all of the hard work! So excited for this to land :)
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
camsim99
approved these changes
Sep 22, 2025
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Wow thanks for the quick fixes! LGTM :) Just need to resolve merge conflicts.
@bparrishMines for a second review
Contributor
Author
|
I think this PR can be merged @camsim99 |
camsim99
added
the
autosubmit
Contributor
|
@blackorbs-dev Ah sorry yes! Thank you again for your work on this feature! This greatly advances the camera_android_camerax plugin 🥳 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2025
flutter/packages@389c678...34eec78 2025-09-29 [email protected] [camera_android_camerax] Implement setDescriptionWhileRecording (flutter/packages#10030) 2025-09-29 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10114) 2025-09-27 [email protected] [various] Standardize Java compat in Gradle (flutter/packages#10091) 2025-09-26 [email protected] [various] Standardize gradle dependencies (flutter/packages#10083) 2025-09-26 [email protected] [go_router_builder] Ignore upcoming `experimental_member_use` warnings. (flutter/packages#10082) 2025-09-26 [email protected] [various] Standardize Gradle `namespace` (flutter/packages#10084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@389c678...34eec78 2025-09-29 [email protected] [camera_android_camerax] Implement setDescriptionWhileRecording (flutter/packages#10030) 2025-09-29 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10114) 2025-09-27 [email protected] [various] Standardize Java compat in Gradle (flutter/packages#10091) 2025-09-26 [email protected] [various] Standardize gradle dependencies (flutter/packages#10083) 2025-09-26 [email protected] [go_router_builder] Ignore upcoming `experimental_member_use` warnings. (flutter/packages#10082) 2025-09-26 [email protected] [various] Standardize Gradle `namespace` (flutter/packages#10084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDescriptionWhileRecording allows switching camera while a video recording is in progress
Fixes #148013
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3