[Gradle 9] Fixed Gradle 9 Deprecations in Packages #10016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesswrd
requested review from
ash2moon,
bparrishMines,
camsim99,
domesticmouse and
reidbaker
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
p: camera
p: flutter_plugin_android_lifecycle
p: quick_actions
platform-android
p: interactive_media_ads
jesswrd
added
override: no versioning needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various Gradle build files to fix deprecations for Gradle 9. The changes primarily involve updating the Groovy DSL syntax to use property assignment, replacing the deprecated jcenter() repository with mavenCentral(), and updating the Kotlin Gradle plugin version. The changes are mostly correct and address the goal of the PR. I've found one area for improvement regarding a redundant buildscript block in one of the settings files.
reidbaker
approved these changes
Sep 16, 2025
Contributor
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
These changes look good but we dont have anything in this pr preventing regressions back to using the space assignment syntax. It doesnt need to be in this pr but consider modifying gradle check to enforce some of these changes.
domesticmouse
approved these changes
Sep 22, 2025
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
LGTM once @reidbaker's concerns are dealt with
jesswrd
requested review from
Hixie,
chunhtai and
stuartmorgan-g
as code owners
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: rfw
reidbaker
approved these changes
Sep 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 6, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Oct 7, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
When Flutter clients use published plugins that depend on other outdated/older plugins with an app using Gradle 9, they will be using outdated Gradle 9 deprecated patterns (in `build.gradle`). To ensure usage of resolved deprecated build.gradle files, Flutter clients can specify the pub version in this PR. Should have included versioning and changelog in this PR: #10016 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all Gradle 9 deprecations in packages repo.
Fixes flutter/flutter#173320
Partially Adresses flutter/flutter#173318
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3