Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ef0c65e
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e04ba88
Choose a head ref
  • 5 commits
  • 12 files changed
  • 4 contributors

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    8d553e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. [image_picker] Copy exif tags in categories II and III (#4738)

    Added all exif tags from Category II and Category III (excluding ones that don't have consts in `ExifInterface` WaterDepth etc.). Those tags include data not related to the structure of the file itself so resizing definitely doesn't invalidate them and thus they should be copied over.
    
    I've also switched from list of raw strings to consts provided be the `ExifInterface`
    
    I'm not sure show to handle `TAG_ISO_SPEED_RATINGS` deprecation in this case. The const is deprecated and the tag itself is deprecated in the standard however it would be reasonable to copy it as well to handle legacy files which include it. It was also being copied in the previous versions of this package.
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    flutter/flutter#132827
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    RobertOdrowaz authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4512e4d View commit details
    Browse the repository at this point in the history
  2. [ios_platform_images] Add integration tests (#4899)

    Currently there are no end-to-end tests for this package that would fail if the communication with the native implementation didn't work, or if the native implementation were broken. This is especially problematic since we want to convert this plugin to both Swift and Pigeon, each of which has the potential to break things that would currently not be caught.
    
    This adds basic integration tests of both methods to ensure that the simple case of a successful call works as expected.
    stuartmorgan-g authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b04d2cc View commit details
    Browse the repository at this point in the history
  3. [flutter_markdown] Fix changelog regarding minimum supported SDK vers…

    …ion (#4851)
    
    The changelog of the `flutter_markdown` package is a bit confusing. First it says:
    
    > Updates minimum supported SDK version to Flutter 3.10/Dart 3.0
    
    and in the latest update is says
    
    > Updates minimum supported SDK version to Flutter 3.7/Dart 2.19
    
    Just from reading this I would expect that the minimum SDK lowered with the latest update. However, this is not the case.
    
    After a bit of researching, I found this was caused by #4731. The mentioned PR only updates the minimum SDK of the example but not of the package, see: https://github.com/flutter/packages/pull/4731/files#diff-e780ee3aec5fdc10512b452b5464878a11caf22fb23d28f725324308ad243d17R6
    
    Therefore, I clarified the changelog with this PR.
    
    ![telegram-cloud-photo-size-2-5456132896298487892-y](https://github.com/flutter/flutter/assets/24459435/c992917a-7eda-4e45-a656-50408a6c8910)
    
    <img width="819" alt="image" src="https://github.com/flutter/flutter/assets/24459435/bee2f046-ea86-45c7-9567-a19949e3e6f8">
    
    Fixes flutter/flutter#134056
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    nilsreichardt authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c9fbe4e View commit details
    Browse the repository at this point in the history
  4. [tool] Add a package inclusion filter (#4904)

    Creates a package filter flag that is an opt-in mirror to the `exclude` flag, for use with the automatic package selection options used in CI. Like `exclude`, it allows for YAML files as input.
    
    This allows for creating split test runs in CI (e.g., during incremental migrations), where the same file is an inclusion filter for one run and an exclusion filter for the other, guaranteeing that tests are in one or the other without the possibility of some tests falling through the cracks.
    stuartmorgan-g authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e04ba88 View commit details
    Browse the repository at this point in the history
Loading