-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Comparing changes
Open a pull request
base repository: flutter/packages
base: ef0c65e
head repository: flutter/packages
compare: e04ba88
- 5 commits
- 12 files changed
- 4 contributors
Commits on Sep 11, 2023
-
[google_maps_flutter_android] Fix for testToggleInfoWindow persistent…
…ly flaky (#4768) Fixes issue: flutter/flutter#131783
Configuration menu - View commit details
-
Copy full SHA for 8d553e3 - Browse repository at this point
Copy the full SHA 8d553e3View commit details
Commits on Sep 12, 2023
-
[image_picker] Copy exif tags in categories II and III (#4738)
Added all exif tags from Category II and Category III (excluding ones that don't have consts in `ExifInterface` WaterDepth etc.). Those tags include data not related to the structure of the file itself so resizing definitely doesn't invalidate them and thus they should be copied over. I've also switched from list of raw strings to consts provided be the `ExifInterface` I'm not sure show to handle `TAG_ISO_SPEED_RATINGS` deprecation in this case. The const is deprecated and the tag itself is deprecated in the standard however it would be reasonable to copy it as well to handle legacy files which include it. It was also being copied in the previous versions of this package. *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#132827 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 4512e4d - Browse repository at this point
Copy the full SHA 4512e4dView commit details -
[ios_platform_images] Add integration tests (#4899)
Currently there are no end-to-end tests for this package that would fail if the communication with the native implementation didn't work, or if the native implementation were broken. This is especially problematic since we want to convert this plugin to both Swift and Pigeon, each of which has the potential to break things that would currently not be caught. This adds basic integration tests of both methods to ensure that the simple case of a successful call works as expected.
Configuration menu - View commit details
-
Copy full SHA for b04d2cc - Browse repository at this point
Copy the full SHA b04d2ccView commit details -
[flutter_markdown] Fix changelog regarding minimum supported SDK vers…
…ion (#4851) The changelog of the `flutter_markdown` package is a bit confusing. First it says: > Updates minimum supported SDK version to Flutter 3.10/Dart 3.0 and in the latest update is says > Updates minimum supported SDK version to Flutter 3.7/Dart 2.19 Just from reading this I would expect that the minimum SDK lowered with the latest update. However, this is not the case. After a bit of researching, I found this was caused by #4731. The mentioned PR only updates the minimum SDK of the example but not of the package, see: https://github.com/flutter/packages/pull/4731/files#diff-e780ee3aec5fdc10512b452b5464878a11caf22fb23d28f725324308ad243d17R6 Therefore, I clarified the changelog with this PR.  <img width="819" alt="image" src="https://github.com/flutter/flutter/assets/24459435/bee2f046-ea86-45c7-9567-a19949e3e6f8"> Fixes flutter/flutter#134056 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for c9fbe4e - Browse repository at this point
Copy the full SHA c9fbe4eView commit details -
[tool] Add a package inclusion filter (#4904)
Creates a package filter flag that is an opt-in mirror to the `exclude` flag, for use with the automatic package selection options used in CI. Like `exclude`, it allows for YAML files as input. This allows for creating split test runs in CI (e.g., during incremental migrations), where the same file is an inclusion filter for one run and an exclusion filter for the other, guaranteeing that tests are in one or the other without the possibility of some tests falling through the cracks.
Configuration menu - View commit details
-
Copy full SHA for e04ba88 - Browse repository at this point
Copy the full SHA e04ba88View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ef0c65e...e04ba88