Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d0411e4
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 98ebcd3
Choose a head ref
  • 3 commits
  • 23 files changed
  • 3 contributors

Commits on Sep 21, 2023

  1. [webview_flutter_wkwebview] Adds WKWebView implementation to override… 

    … console log (#4703)

Adds the WKWebView implementation for registering a JavaScript console callback. This will allow developers to receive JavaScript console messages in a Dart callback.

This PR contains the `webview_flutter_wkwebview` specific changes from PR #4541.

Related issue: flutter/flutter#32908

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    @mvanbeusekom
    mvanbeusekom authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7eee49a View commit details
    Browse the repository at this point in the history

  2. [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… ( 

    #4723)

�a to null if extra is not serializable.

This was a mistake I made when I refactor the code, the goBranch uses GoRouter.restore which will go through unnecessary serialize/deserialize. Fixing this will unfortunately introduce a breaking change, though I don't think a lot of people will be impacted by this.

I will write a migration guide soon

fixes flutter/flutter#129347
    @chunhtai
    chunhtai authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    55b7293 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Manual roll Flutter (stable) from 367f9ea16bfa to 12fccda59847 (2 rev… 

    …isions) (#4976)

Manual roll requested by [email protected]

flutter/flutter@367f9ea...12fccda

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-stable-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    98ebcd3 View commit details
    Browse the repository at this point in the history
Loading