Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c070b0a
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d0e9a0e
Choose a head ref
  • 5 commits
  • 41 files changed
  • 4 contributors

Commits on Sep 28, 2023

  1. Bump github/codeql-action from 2.21.8 to 2.21.9 (#5020) 

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.8 to 2.21.9.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
<li>Update default CodeQL bundle version to 2.14.4. <a href="https://redirect.github.com/github/codeql-action/pull/1873">#1873</a></li>
</ul>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
<li>Fix an issue that first appeared in CodeQL Action v2.21.2 that prevented CodeQL invocations from being logged. <a href="https://redirect.github.com/github/codeql-action/pull/1833">#1833</a></li>
<li>We are rolling out a feature in August 2023 that will improve the quality of file coverage information. <a href="https://redirect.github.com/github/codeql-action/pull/1835">#1835</a></li>
</ul>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817">#1817</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/ddccb873888234080b77e9bc2d4764d5ccaaccf9"><code>ddccb87</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1905">#1905</a> from github/update-v2.21.9-27cb1e1de</li>
<li><a href="https://github.com/github/codeql-action/commit/d8cb5a2a0f7f14c27bce8225c2b873a03022558f"><code>d8cb5a2</code></a> Update changelog for v2.21.9</li>
<li><a href="https://github.com/github/codeql-action/commit/27cb1e1de53ee44dfb3046ddb445f049b3ab5f0d"><code>27cb1e1</code></a> Bump the npm group with 6 updates (<a href="https://redirect.github.com/github/codeql-action/issues/1902">#1902</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/4818fdd8ec23bed8e104545faccfbf1bb18c215d"><code>4818fdd</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1903">#1903</a> from github/henrymercer/sublanguage-file-coverage</li>
<li><a href="https://github.com/github/codeql-action/commit/e548601be3f34426a0152f0e1029a9d10520feb7"><code>e548601</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1897">#1897</a> from github/update-bundle/codeql-bundle-v2.14.6</li>
<li><a href="https://github.com/github/codeql-action/commit/cc6542087a86f57147423791597cf4276ff3843a"><code>cc65420</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.14.6</li>
<li><a href="https://github.com/github/codeql-action/commit/c95737bb4371da8070acea8b9a06faac476fa5c0"><code>c95737b</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/41d2ffad87893f25fc86304ae41c5c993052823e"><code>41d2ffa</code></a> Enable sub-language file coverage behind a ff</li>
<li><a href="https://github.com/github/codeql-action/commit/650a85ef6dcc106796885216fea54e4d74e65dee"><code>650a85e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1901">#1901</a> from github/henrymercer/check-for-duplicated-languages</li>
<li><a href="https://github.com/github/codeql-action/commit/0de36d45947b6f7e470c715b4dd88c45f23067ea"><code>0de36d4</code></a> Merge branch 'main' into henrymercer/check-for-duplicated-languages</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/6a28655e3dcb49cb0840ea372fd6d17733edd8a4...ddccb873888234080b77e9bc2d4764d5ccaaccf9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.8&new-version=2.21.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
    @dependabot
    dependabot[bot] authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e245ec5 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter (stable) from 12fccda59847 to ead455963c12 (1 revision) (#… 

    …5022)

flutter/flutter@12fccda...ead4559

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-stable-packages
Please CC [email protected],[email protected],[email protected]
on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter (stable):
https://github.com/flutter/flutter/issues/new/choose
To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    138b4dc View commit details
    Browse the repository at this point in the history

  3. [camera] Fix Android autofocus state reading (#5025) 

    Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine.

Fixes flutter/flutter#135554
Part of flutter/flutter#84957
    @stuartmorgan-g
    stuartmorgan-g authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    245a8a0 View commit details
    Browse the repository at this point in the history

  4. Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (#5011) 

    Manual roll Flutter from f92884c to ff4a0f6 (107 revisions)

Manual roll requested by [email protected]

flutter/flutter@f92884c...ff4a0f6

2023-09-27 [email protected] Native assets support for Windows
(flutter/flutter#134203)
2023-09-27 [email protected] ✨ `flutter config --list`
(flutter/flutter#135401)
2023-09-27 [email protected] Roll Flutter Engine from
0a8ad236e4af to f70f65f7a622 (5 revisions) (flutter/flutter#135549)
2023-09-27 [email protected] Roll Flutter Engine from
acdb364a42d5 to 0a8ad236e4af (5 revisions) (flutter/flutter#135527)
2023-09-27 [email protected] Revert "Switch flutter_tools to run
frontend server from AOT snapshot" (flutter/flutter#135537)
2023-09-27 [email protected] [documentation] remove repeated "For
example," in RenderSliverEdgeInsetsPadding documentation
(flutter/flutter#135297)
2023-09-26 [email protected] [flutter_tools] fix tests with no
native assets running native asset build (flutter/flutter#135474)
2023-09-26 [email protected] Allow multiple ParentDataWidgets to
write to ParentData (flutter/flutter#133581)
2023-09-26 [email protected] SelectionArea long press
selection overlay behavior should match native (flutter/flutter#133967)
2023-09-26 [email protected] Switch flutter_tools to run frontend server
from AOT snapshot (flutter/flutter#135255)
2023-09-26 [email protected] Roll Flutter Engine from
7b989a28514e to acdb364a42d5 (2 revisions) (flutter/flutter#135516)
2023-09-26 [email protected] [Windows] Add
more Arm64 compile and run tests (flutter/flutter#135475)
2023-09-26 [email protected] Wait for
CONFIGURATION_BUILD_DIR to update when debugging with Xcode
(flutter/flutter#135444)
2023-09-26 [email protected] Roll Packages from
e548ae1 to 619af75 (4 revisions) (flutter/flutter#135505)
2023-09-26 [email protected] Roll Flutter Engine from
230dfeed79ed to 7b989a28514e (2 revisions) (flutter/flutter#135494)
2023-09-26 [email protected] Roll Flutter Engine from
75950dc280d5 to 230dfeed79ed (3 revisions) (flutter/flutter#135489)
2023-09-26 [email protected] Roll Flutter Engine from
6bf8067392cf to 75950dc280d5 (4 revisions) (flutter/flutter#135480)
2023-09-26 [email protected] Add "Frame Request Pending" lag to
collected metrics (flutter/flutter#135279)
2023-09-26 [email protected] Roll Flutter Engine from
3f606570ac7c to 6bf8067392cf (8 revisions) (flutter/flutter#135472)
2023-09-25 [email protected] Roll Flutter Engine from
1ae3d20332f0 to 3f606570ac7c (6 revisions) (flutter/flutter#135457)
2023-09-25 [email protected] [macOS,iOS] Improve CocoaPods upgrade
instructions (flutter/flutter#135453)
2023-09-25 [email protected] Fix and Test Conditional
Validator Behavior in FormField (flutter/flutter#132714)
2023-09-25 [email protected] [Velocity Tracker] Fix: Issue 97761:
Flutter Scrolling does not match iOS; inadvertent scrolling when user
lifts up finger (flutter/flutter#132291)
2023-09-25 [email protected]
simulatedAccessibilityTraversal account for force merging
(flutter/flutter#135178)
2023-09-25 [email protected] Roll Flutter Engine from
2c4c1108aa87 to 1ae3d20332f0 (4 revisions) (flutter/flutter#135438)
2023-09-25 [email protected] Roll Packages from
98ebcd3 to e548ae1 (5 revisions) (flutter/flutter#135431)
2023-09-25 [email protected] Roll Flutter Engine from
e6d3bac5c723 to 2c4c1108aa87 (1 revision) (flutter/flutter#135424)
2023-09-25 [email protected] Revert "Marks
Linux_pixel_7pro hello_world_impeller to be unflaky"
(flutter/flutter#135388)
2023-09-25 [email protected] Roll Flutter Engine from
e1c1022c2d6d to e6d3bac5c723 (2 revisions) (flutter/flutter#135410)
2023-09-25 [email protected] Roll Flutter Engine from
3ea1174ecfaa to e1c1022c2d6d (2 revisions) (flutter/flutter#135403)
2023-09-25 [email protected] Roll Flutter Engine from
2daf5e7bb249 to 3ea1174ecfaa (4 revisions) (flutter/flutter#135396)
2023-09-25 [email protected] Add a basic
golden test for `CupertinoTextSelectionToolbar` (flutter/flutter#135267)
2023-09-25 [email protected] Revert "Marks Linux_samsung_a02
new_gallery__transition_perf to be unflaky" (flutter/flutter#135399)
2023-09-25 [email protected] Marks Linux_samsung_a02
new_gallery__transition_perf to be unflaky (flutter/flutter#135373)
2023-09-25 [email protected] Fix failing test at master.
(flutter/flutter#135394)
2023-09-24 [email protected] Marks Linux_pixel_7pro
hello_world_impeller to be unflaky (flutter/flutter#135372)
2023-09-24 [email protected] Marks Windows_android
channels_integration_test_win to be unflaky (flutter/flutter#135374)
2023-09-24 [email protected] Marks Mac_ios
draw_atlas_perf_ios__timeline_summary to be unflaky
(flutter/flutter#134626)
2023-09-24 [email protected] Marks Mac_ios
draw_vertices_perf_ios__timeline_summary to be unflaky
(flutter/flutter#134625)
2023-09-24 [email protected] Marks Windows module_test to be
unflaky (flutter/flutter#134121)
2023-09-24 [email protected] Marks Mac_ios
dynamic_path_tessellation_perf_ios__timeline_summary to be unflaky
(flutter/flutter#133128)
2023-09-24 [email protected] Marks Mac_ios
draw_points_perf_ios__timeline_summary to be unflaky
(flutter/flutter#127933)
2023-09-24 [email protected] Marks Linux_pixel_7pro
picture_cache_perf__timeline_summary to be unflaky
(flutter/flutter#134118)
2023-09-24 [email protected] Roll Flutter Engine from
ee27600dfbe2 to 2daf5e7bb249 (1 revision) (flutter/flutter#135371)
...

---------

Co-authored-by: Maurice Parrish <[email protected]>
    @engine-flutter-autoroll @bparrishMines
    engine-flutter-autoroll and bparrishMines authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9f3005c View commit details
    Browse the repository at this point in the history

  5. [video_player] Endorse macOS (#5021) 

    Endorses the macOS implementation of `video_player`, updating the constraint of the existing `video_player_avfoundation` dependency to ensure macOS support is present. Adds macOS support to the example, and adds macOS discussion to the README.

This is the first macOS plugin with multiple integration test files, which turned up a bug in `flutter test`, so this also includes a repo tooling change to work around that bug for now by running each integration test file separately on macOS (as we already have to do with `flutter drive` on web).

Fixes flutter/flutter#41688
    @stuartmorgan-g
    stuartmorgan-g authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d0e9a0e View commit details
    Browse the repository at this point in the history
Loading