Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bc72d15
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d9874f
Choose a head ref
  • 9 commits
  • 91 files changed
  • 7 contributors

Commits on Nov 30, 2023

  1. Roll Flutter from 5e5b529 to 918e336 (14 revisions) (#5526)

    flutter/flutter@5e5b529...918e336
    
    2023-11-30 [email protected] Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280)
    2023-11-30 [email protected] Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708)
    2023-11-30 [email protected] Use the correct recipe on fuchsia_precache. (flutter/flutter#139279)
    2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278)
    2023-11-30 [email protected] Migrate fuchsia_precache to shard tests. (flutter/flutter#139202)
    2023-11-29 [email protected] Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685)
    2023-11-29 [email protected] Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259)
    2023-11-29 [email protected] Refactor to use Apple system fonts (flutter/flutter#137275)
    2023-11-29 [email protected] Dynamic view sizing (flutter/flutter#138648)
    2023-11-29 [email protected] Roll dependencies (flutter/flutter#139203)
    2023-11-29 [email protected] add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936)
    2023-11-29 [email protected] Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250)
    2023-11-29 [email protected] Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509)
    2023-11-29 [email protected] Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9cdc001 View commit details
    Browse the repository at this point in the history
  2. [google_sign_in] Add server auth code retrieval to gis_client (#5358)

    Adds the ability for a Flutter web app to request a server auth code via gis through a web-only method.
    
    Reference docs:
    * https://developers.google.com/identity/oauth2/web/guides/use-code-model
    * https://developers.google.com/identity/oauth2/web/reference/js-reference#google.accounts.oauth2.initCodeClient
    
    Also: adds a `web_only.dart` library that allows programmers to call web-only methods conveniently, without having to dive into the `Platform.instance` (which has a ton of methods that we don't want users to call for sure!), like this:
    
    ```dart
    import 'package:google_sign_in_web/web_only.dart' as web;
    
    /// Renders a web-only Sign-In button.
    Widget buildSignInButton({HandleSignInFn? _}) {
      return web.renderButton();
    }
    ```
    
    Instead of:
    
    https://github.com/flutter/packages/blob/a6821898bd5a968f8ddafa8ae8e9a8c889caa00a/packages/google_sign_in/google_sign_in/example/lib/src/sign_in_button/web.dart#L12-L15
    
    ### Issues
    
    * Fixes flutter/flutter#62474
    
    ### Tests
    
    * Added tests to ensure plugin calls hit the GIS API when appropriate.
    
    * [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
    * [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
    * [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
    * [x] I signed the [CLA].
    * [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
    * [x] I listed at least one issue that this PR fixes in the description above.
    * [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
    * [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
    * [x] I updated/added relevant documentation (doc comments with ///).
    * [x] I added new tests to check the change I am making, or this PR is [test-exempt].
    * [x] All existing and new tests are passing.
    T-P-F authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    39678d1 View commit details
    Browse the repository at this point in the history
  3. [pointer_interceptor] Re-land: Add platform interface (#5525)

    Addresses flutter/flutter#30143 by adding an iOS implementation
    
    This PR is Part 1 of #5233
    
    This reverts commit bc72d15 and then fixes the topic format
    stuartmorgan-g authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    293b071 View commit details
    Browse the repository at this point in the history
  4. [google_maps_flutter] Add support for version 8 of the iOS SDK (#5528)

    - Increases the max allowed SDK version to 8.x
    - Adds a new iOS 14 example app, per [the documented test structure/plan](https://github.com/flutter/packages/blob/main/packages/google_maps_flutter/google_maps_flutter_ios/example/README.md)
    - Moves recently added XCUITests to the iOS 11 example app, where they should have been (per doc linked above). I missed this when reviewing the addition, and noticed that it was incorrectly in the iOS 13 example while duplicating the iOS 13 example for the iOS 14 version.
    
    Fixes flutter/flutter#138972
    stuartmorgan-g authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    eeecbd4 View commit details
    Browse the repository at this point in the history
  5. [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (#5520)

    * Migrates the web implementation of `cross_file` from `dart:html` to `package:web`, so it can be compiled with `dart2wasm`.
    * Bumps minimum sdk version.
    
    Part of flutter/flutter#117022
    kevmoo authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7a11e2d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. [flutter_image] Adopt code excerpts in README (#5498)

    Updates the README to use a compiled excerpt source for its example of using `NetworkImageWithRetry`.
    
    Part of [flutter/flutter#102679](flutter/flutter#102679)
    mike-v2 authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    44a8ce1 View commit details
    Browse the repository at this point in the history
  2. Reenable macOS 13 tests (#5494)

    A workaround was added for flutter/flutter#138238, so let's re-enable macOS 13 tests
    vashworth authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2c8512a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. [gsi_web] Do not initialize CodeClient if scopes are empty. (#5537)

    When initializing a `CodeClient`, it is mandatory to pass at least one `scope` (or the JS initialization will crash).
    
    This PR ensures that the `CodeClient` is not created unless `initialScopes.isNotEmpty`, and lets the user know when attempting to use said client that it hasn't been initialized properly.
    
    ## Issues
    
    * Fixes: flutter/flutter#139382
    * Fixes: flutter/flutter#62474
    * Closes: flutter/cocoon#3304 (makes this PR unneeded)
    
    ## Tests
    
    * Tested locally with `cocoon`.
    ditman authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    74925d9 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter from 918e336 to d861ce4 (29 revisions) (#5542)

    flutter/flutter@918e336...d861ce4
    
    2023-12-02 [email protected] Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423)
    2023-12-02 [email protected] Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422)
    2023-12-02 [email protected] Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421)
    2023-12-02 [email protected] Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419)
    2023-12-02 [email protected] Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418)
    2023-12-02 [email protected] Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416)
    2023-12-02 [email protected] Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414)
    2023-12-02 [email protected] Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412)
    2023-12-02 [email protected] Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410)
    2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407)
    2023-12-01 [email protected] Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397)
    2023-12-01 [email protected] [l10n] Update Material shareButtonLabel (flutter/flutter#138899)
    2023-12-01 [email protected] Retry on transient Skia failure. (flutter/flutter#139182)
    2023-12-01 [email protected] Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394)
    2023-12-01 [email protected] Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390)
    2023-12-01 [email protected] Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389)
    2023-12-01 [email protected] Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388)
    2023-12-01 [email protected] Added vscode-insiders path installed via snap (flutter/flutter#137117)
    2023-12-01 [email protected] Typo fix in dartdoc in tool test (flutter/flutter#139386)
    2023-12-01 [email protected] Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348)
    2023-12-01 [email protected] Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346)
    2023-12-01 [email protected] Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345)
    2023-12-01 [email protected] Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342)
    2023-12-01 [email protected] Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264)
    2023-11-30 [email protected] Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674)
    2023-11-30 [email protected] Migrate docs_test to shard. (flutter/flutter#139282)
    2023-11-30 [email protected] Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258)
    2023-11-30 [email protected] Refactor prepare_package.dart (flutter/flutter#139277)
    2023-11-30 [email protected] Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    5d9874f View commit details
    Browse the repository at this point in the history
Loading