-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Comparing changes
Open a pull request
base repository: flutter/packages
base: 407b7da
head repository: flutter/packages
compare: 6bd59cd
- 5 commits
- 22 files changed
- 3 contributors
Commits on May 3, 2023
-
Revert "[pigeon]enable treat warning as errors for swift code in unit…
Configuration menu - View commit details
-
Copy full SHA for 3fcf671 - Browse repository at this point
Copy the full SHA 3fcf671View commit details -
[camera_platform_interface] [camera] [camera_android] Add NV21 as an …
…image stream format (#3277) ### Note: this is a re-created PR from flutter/plugins#6985 --- This PR adds NV21 as an image stream format for android devices. This is the format required for things like MLKit. Unfortunately a lot of people tend to implement the yuv->nv21 incorrectly in dart, which results in countless issues of users saying the image stream doesn't work, or that mlkit doesn't work. By allowing the plugin to send NV21 to dart, this will fix all of those yuv conversion issues. Highlights: - Added an abstraction around `ImageReader` called `ImageStreamReader` and moved the image stream logic into this class to clean up the `Camera` class. This allows us to test the image stream handler in isolation. - Added tests for `ImageStreamReader` to make sure it only calls the `removePlaneBufferPadding` function for planes that contain padding. - Added a new utility class called `ImageStreamReaderUtils` which contains the logic for trimming the padding. - Added tests for `ImageStreamReaderUtils` to make sure it only removes padding when a given buffer contains padding to be removed. - There are tests to confirm both that `removePlaneBufferPadding` is only called when padding is present, and to confirm that if `removePlaneBufferPadding` does happen to be called with a buffer containing no padding, it still returns a valid buffer. *List which issues are fixed by this PR. You must list at least one issue.* - flutter/flutter#118350 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 4c4bb46 - Browse repository at this point
Copy the full SHA 4c4bb46View commit details
Commits on May 4, 2023
-
[quick_actions] Fix Android lint issues (#3885)
Removes lint-baseline.xml and fixes all warnings. Part of flutter/flutter#88011
Configuration menu - View commit details
-
Copy full SHA for 2642249 - Browse repository at this point
Copy the full SHA 2642249View commit details -
[video_player] Fix Android lints (#3886)
Removes lint-baseline.xml and fixes all exposed lints. Includes an update of Pigeon to the latest version, to pick up warning fixes in generated code. Part of flutter/flutter#88011
Configuration menu - View commit details
-
Copy full SHA for d9f7041 - Browse repository at this point
Copy the full SHA d9f7041View commit details -
[pigeon][reland]enable treat warnings as errors for swift code in uni…
…t test (#3901) `as [Any?]` here is actually not a "cast", but a "type annotation". An equivalent fix can be: ``` let arg: [Any?] = [nil] let inputEncoded = binaryMessenger.codec.encode(arg) ``` Fixes ``` heterogeneous collection literal could only be inferred to '[Any?]'; add explicit type annotation if this is intentional ``` Which was introduced in #3889 and later got reverted. See flutter/flutter#126006 for more details about some interesting research on this warning. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#126006 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 6bd59cd - Browse repository at this point
Copy the full SHA 6bd59cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 407b7da...6bd59cd