Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 407b7da
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6bd59cd
Choose a head ref
  • 5 commits
  • 22 files changed
  • 3 contributors

Commits on May 3, 2023

  1. Revert "[pigeon]enable treat warning as errors for swift code in unit…

    … test" (#3898)
    
    Reverts #3889
    
    The tree is red on a warning in the test code, most likely new in the Xcode version that the tree was just updated to. Reverting so we can re-land this with a fix for the new warning.
    stuartmorgan-g authored May 3, 2023
    Configuration menu
    Copy the full SHA
    3fcf671 View commit details
    Browse the repository at this point in the history
  2. [camera_platform_interface] [camera] [camera_android] Add NV21 as an …

    …image stream format (#3277)
    
    ### Note: this is a re-created PR from flutter/plugins#6985
    ---
    
    This PR adds NV21 as an image stream format for android devices. This is the format required for things like MLKit. Unfortunately a lot of people tend to implement the yuv->nv21 incorrectly in dart, which results in countless issues of users saying the image stream doesn't work, or that mlkit doesn't work.
    
    By allowing the plugin to send NV21 to dart, this will fix all of those yuv conversion issues.
    
    Highlights:
    
    -   Added an abstraction around `ImageReader` called `ImageStreamReader` and moved the image stream logic into this class to clean up the `Camera` class. This allows us to test the image stream handler in isolation.
    -   Added tests for `ImageStreamReader` to make sure it only calls the `removePlaneBufferPadding` function for planes that contain padding.
    -   Added a new utility class called `ImageStreamReaderUtils` which contains the logic for trimming the padding.
    -   Added tests for `ImageStreamReaderUtils` to make sure it only removes padding when a given buffer contains padding to be removed.
    -   There are tests to confirm both that `removePlaneBufferPadding` is only called when padding is present, and to confirm that if `removePlaneBufferPadding` does happen to be called with a buffer containing no padding, it still returns a valid buffer.
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
    - flutter/flutter#118350
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    acoutts authored May 3, 2023
    Configuration menu
    Copy the full SHA
    4c4bb46 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. [quick_actions] Fix Android lint issues (#3885)

    Removes lint-baseline.xml and fixes all warnings.
    
    Part of flutter/flutter#88011
    stuartmorgan-g authored May 4, 2023
    Configuration menu
    Copy the full SHA
    2642249 View commit details
    Browse the repository at this point in the history
  2. [video_player] Fix Android lints (#3886)

    Removes lint-baseline.xml and fixes all exposed lints. Includes an update of Pigeon to the latest version, to pick up warning fixes in generated code.
    
    Part of flutter/flutter#88011
    stuartmorgan-g authored May 4, 2023
    Configuration menu
    Copy the full SHA
    d9f7041 View commit details
    Browse the repository at this point in the history
  3. [pigeon][reland]enable treat warnings as errors for swift code in uni…

    …t test (#3901)
    
    `as [Any?]` here is actually not a "cast", but a "type annotation". An equivalent fix can be: 
    
    ```
    let arg: [Any?] = [nil]
    let inputEncoded = binaryMessenger.codec.encode(arg)
    ```
    
    Fixes
    ```
    heterogeneous collection literal could only be inferred to '[Any?]'; add explicit type annotation if this is intentional
    ```
    
    Which was introduced in #3889 and later got reverted. 
    
    See flutter/flutter#126006 for more details about some interesting research on this warning. 
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
    Fixes flutter/flutter#126006
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    hellohuanlin authored May 4, 2023
    Configuration menu
    Copy the full SHA
    6bd59cd View commit details
    Browse the repository at this point in the history
Loading