Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0744fe6
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d74d687
Choose a head ref
  • 5 commits
  • 72 files changed
  • 2 contributors

Commits on Jan 11, 2024

  1. Roll Flutter from b840a60 to 9f2e681 (24 revisions) (#5871)

    flutter/flutter@b840a60...9f2e681
    
    2024-01-11 [email protected] [Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (flutter/flutter#140976)
    2024-01-11 [email protected] Roll Packages from 378e700 to 0744fe6 (6 revisions) (flutter/flutter#141378)
    2024-01-11 [email protected] Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (flutter/flutter#141359)
    2024-01-11 [email protected] Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (flutter/flutter#141356)
    2024-01-11 [email protected] Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (flutter/flutter#141337)
    2024-01-11 [email protected] Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (flutter/flutter#141327)
    2024-01-11 [email protected] Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (flutter/flutter#141322)
    2024-01-11 [email protected] Add dart fix support to flutter_driver (flutter/flutter#141300)
    2024-01-11 [email protected] Fix a leak. (flutter/flutter#141312)
    2024-01-10 [email protected] Add covariants to reduce subclass casts in 2D APIs (flutter/flutter#141318)
    2024-01-10 [email protected] Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (flutter/flutter#141316)
    2024-01-10 [email protected] Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (flutter/flutter#141313)
    2024-01-10 [email protected] Call onPopInvoked when pages API is used (flutter/flutter#141221)
    2024-01-10 [email protected] Fix mechanism to pass flag for leak tracking. (flutter/flutter#141226)
    2024-01-10 [email protected] Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (flutter/flutter#141308)
    2024-01-10 [email protected] Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (flutter/flutter#141302)
    2024-01-10 [email protected] Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (flutter/flutter#141297)
    2024-01-10 [email protected] Improve testing for leak tracking. (flutter/flutter#140553)
    2024-01-10 [email protected] Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (flutter/flutter#141291)
    2024-01-10 [email protected] [flutter_tools] fix flutter create -t skeleton (flutter/flutter#141233)
    2024-01-10 [email protected] Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (flutter/flutter#141285)
    2024-01-10 [email protected] Unpin package:vm_service (flutter/flutter#141279)
    2024-01-10 [email protected] Collapse pubspec.lock by default (flutter/flutter#141282)
    2024-01-10 [email protected] Roll Packages from 09205ca to 378e700 (2 revisions) (flutter/flutter#141275)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d2321c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fd5fb9 View commit details
    Browse the repository at this point in the history
  3. [video_player] Skip flaky tests in certain circumstances on Android (#…

    …5872)
    
    Temporary workaround for flutter/flutter#141145
    
    This doesn't fully skip the test because this problem doesn't happen in CI device tests or locally, so rather than totally lose coverage this detects the very specific markers of this flake and skips only when that happens. This should allow the tree to stop being so red with the minimal coverage loss while we investigate this further.
    
    Part of flutter/flutter#141145
    stuartmorgan-g authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b61735b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. [various] Add iOS privacy manifests (#5846)

    Adds privacy manifests to all iOS plugins.
    
    While we only *need* to do the plugins listed [here](https://developer.apple.com/support/third-party-SDK-requirements/) for now, the wording of the page:
    > The following are commonly used SDKs in apps on the App Store
    
    suggests that the list of things for which this is required is just an arbitrary cutoff rather than a conceptual distinction, so it seems safest to just assume the list will grow over time and do all of them. To ensure that, this includes new repo tooling to check that a manifest is specified in the podspec.
    
    The large caveat is that we do not currently know if this actually works. This is the method of inclusion that seems to be [the consensus among people using Cocoapods](CocoaPods/CocoaPods#10325), as bundling it directly as a `resource` causes problems for clients who do not use `use_frameworks`. (In theory it seems like a manifest would not actually be *required* in that case since there is no framework, but it has the potential to actually stomp top-level resources.) Hopefully the automated analysis that Apple will eventually roll out will tolerate the file being bundled in a resource bundle in the framework rather than a top-level manifest file. If not, however, it's not clear how Cocoapods can be supported, so we can adopt this common approach for now under the assumption that eventually tooling will adapt to the reality of the ecosystem, and revisit the exact bundling later if necessary.
    
    Only `shared_preferences` has a non-empty manifest, as it is our only plugin that uses a required reason API, and none of our plugins themselves collect private data. Ideally for that plugin we would instead use `C56D.1`, which is for wrappers, but as currently written we can't use it since it's exclusively a wrapper. If that changes in the future based on our pending request, we can revisit. For now, however, this reason should suffice since we don't currently allow reading from other app groups.
    
    Fixes flutter/flutter#131495
    Fixes flutter/flutter#139756
    Fixes flutter/flutter#139757
    Fixes flutter/flutter#139758
    Fixes flutter/flutter#139759
    Fixes flutter/flutter#139760
    See also flutter/flutter#139761
    stuartmorgan-g authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c5349bc View commit details
    Browse the repository at this point in the history
  2. [ci] Check repo-level package metadata (#5811)

    Adds a new tool command (and runs it in CI) to check that each package:
    - is listed correctly in the repo-level README.md table
    - has a CODEOWNERS entry
    
    In the future we could add other things (e.g., auto-label), but these were the main things we've had issues with recently.
    
    Updates README.md and CODEOWNERS to fix failures it found:
    - Adds a couple of missing CODEOWNERS
    - Expands the web implementation CODEOWNERS to individual packages so that we don't have to special-case handling in the tool
    - Fixes some minor mistakes in README.md
    - URL-encodes all `:`s in the README.md links (which is why ever line shows as changed); it worked without that in practice, but it should really be encoded, and having it consistently encoded made things easier for the tooling.
    stuartmorgan-g authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d74d687 View commit details
    Browse the repository at this point in the history
Loading