Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f1fc965e1bd1
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 41211cf4c9a8
Choose a head ref
  • 3 commits
  • 16 files changed
  • 3 contributors

Commits on Apr 22, 2025

  1. [go_router] Add missing caseSensitive parameter to `GoRouteData.$ro… 

    …ute` (#9126)

Part of flutter/flutter#167277

I missed this parameter in #9096. This PR adds it. After that, I'll be able to make a PR for go_router_builder

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @ValentinVignal
    ValentinVignal authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    909f062 View commit details
    Browse the repository at this point in the history

  2. [video_player_web] Fix blank first frame on iOS. (#9025) 

    Fixes [First Frame of Video Once VideoPlayer Controller doesn't show in iOS Safari/Chrome](flutter/flutter#139107)

This PR fixes the blank first frame issue by adding a `_videoElement.load()` call at the end of the `initialize` function. This call forces the browser to load media in preparation for playback (https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/load).

Additionally, this PR removes `loadedmetadata` event listener, as the `canplay` event is now reliably emitted across all platforms. Keeping `loadedmetadata` listener could result in marking the video controller as initialized before the first frame is actually rendered. This causes the loader to disappear too early, leaving a blank space where the video should be until the browser displays the first frame. Relying on `canplay` ensures the first frame is ready before we proceed.

> [!NOTE]
> It turns out that this issue is iOS-specific and was reported not only in Flutter, but in some other packages and tools:
> 1) [video-react/First frame not shown as the poster on iOS Safari](video-react/video-react#328)
> 2) [WordPress/gutenberg/Video Block: First frame not shown as the poster on iOS Safari — Fix: Use Fragment URL](WordPress/gutenberg#51995)

> [!TIP]
> As a temporary workaround until this PR is merged, users can append the `#t=0.001` fragment to the asset or URL `src` to force the browser to load the first frame (e.g., `assets/butterfly.mp4#t=0.001`, `https://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4#t=0.001`).

The following repository was used for issue reproduction and testing: https://github.com/ksokolovskyi/video_player_blank_frame_bug

| Before | After |
| :---: | :---: |
| https://video-player-blank-frame-bug.web.app | https://video-player-blank-frame-fix.web.app |
| <video src="https://github.com/user-attachments/assets/4077fcc4-10cf-4dbd-8c59-2fd824b4e4c4" /> | <video src="https://github.com/user-attachments/assets/2951af36-1569-4a5c-90dd-1d52a5d1e7f2" /> |

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @ksokolovskyi
    ksokolovskyi authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    6ce3776 View commit details
    Browse the repository at this point in the history

  3. [gis_web] Make maybeEnum more robust in google_identity_services_web … 

    …shared file. (#8999)

When the needle value is unexpected, instead of throwing error, it'll return null now.

Fixes flutter/flutter#166548

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @vikdubey
    vikdubey authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    41211cf View commit details
    Browse the repository at this point in the history
Loading