Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f1a3da2a9f28
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 67401e169e5c
Choose a head ref
  • 4 commits
  • 28 files changed
  • 3 contributors

Commits on Oct 10, 2024

  1. [interactive_media_ads] Fixes bug where Android would show the last f… 

    …rame of the previous Ad before playing the current one (#7835)

It seems that [VideoView](https://developer.android.com/reference/android/widget/VideoView) continues to show the last frame of the previous video until the new video starts playing. This causes the `VideoView` to momentarily show the last frame while the new video was being prepared. It looks like neither `videoView.setUri(null)` or `videoView.stopPlayback` would reset the state. 

The simplest solution I could find would be to create a new `VideoView` whenever an Ad stops playing.

Related links:

google/ExoPlayer#1942
https://stackoverflow.com/questions/25660994/clear-video-frame-from-surfaceview-on-video-complete
    @bparrishMines
    bparrishMines authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    791c6e3 View commit details
    Browse the repository at this point in the history

  2. [webview]: Bump androidx.webkit:webkit from 1.12.0 to 1.12.1 in /pack… 

    …ages/webview_flutter/webview_flutter_android/android (#7801)

Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.webkit:webkit&package-manager=gradle&previous-version=1.12.0&new-version=1.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
    @dependabot
    dependabot[bot] authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f0bb953 View commit details
    Browse the repository at this point in the history

  3. [webview_flutter] Updates minimum supported webview_flutter_android… 

    … from 3.16.0 to 4.0.0 (#7844)

`webview_flutter_android` now requires API 21+ from #7801. This bumps the `webview_flutter_android` version and updates the readme in the app-facing package.
    @bparrishMines
    bparrishMines authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cf14901 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter from 2d45fb3 to 6790525 (7 revisions) (#7843) 

    flutter/flutter@2d45fb3...6790525

2024-10-10 [email protected] Roll Packages from 9d00fb1 to f1a3da2 (5 revisions) (flutter/flutter#156538)
2024-10-10 [email protected] Update Android plugin templates for newer AGP (flutter/flutter#156533)
2024-10-10 [email protected] Flutter templates example app Gradle memory settings (flutter/flutter#156201)
2024-10-10 [email protected] Roll Flutter Engine from 3a95d6e1ddbf to 590babc1581b (1 revision) (flutter/flutter#156498)
2024-10-10 [email protected] [canvaskit] Unskip cupertino datepicker tests (flutter/flutter#156499)
2024-10-10 [email protected] Add test for animated list example (flutter/flutter#156452)
2024-10-09 [email protected] Roll Flutter Engine from fb0b59d9438b to 3a95d6e1ddbf (1 revision) (flutter/flutter#156492)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    67401e1 View commit details
    Browse the repository at this point in the history
Loading