Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d8d9e97d2d02
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a1ed23c8f760
Choose a head ref
  • 9 commits
  • 52 files changed
  • 9 contributors

Commits on Oct 10, 2026

  1. [cupertino_ui] Fix CupertinoPicker throwing when disposed during the …

    …tap-to-select animation (#13012)
    
    Tapping an item that isn't centred starts a 300 ms tap-to-select animation, which `_CupertinoPickerState._handleChildTap` awaits and then reads `_effectiveController.selectedItem`. If the picker is disposed before that animation finishes, the controller has already been detached, so the read fails: an assertion in debug (`FixedExtentScrollController.selectedItem cannot be accessed before a scroll view is built with it.`) and `StateError: Bad state: No element` in release.
    
    It shows up in ordinary "select, then hide" patterns — a parent that removes the picker as soon as a value changes, or a Material bottom sheet (200 ms exit) popped right after a tap. The reporter's analysis in the issue pinned it to this exact line and supplied a deterministic reproduction; credit to them.
    
    The fix returns early after the `await` when the state is no longer mounted. Nothing after that point matters for a disposed picker — it only restores haptic bookkeeping.
    
    The new test taps an off-centre item, removes the picker 50 ms into the animation, and pumps past the end. It fails on `main` with the assertion above and passes with the fix. The rest of `picker_test.dart` (28) and `date_picker_test.dart` (85), which covers the pickers built on top of `CupertinoPicker`, pass as well.
    
    Fixes flutter/flutter#192135
    
    ## Pre-Review Checklist
    
    I used AI tooling while working on this, and reviewed and tested all of it myself.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    theprantadutta authored Oct 10, 2026
    Configuration menu
    Copy the full SHA
    8a74ca8 View commit details
    Browse the repository at this point in the history
  2. [material_ui] Add more 0x0 size tests part 14 (#13107)

    This is my attempt to handle flutter/flutter#6537 for the following widgets:
    ButtonBar
    MaterialButton
    RawMaterialButton
    FilterChip
    MergeableMaterial
    ahmedsameha1 authored Oct 10, 2026
    Configuration menu
    Copy the full SHA
    3744219 View commit details
    Browse the repository at this point in the history
  3. [material_ui] Ensure textScaler is taken into account for SnackBar ac…

    …tion overflow (#12737)
    
    Port of flutter/flutter#181959 to `flutter/packages` as part of the Material decoupling effort (flutter/flutter#188444).
    
    Ensure textScalling is taken into account for Sizing overflow.
    
    Fixes flutter/flutter#192232
    Fixes flutter/flutter#181959
    Part of flutter/flutter#188444
    
    ### Description
    - Ensure textScalling is taken into account for Sizing overflow: passes `MediaQuery.textScalerOf(context)` to `actionTextPainter` so that `actionAndIconWidth` properly scales with accessibility text scaling.
    - Removes `SizedBox(width: snackBarWidth * 0.4)` when the action overflows, eliminating unintended blank space on the right of multi-line content.
    - Adds unit tests in `snack_bar_test.dart` verifying `textScaler` overflow calculation and layout.
    - Adds pending changelog entry.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    matasb-google authored Oct 10, 2026
    Configuration menu
    Copy the full SHA
    b3d80fe View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2026

  1. [camera_platform_interface] Add zero-shutter-lag API (#12996)

    Platform interface portion of #12374, split out per the [federated plugin process](https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins) now that the combined PR is approved. No changes from what was reviewed there.
    
    Adds two methods to `CameraPlatform`, with `false` / no-op defaults:
    
    ```dart
    Future<bool> isZeroShutterLagSupported(int cameraId);
    Future<void> setZeroShutterLagEnabled(int cameraId, bool enabled);
    ```
    
    Part of flutter/flutter#190598
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    toyaji authored Oct 11, 2026
    Configuration menu
    Copy the full SHA
    3b733d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2026

  1. [vector_graphics_compiler] Support SVG alpha masks (mask-type="alpha") (

    #13025)
    
    [vector_graphics_compiler] Support SVG alpha masks (`mask-type="alpha"`)
    
    Fixes flutter/flutter#158734
    
    This PR adds support for SVG alpha masks (`mask-type="alpha"` and `style="mask-type: alpha"`) in `vector_graphics_compiler`, split out from #11909 per review feedback.
    
    ### Summary of Changes
    * **SVG Parser & AST (`vector_graphics_compiler`)**:
      * Parses the `mask-type` attribute (and inline `style="mask-type: ..."` property) on `<mask>` elements in `SvgParser`.
      * Propagates `isAlphaMask` through `ResolvedMaskNode` and `MaskNode`.
      * Emits `BlendMode.dstIn` for alpha masks instead of `BlendMode.srcIn` with a luminance-to-alpha color filter matrix (`BlendMode.modulate`).
    * **MaskingOptimizer Compatibility**:
      * Updates `MaskingOptimizer` so single-path masks using gradients with translucent stops (`stop-opacity < 1.0`) are preserved rather than replaced with solid geometry intersection (which previously discarded the gradient's alpha channel).
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    
    TAG=agy
    CONV=1bad96cc-81aa-438f-98f6-cb909289144a
    edwin-hollen authored Oct 12, 2026
    Configuration menu
    Copy the full SHA
    c63648d View commit details
    Browse the repository at this point in the history
  2. [google_sign_in] Convert unit tests to Kotlin (#13000)

    Converts `google_sign_in_android` native unit tests from Java to Kotlin.
    
    Similar to my other conversions, the process was:
    - Use the Android Studio deterministic auto-conversion.
    - Do a bunch of manual cleanup, as separate commits by topic.
      - This included adopting `mockito-kotlin` to make the mocking much less verbose and complex
    - Do a local Gemini review for where the code could be improved as Kotlin code, and address most of that feedback.
    
    This also removes the test-only bridge code that allowed using `Result` in Java tests, now that it is no longer necessary.
    
    Does not include any changes to production code.
    
    Part of flutter/flutter#188630
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Oct 12, 2026
    Configuration menu
    Copy the full SHA
    01d0873 View commit details
    Browse the repository at this point in the history
  3. [in_app_purchase_storekit] Remove availability checks below the packa…

    …ge minimum iOS 13 and macOS 10.15 (#13217)
    
    iOS 13 and macOS 10.15 are always available:
    https://github.com/flutter/packages/blob/01d08731727c8dfcd9519cdbf376aa40499dc8f7/packages/in_app_purchase/in_app_purchase_storekit/darwin/in_app_purchase_storekit/Package.swift#L13-L14
    
    Remove old availability checks.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    jmagman authored Oct 12, 2026
    Configuration menu
    Copy the full SHA
    d7ebbe2 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2026

  1. [material_ui] Clarify Slider labels for continuous sliders (#13121)

    Clarifies that `Slider.label` can be displayed for continuous sliders when the value indicator configuration allows it. Documents the discrete-slider default, widget-level settings for continuous sliders, and the fallback to `SliderThemeData.showValueIndicator`.
    
    Fixes flutter/flutter#74098.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    molchanovia authored Oct 13, 2026
    Configuration menu
    Copy the full SHA
    a1ed23c View commit details
    Browse the repository at this point in the history
Loading