Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d5ec6dbaf1c6
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5620e6543317
Choose a head ref
  • 13 commits
  • 273 files changed
  • 10 contributors

Commits on Oct 1, 2026

  1. [tool] Add more documentation (#13063)

    Adds a CONTRIBUTING.md to provide an overview of the tool's philosophy and structure.
    
    Also updates the README to fix some obsolete information, and add documentation for more commands.
    stuartmorgan-g authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    249ddc0 View commit details
    Browse the repository at this point in the history
  2. [pigeon] pin native interop related dev deps and update some docs (#1…

    …3103)
    
    related to dart-lang/native#3723
    
    pins dev deps to avoid unexpected underlying changes to generated code or it's effects
    tarrinneal authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    ea212a2 View commit details
    Browse the repository at this point in the history
  3. [various] Update Robolectric to 4.17 (#13041)

    Updates test dependencies to Robolectric 4.17.
    
    Added a bunch of flags because JDK 17+ blocks reflective access to JDK internals by default. Starting with 4.17, Robolectric's test environment setup reflects into jdk.internal.access, so these are required. This is the flag set
    recommended by Robolectric, see https://robolectric.org/getting-started/#running-with-java-17-and-higher.
    
    Partially Addresses flutter/flutter#193404
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    jesswrd authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    6d17b57 View commit details
    Browse the repository at this point in the history
  4. [material_ui] Migrate AppBar, SliverAppBar, BottomAppBar, and Scaffol…

    …d API doc snippets to {@example} (batch 7) (#13023)
    
    This PR addresses batch 7 of the migration detailed in flutter/flutter#188530 (comment).
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    dkwingsmt authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    4bc7212 View commit details
    Browse the repository at this point in the history
  5. [material_ui] Migrate MaterialApp API doc snippets to {@example} and …

    …add unit tests (batch 6) (#13021)
    
    This PR addresses batch 6 of the migration detailed in flutter/flutter#188530 (comment).
    
    `app.snippet.4.dart‎` contains some non-trivial changes to fix a type error and to make it testable.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    dkwingsmt authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    029be53 View commit details
    Browse the repository at this point in the history
  6. [material_ui] Update Material tokens to Material version 38.2.83 (#13082

    )
    
    Import of Material tokens from g3. 
    
    Includes:
    *  the fixed motion token references (see cl/991042750,  cl/991104219, and cl/991045693)
    * the removed variable types (see cl/967926782)
    
    ## Pre-Review Checklist
    
    - No tests - this is purely generated code imported from g3.
    - No issue - this is purely generated code imported from g3. 
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    elliette authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    8dd3f95 View commit details
    Browse the repository at this point in the history
  7. [webview_flutter] Add gesture blocking policy to WebKitWebViewWidgetC…

    …reationParams (#12496)
    
    Adds `WebKitWebViewWidgetCreationParams.uiKitGestureBlockingPolicy`, forwarded to `UiKitView.gestureBlockingPolicy`, so apps can opt in to an iOS gesture-blocking workaround when a web view becomes unresponsive to touches.
    
    The default remains `UiKitViewGestureBlockingPolicy.fallbackToPluginDefault`, preserving existing behavior. The parameter has no effect on macOS. The `uiKit` prefix makes the platform scope explicit and leaves room for a separate macOS policy. Native plugin registration is unchanged.
    
    ### Why the minimum Flutter version is bumped
    
    `UiKitView.gestureBlockingPolicy` landed in flutter/flutter#185126 and first shipped in stable **3.47.0** (it is not present in 3.44.x), so `flutter: ">=3.47.0"` is required to reference it at all. `validate` enforces a matching Dart lower bound, hence `sdk: ^3.13.0`, and that made this a minor version bump (`3.27.0`) rather than a patch.
    
    Raising the package's language version to Dart 3.13 changes `dart format` output for files that were already checked in. That reformat is isolated in the original formatting commit. Current `main` already includes the Flutter 3.47.0 SDK mapping, so this PR no longer changes `script/tool`.
    
    ### Behavior and validation
    
    `doNotBlockGesture` uses hit-test results to decide when to block the web view's gesture recognizers, without relying on Flutter's gesture arena. It remains an opt-in workaround that may allow gestures that should have been blocked. A widget test verifies that opting in still builds an `AppKitView` on macOS.
    
    Local validation on Flutter 3.47.2 / Dart 3.13.2: all 158 package tests pass, including 7 widget tests; static analysis, repository formatting, README excerpt synchronization, package validation and license checks pass.
    
    ### Before / after
    
    Both recorded on the same build against the same third-party cashier page, iOS 26.4 simulator (iPhone 17 Pro). `uiKitGestureBlockingPolicy` is the only difference between the two runs.
    
    **Before** — `fallbackToPluginDefault`, i.e. the `eager` policy the plugin registers the platform view with. The first touch is delivered; after that the web view is dead: taps do nothing and drags never move `window.scrollY`.
    
    https://github.com/user-attachments/assets/481d69d4-ba43-49fe-99dc-8534b79f67e3
    
    **After** — `uiKitGestureBlockingPolicy: UiKitViewGestureBlockingPolicy.doNotBlockGesture`. Scrolling and tapping keep working for the rest of the session.
    
    https://github.com/user-attachments/assets/01e7516c-4b53-4b11-98ee-8bd1b7119c4a
    
    ### Minimal repro
    
    Still owed. I built a standalone project that mirrors the page shape which triggers it for us — a form taller than the viewport embedding four cross-origin iframes — and it does **not** reproduce, so the trigger is narrower than page geometry alone. The page that does trigger it reliably is a closed-source payment cashier I cannot share. I will keep reducing it.
    
    One data point in the meantime: `flutter_inappwebview` also registers its iOS platform view via the two-argument `registrar.register(_:withId:)` (so, `eager`), and shows the same symptom on iOS 26 on the same page — which suggests the underlying issue is not specific to `webview_flutter`.
    
    Related: flutter/flutter#175099, flutter/flutter#179907
    Fixes flutter/flutter#191267
    
    ## Pre-Review Checklist
    burakJs authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    d8b4304 View commit details
    Browse the repository at this point in the history
  8. Manual roll Flutter from d649d2bfebfe to e89fd0a274ae (27 revisions) (#…

    …13104)
    
    Manual roll requested by [email protected]
    
    flutter/flutter@d649d2b...e89fd0a
    
    2026-10-01 [email protected] Manual roll ICU from 6ebb40c59477 to 5aa526207171 (2 revisions) (flutter/flutter#193661)
    2026-10-01 [email protected] fix(web): hash source maps before rewriting sourceMappingURL with --web-content-hash (flutter/flutter#193614)
    2026-10-01 [email protected] [flutter_tools] Bootstrap DeviceManager in ToolDependencies (flutter/flutter#193524)
    2026-10-01 [email protected] [wasm] Set flutter_runtime_mode in tools/gn to_gn_wasm_args (flutter/flutter#193407)
    2026-10-01 [email protected] Remove remaining `download_jdk` references (flutter/flutter#193562)
    2026-10-01 [email protected] Synchronize dart2wasm feature probes in roll script and flutter_bootstrap.js (flutter/flutter#193271)
    2026-10-01 [email protected] [web] Unskip web tests that now pass in gestures, services, and widgets (flutter/flutter#193512)
    2026-10-01 [email protected] Roll Fuchsia Test Scripts from whZAV1mfT-Rdc0rQ8... to fCNknap4ZI0AMcvIf... (flutter/flutter#193640)
    2026-10-01 [email protected] Roll Skia from 0575a37d0619 to f2d68e0b8863 (2 revisions) (flutter/flutter#193621)
    2026-10-01 [email protected] perf(widgets): use const <Never>{} in InheritedModelElement and avoid redundant casts in RenderObjectElement.update (flutter/flutter#192913)
    2026-10-01 [email protected] [web] Unskip and strengthen missing glyph tofu test on Wimp (flutter/flutter#193426)
    2026-10-01 [email protected] [flutter_tools] Fix `flutter drive -d chrome` hanging on web (flutter/flutter#193459)
    2026-10-01 [email protected] [web] Fix hang when Chromium cannot bind remote debugging port (flutter/flutter#193461)
    2026-10-01 [email protected] [flutter_tools] Bundle data assets from hooks in flutter test (flutter/flutter#193435)
    2026-10-01 [email protected] Roll Packages from 0ba9a82 to d5ec6db (11 revisions) (flutter/flutter#193641)
    2026-10-01 [email protected] Revert: [flutter_tools] Fix DTD "Stream already subscribed" error and wait for analysis over DTD in widget preview (flutter/flutter#193637)
    2026-10-01 [email protected] Roll Skia from 6182a3cf8f98 to 0575a37d0619 (5 revisions) (flutter/flutter#193613)
    2026-10-01 [email protected] [flutter_tools] Fix DTD "Stream already subscribed" error and wait for analysis over DTD in widget preview (flutter/flutter#192930)
    2026-09-30 [email protected] [Impeller] Sample the render target rect in offscreen advanced blends (flutter/flutter#192988)
    2026-09-30 [email protected] Roll Skia from 01524014dff5 to 6182a3cf8f98 (11 revisions) (flutter/flutter#193594)
    2026-09-30 [email protected] [web] Use Xvfb -displayfd and clean up Xvfb after Firefox test suites (flutter/flutter#193510)
    2026-09-30 [email protected] Fixes bug where sibling node fail to update size (flutter/flutter#191220)
    2026-09-30 [email protected] Roll Skia from c7b323126bf0 to 01524014dff5 (3 revisions) (flutter/flutter#193577)
    2026-09-30 [email protected] Remove some Undefined Behavior from run_customer_testing_tests.dart. (flutter/flutter#193582)
    2026-09-30 [email protected] Fix pointer id/coordinate mismatch in Android platform view multi-touch (flutter/flutter#191631)
    2026-09-30 [email protected] Roll Packages from 3c6ce59 to 0ba9a82 (11 revisions) (flutter/flutter#193578)
    2026-09-30 [email protected] Fix unresolved doc comment references in dev/ tooling (flutter/flutter#193501)
    
    If this roll has caused a breakage, revert this CL and set the roller
    to dry run mode using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    a9e07e2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8a0f9fe View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bd7b7b5 View commit details
    Browse the repository at this point in the history
  11. [tool] Use flutter pub for packages that depend on jni (#13087)

    Updates `pub_utils.dart` to use `flutter pub` instead of `dart pub` when a non-Flutter package (or its example) depends on `jni` in `dependencies` or `dev_dependencies`.
    
    `package:jni` declares a `flutter` constraint in its `pubspec.yaml` `environment` section, which causes `dart pub` (including `dart pub publish`) to fail version solving when `FLUTTER_ROOT` is not set in the environment—even for non-Flutter Dart packages like `pigeon` that only depend on `jni` in `dev_dependencies` and run unit tests with `dart test`. Scoping this check to `pub_utils.dart` ensures `pub` commands use `flutter pub` while `dart-test` continues to use `dart run test`.
    
    If more packages run across this problem, they will need to be added to the list to force the `flutter pub` command.
    
    Fixes flutter/flutter#192709
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    tarrinneal authored Oct 1, 2026
    Configuration menu
    Copy the full SHA
    83da6fb View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2026

  1. [material_ui] Repaint NavigationIndicator when the selection changes …

    …without pointer input (#13010)
    
    Port of flutter/flutter#187802 to `material_ui`, following the process in flutter/flutter#188444. The original PR was approved by dkwingsmt and QuncCccccc but couldn't land because of the Material/Cupertino code freeze.
    
    `NavigationIndicator` draws its indicator with an `Ink`, which paints on the nearest ancestor `Material` rather than locally. When the indicator animates without an accompanying pointer interaction — for example when `selectedIndex` is changed programmatically — nothing tells that `Material` to repaint, so it keeps showing the indicator's previous frame. The fix calls `Material.of(context).markNeedsPaint()` on each animation tick.
    
    The regression test pumps a `NavigationDrawer`, changes `selectedIndex` from outside without any pointer events, and verifies the indicator repaints. I checked it fails with the one-line fix removed and passes with it, in its new location under `packages/material_ui/test/`.
    
    The two original commits were cherry-picked without merge commits, as the porting guide describes; rename detection placed them at `lib/src/navigation_bar.dart` and `test/navigation_drawer_test.dart` with no conflicts. The only new commit adds the pending changelog entry (`version: patch`).
    
    Fixes flutter/flutter#180359
    
    ## Pre-Review Checklist
    
    I used AI tooling while working on this, and reviewed and tested all of it myself.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    theprantadutta authored Oct 2, 2026
    Configuration menu
    Copy the full SHA
    499f859 View commit details
    Browse the repository at this point in the history
  2. [material_ui] Migrate M3 Menu template to use new gen_defaults (#13057)

    Work toward flutter/flutter#187899.
    Fixes flutter/flutter#188421.
    
    This PR migrates the M3 Menu defaults template to use the new gen_defaults in material_ui.
    The generated defaults remain unchanged.
    
    ## Pre-Review Checklist
    QuncCccccc authored Oct 2, 2026
    Configuration menu
    Copy the full SHA
    5620e65 View commit details
    Browse the repository at this point in the history
Loading