Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d041934b296d
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6b70804799a9
Choose a head ref
  • 7 commits
  • 78 files changed
  • 2 contributors

Commits on Jun 23, 2023

  1. [file_selector] Add file group to save return value - implementations (… 

    …#4273)

Implementation package portion of #4222

Part of flutter/flutter#107093
    @stuartmorgan-g
    stuartmorgan-g authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6d8782d View commit details
    Browse the repository at this point in the history

  2. [go_router] Adds onException to GoRouter constructor. (#4216) 

    fixes flutter/flutter#108144
    @chunhtai
    chunhtai authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    08425c5 View commit details
    Browse the repository at this point in the history

  3. [file_selector] Add file group to save return value (#4222) 

    This deprecates `getSavePath`, which returned a target path string, in favor of a new `getSaveLocation`, which returns an object containing both a path and, optionally, a selected file group. This allows clients to use the selected group when deciding what path to use when saving (see discussion in linked issue).

This includes an implementation for Windows. It will also apply to Linux, and I've verified that the structure works, but it's not included here because it requires some non-trivial refactoring in the Linux implementation (we can't get the current index, only the current filter object pointer, which means we need to pass more data around between the various functions to map back to an index... and it's GObject so making internal data utility classes is fiddly.) For now Linux just always returns a null group, and we can add it later.

Most of flutter/flutter#107093
    @stuartmorgan-g
    stuartmorgan-g authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    25e1d87 View commit details
    Browse the repository at this point in the history

  4. [ci] Switch to LUCI for Android build-all (#4274) 

    Enables the new LUCI version of the Android build-all-packages test, and removes the Cirrus version.

Part of flutter/flutter#114373
    @stuartmorgan-g
    stuartmorgan-g authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8b6998f View commit details
    Browse the repository at this point in the history

  5. [tool] Consider comment-only changes to be dev-only (#4279) 

    Updates the state checker to inspect changed Dart files to see if the only changes are implementation (not documentation) comment lines. In particular, this will fix the problem of CI flagging changes that do nothing but add `// ignore:` comments (for federated package changes involving deprecation, framework changes that require temporary ignores in packages to support stable, etc.) as needing version and changelog changes
    @stuartmorgan-g
    stuartmorgan-g authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    48232e8 View commit details
    Browse the repository at this point in the history

  6. [image_picker] Update to 1.0 (#4285) 

    The plugin now covers all of our supported platforms, most highly-requested features have been addressed, and the API has been stable for quite some time (in that no breaking changes have been required). Given that, a 1.0 version number reflects the current state of the package than a 0.x version.

As part of the breaking change, the `get*` methods that were deprecated several years ago have now been removed.
    @stuartmorgan-g
    stuartmorgan-g authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f55d455 View commit details
    Browse the repository at this point in the history

  7. [go_router] Reduces excessive rebuilds due to inherited look up. (#4227) 

    fixes flutter/flutter#123570
    @chunhtai
    chunhtai authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6b70804 View commit details
    Browse the repository at this point in the history
Loading