Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cdae854a59b9
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a03b900efc0e
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Jul 3, 2023

  1. [webview_flutter_wkwebview] Fixes inspectable compile-time error and … 

    …crash from equal `NSURL`s (#4340)

Fixes flutter/flutter#128422 by using pointer equality in the `NSMapTable`. From my understanding and testing it seems that the default mode for [NSMapTable](https://developer.apple.com/documentation/foundation/nsmaptable?language=objc) is to copy objects that implement `NSCopyable`. The only class we wrap that does seems to implement `NSCopyable` is `NSURL` so this class eventually led to a race condition where adding an `NSURL` that was equivalent to an already added one would replace the original.

Note that we should probably now add an error when adding an already present instance. However, a clear method needs to be added to the `InstanceManager` first so that hot reload will continue working. This is the current solution on Android.

Fixes flutter/flutter#129587 by adding a compile-time check around the use of `WKWebView.inspectable`. Solution used from:

https://stackoverflow.com/questions/76216183/how-to-debug-wkwebview-in-ios-16-4-1-using-xcode-14-2
    @bparrishMines
    bparrishMines authored Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a03b900 View commit details
    Browse the repository at this point in the history
Loading