-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Comparing changes
Open a pull request
base repository: flutter/packages
base: c44c2282aad1
head repository: flutter/packages
compare: 01d3d5c1dca3
- 14 commits
- 93 files changed
- 8 contributors
Commits on Feb 26, 2025
-
[ci] Lengthen custom tests timeout (#8715)
This test has been at the edge of its time limit for a while, and is now consistently timing out. Longer term we should see if we can shorten the Pigeon test time (it accounts for about 20 minutes), but for now, increase the timeout so that it doesn't fail.
Configuration menu - View commit details
-
Copy full SHA for 6a918c4 - Browse repository at this point
Copy the full SHA 6a918c4View commit details -
[various] Remove plugin-level
integration_testdependencies (#8711)Many of our plugins have `dev_dependencies` on `integration_test` at the plugin level, for some reason. Integration tests run in the example app, not the plugin, so only the example app should need the dependency. In practice it shouldn't matter since it's a dev dependency, but it's best to be accurate about our requirements.
Configuration menu - View commit details
-
Copy full SHA for 5501c5e - Browse repository at this point
Copy the full SHA 5501c5eView commit details -
[url_launcher][web] Prevent browser from navigating when followLink i…
…sn't called (#8675) When a DOM click event is received, we need to make a decision before the end of the event loop whether to allow the browser to navigate or not. At the end of the event loop, the browser will perform the navigation if we don't prevent it. The problem occurs when the `followLink` signal arrives AFTER the event loop (this can happen in semantics mode when the web engine uses a debouncer to queue events and send them to the framework after some delay). This leads to a situation where we can't make a definitive decision by the end of the event loop, so this PR does the following: 1. [best case] If the `followLink` signal is received before the end of the event loop, we let the browser do the navigation for a full web link experience. 2. [meh case] If no `followLink` signal is received before the end of the event loop, we PREVENT the browser from navigating. But we keep waiting for the `followLink` signal. If the signal arrives a bit later, we fallback to a programmatic navigation through the `launchUrl` API. Fixes flutter/flutter#162927 Fixes flutter/flutter#162408
Configuration menu - View commit details
-
Copy full SHA for a2d2f16 - Browse repository at this point
Copy the full SHA a2d2f16View commit details -
[camera] Disable flaky tests (#8708)
Skips the `create does not call create on the Java side` tests due to excessive flake, while the issue is investigated. flutter/flutter#164132
Configuration menu - View commit details
-
Copy full SHA for 180494b - Browse repository at this point
Copy the full SHA 180494bView commit details -
[various] Bump androidx.test:core to 1.4.0 (#8710)
This is pulled out of #8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.
Configuration menu - View commit details
-
Copy full SHA for 8d28983 - Browse repository at this point
Copy the full SHA 8d28983View commit details -
[tool] Update targetsdk version to 35 from 32 (#8694)
part of #flutter/flutter/issues/14983 This is just a test usage but it came up in my search for older versions of android being used.
Configuration menu - View commit details
-
Copy full SHA for 804b3ca - Browse repository at this point
Copy the full SHA 804b3caView commit details -
[go_router] Secured empty matches in canPop (#8557)
If current configuration matches is empty, canPop throws exceptions instead of quit properly ``` StateError: Bad state: No element App 0x1086b3e80 List.last (growable_array.dart:349) App 0x108996274 GoRouterDelegate.canPop (delegate.dart:84) App 0x1089961bc GoRouter.canPop (router.dart:330) App 0x10899615c BuildContextExtension|get#_shouldPop (build_context_extensions.dart:40) ``` - if there are no elements, poping page throws an error
Configuration menu - View commit details
-
Copy full SHA for 6d191c5 - Browse repository at this point
Copy the full SHA 6d191c5View commit details -
[camera_android_camerax] Fix 90°-off preview rotation (#8629)
Fixes 90°-off preview rotation without locked capture orientation. Part of flutter/flutter#154241. The major changes in this PR: 1. Ensures the preview widget is rebuilt when a new device orientation is detected by changing the `buildPreview` to return a `StatefulWidget` instead of a `Texture` that wouldn't pick up changes in device orientation. 2. Uses [`handlesCropAndRotation`](https://api.flutter.dev/javadoc/io/flutter/view/TextureRegistry.SurfaceProducer.html#handlesCropAndRotation()) to detect if the preview is already correctly rotated or not. This API was added exactly for that purpose. 3. Corrects the preview when needed using https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation (also subtracts rotation applied in `CameraPreview` widget). See flutter/flutter#154241 (comment) for slightly more context if desired.
Configuration menu - View commit details
-
Copy full SHA for b13fb56 - Browse repository at this point
Copy the full SHA b13fb56View commit details -
[pigeon] Timestamp test steps in CI (#8716)
Pigeon's tests are taking a substantial amount of CI time, so it would be useful to be able to audit how long each step takes so we have more information if we need to shorten or shard these tests.
Configuration menu - View commit details
-
Copy full SHA for 576f42a - Browse repository at this point
Copy the full SHA 576f42aView commit details -
[go_router_builder]: Handle invaild params (#8405)
Fixed handling of invalid parameters Fix: flutter/flutter#160894 (comment)
Configuration menu - View commit details
-
Copy full SHA for 35b816f - Browse repository at this point
Copy the full SHA 35b816fView commit details -
[local_auth] Update to use flutter.targetSdkVersion (#8695)
part of flutter/flutter/issues/149836 After this pr `find . -type f -name "build.gradle" | xargs grep -e "targetSdk" | tr -d '=' | tr -s ' ' | grep -v flutter\.targetSdkVersion` will return no results.
Configuration menu - View commit details
-
Copy full SHA for 08f883b - Browse repository at this point
Copy the full SHA 08f883bView commit details -
Dependabot to update major and minor versions of test dependencies, i…
…gnore patch (#8712) #8710 (comment) Default to dependabot to ignore only patch versions for test dependencies and com.android.tools.build:gradle, and update major and minor. We can revert for any that get noisy. The minor/patch ignore has been around awhile: https://github.com/flutter/packages/pull/2832/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28R120-R121
Configuration menu - View commit details
-
Copy full SHA for a876ab3 - Browse repository at this point
Copy the full SHA a876ab3View commit details
Commits on Feb 27, 2025
-
Manual roll Flutter from 911aa75 to 043b719 (#8693)
#8692 with fixes for indirect effects of `--explicit-package-dependencies`
Configuration menu - View commit details
-
Copy full SHA for b5e8daa - Browse repository at this point
Copy the full SHA b5e8daaView commit details -
Manual roll Flutter from 043b719 to 1659206 (19 revisions) (#8728)
Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 01d3d5c - Browse repository at this point
Copy the full SHA 01d3d5cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c44c2282aad1...01d3d5c1dca3