Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ba80f8f0ff88
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cde5b36e7ece
Choose a head ref
  • 12 commits
  • 66 files changed
  • 7 contributors

Commits on Apr 28, 2026

  1. Configuration menu
    Copy the full SHA
    cb91e6d View commit details
    Browse the repository at this point in the history
  2. [vector_graphics] add imageBuilder property to VectorGraphic (#11094)

    related with flutter/flutter#182635
    
    Adding an `imageBuilder` property to `VectorGraphic` allows developers
    to wrap the successfully loaded vector graphic with decorations or
    interaction layers (e.g., borders, shadows, gesture detectors) only when
    the image is available. This completes the builder pattern alongside the
    existing `placeholderBuilder` and `errorBuilder`, giving full control
    over all three rendering states.
    
    ## Changes
    
    - Added `VectorGraphicsImageWidget` typedef
    - Added optional `imageBuilder` parameter to `VectorGraphic`
    constructors and `createCompatVectorGraphic`
    - Exported `VectorGraphicsImageWidget` from
    `vector_graphics_compat.dart`
    - Added two tests verifying `imageBuilder` is called on success and not
    during placeholder state
    - Bumped version to 1.1.20
    
    ## Test plan
    
    - [x] `imageBuilder wraps the loaded vector graphic` — verifies the
    builder is applied on successful load
    - [x] `imageBuilder is not called during placeholder state` — verifies
    the builder is skipped during loading
    - [x] All 60 existing tests pass
    suojae authored Apr 28, 2026
    Configuration menu
    Copy the full SHA
    ce623f5 View commit details
    Browse the repository at this point in the history
  3. [image_picker] Update documentation of maxDuration to reflect that it…

    … only applies to recording (#11417)
    
    Fixes flutter/flutter#83630
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    AbdeMohlbi authored Apr 28, 2026
    Configuration menu
    Copy the full SHA
    5fca300 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cf84667 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2026

  1. [various] Upgrade googletest to v1.15.2 (#11586)

    Running e.g. pigeon tests (`packages\pigeon\tool\test.dart`) with Visual Studio 2026 gives the following error:
    
    ```
    ##############################
    # Generating platform_test/ output [start time 22:58:25]
    Generation complete!
    ##############################
    # Running windows_unittests [start time 22:58:29]
    Building Windows application...                                 
    CMake Error at D:/Tmp/Coding/git/flutter/packages/packages/pigeon/platform_tests/test_plugin/example/build/windows/x64/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
      Compatibility with CMake < 3.5 has been removed from CMake.
    
      Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
      to tell CMake that the project requires at least <min> but has been updated
      to work with policies introduced by <max> or earlier.
    
      Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
    
    Building Windows application...                                     6,9s
    Unable to generate build files
    # Failed, exit code: 1
    
    Process finished with exit code 1
    ```
    
    So upgrading the google tools to v1.15.2 resolves that issue as since [1.12.1](https://github.com/google/googletest/releases/tag/release-1.12.1) the minimum required CMake version is 3.5.
    
    Towards flutter/flutter#185597
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Gustl22 authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    bf6d7db View commit details
    Browse the repository at this point in the history
  2. [file_selector] Update Windows example for deprecations (#11570)

    The `file_selector_windows` example was using some methods that have been deprecated in favor of param-object versions. This updates to use those new versions.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    4638659 View commit details
    Browse the repository at this point in the history
  3. Update git ignore for personal/iterating on agent skills and rules (#…

    …11600)
    
    Matches the same convention in flutter/flutter to allow folks to iterate and experiment with skills locally without showing up in git.
    
    - flutter/flutter#184727
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Piinks authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    2341d2e View commit details
    Browse the repository at this point in the history
  4. [video_player_platform_interface] Add video track selection support (#…

    …11474)
    
    ## Summary
    Platform interface breakout PR for #10688.
    
    - Adds `VideoTrack` class with metadata fields: `trackId`, `size` (width/height), and `bitrate`
    - Adds `getVideoTracks()` method to retrieve available video quality variants
    - Adds `selectVideoTrack()` method to switch between quality tracks
    - Adds `isVideoTrackSupportAvailable()` method to check platform support
    
    ## Dependency Chain
    This PR is **first** in a series of breakout PRs:
    1. `video_player_platform_interface` (this PR)
    2. `video_player_android` (pending)
    3. `video_player_avfoundation` (pending)
    4. `video_player` + `video_player_web` (pending - original PR #10688 updated)
    
    ## Test Plan
    nateshmbhat authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    cac0fc5 View commit details
    Browse the repository at this point in the history
  5. [pigeon] fix: Apply correct ThrowError success callback (#11585)

    Building in  Visual Studio 2026 gives the following error:
    
    ```
    error C2664: 'void core_tests_pigeontest::FlutterIntegrationCoreApi::ThrowError(std::function<void (const flutter::EncodableValue *)> &&,std::function<void (const core_tests_pigeontest::FlutterError &)> &&)': cannot convert argument 1 from 'test_plugin::TestPlugin::CallFlutterThrowError::<lambda_1>' to 'std::function<void (const flutter::EncodableValue *)> &&'
    ```
    
    This is likely due to https://stackoverflow.com/a/79894278/5164462 so the compiler does not allow unsuited call parameters.
    
    Towards flutter/flutter#185597
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Gustl22 authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    9b4847f View commit details
    Browse the repository at this point in the history
  6. [quick_actions] Switch to Kotlin Pigeon (#11507)

    Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
    - Adds Kotlin build setings to Gradle.
    - Updates API signatures for Kotlin/Java differences.
    - Adds generic Java/Kotlin compat shim to create Result objects from Java, since those haven't been added to the Pigeon generator yet.
    
    Part of flutter/flutter#158287
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    c05ab81 View commit details
    Browse the repository at this point in the history
  7. [image_picker] Switch to Kotlin Pigeon (#11504)

    Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
    - Adds Kotlin build setings to Gradle.
    - Updates API signatures for Kotlin/Java differences.
    - Adds generic Java/Kotlin compat shim to create Result objects from Java, since those haven't been added to the Pigeon generator yet.
    - Updates tests to use constructors instead of builders, since the Kotlin generator doesn't create builders.
    - Updates tests to use a Java/Kotlin compat shim to read Kotlin Result values, instead of mocking the Java Pigeon response object.
    
    Part of flutter/flutter#158287
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    5f14a80 View commit details
    Browse the repository at this point in the history
  8. [file_selector] Switch to Kotlin Pigeon (#11479)

    Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
    - Adds Kotlin build setings to Gradle.
    - Updates API signatures for Kotlin/Java differences.
    - Adds generic Java/Kotlin compat shim to create Result objects from Java, since those haven't been added to the Pigeon generator yet.
    - Updates tests to use constructors instead of builders, since the Kotlin generator doesn't create builders.
    - Updates tests to use a Java/Kotlin compat shim to read Kotlin Result values, instead of mocking the Java Pigeon response object.
    
    This does not attempt to fix the pre-existing invalid use of null paths described in flutter/flutter#159568, but the behavior does change slightly from an IllegalStateException (which came from the Java builder) to a NullPointerException (from trying to assign to a non-null Kotlin field).
    
    Part of flutter/flutter#158287
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    cde5b36 View commit details
    Browse the repository at this point in the history
Loading