Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 97f0a4049d0b
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e774e8887ce2
Choose a head ref
  • 4 commits
  • 8 files changed
  • 4 contributors

Commits on Nov 24, 2023

  1. Roll Flutter from 106667e to cf05f3c (10 revisions) (#5474)

    flutter/flutter@106667e...cf05f3c
    
    2023-11-24 [email protected] Roll Flutter Engine from 7e640faa6adf to b1e0bf62fa35 (1 revision) (flutter/flutter#138979)
    2023-11-24 [email protected] Roll Flutter Engine from d67ac2c561ca to 7e640faa6adf (2 revisions) (flutter/flutter#138969)
    2023-11-24 [email protected] Roll Flutter Engine from 152790b5811b to d67ac2c561ca (1 revision) (flutter/flutter#138965)
    2023-11-23 [email protected] Roll Flutter Engine from 4a344e050401 to 152790b5811b (1 revision) (flutter/flutter#138959)
    2023-11-23 [email protected] Roll Flutter Engine from 6e71c3642abf to 4a344e050401 (1 revision) (flutter/flutter#138958)
    2023-11-23 [email protected] Roll Flutter Engine from bec0dacaae41 to 6e71c3642abf (2 revisions) (flutter/flutter#138956)
    2023-11-23 [email protected] [flutter_tools] Fix bad state future already completed in flutter logs (flutter/flutter#138517)
    2023-11-23 [email protected] Fix SliverGrid garbage collection issue (flutter/flutter#138915)
    2023-11-23 [email protected] Roll Flutter Engine from f331e0afaf2e to bec0dacaae41 (6 revisions) (flutter/flutter#138954)
    2023-11-23 [email protected] Roll Packages from 2102327 to 6c5ad9e (1 revision) (flutter/flutter#138950)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    a20fc3a View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. [camerax] Adds proxy class for testing detached/mock objects and meth…

    …od calls (#5423)
    
    Creates `CameraXProxy` class used to test detached/mock objects and
    method calls in the plugin. Refactors plugin test to use the proxy.
    
    Part of flutter/flutter#125928; unblocks
    #5285 which requires testing a
    mixture of detached and mock objects.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [x] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style].
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    
    ---------
    
    Co-authored-by: Maurice Parrish <[email protected]>
    camsim99 and bparrishMines authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    41c7ab5 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter from cf05f3c to b5f163a (3 revisions) (#5477)

    flutter/flutter@cf05f3c...b5f163a
    
    2023-11-25 [email protected] Roll Flutter Engine from b50fc4ad6820 to 77432202f766 (1 revision) (flutter/flutter#138995)
    2023-11-24 [email protected] Roll Flutter Engine from b1e0bf62fa35 to b50fc4ad6820 (1 revision) (flutter/flutter#138990)
    2023-11-24 [email protected] Roll Packages from 6c5ad9e to 97f0a40 (1 revision) (flutter/flutter#138982)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8e55c02 View commit details
    Browse the repository at this point in the history
  3. Bump github/codeql-action from 2.22.5 to 2.22.8 (#5472)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.5 to 2.22.8.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
    <blockquote>
    <h1>CodeQL Action Changelog</h1>
    <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
    <h2>[UNRELEASED]</h2>
    <p>No user facing changes.</p>
    <h2>2.22.8 - 23 Nov 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
    </ul>
    <h2>2.22.7 - 16 Nov 2023</h2>
    <ul>
    <li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
    <ul>
    <li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
    <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
    </ul>
    </li>
    </ul>
    <h2>2.22.6 - 14 Nov 2023</h2>
    <ul>
    <li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
    <li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
    </ul>
    <h2>2.22.5 - 27 Oct 2023</h2>
    <p>No user facing changes.</p>
    <h2>2.22.4 - 20 Oct 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
    <li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
    <ul>
    <li>All code scanning workflows should continue to succeed regardless of the warning.</li>
    <li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
    <li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
    </ul>
    </li>
    </ul>
    <h2>2.22.3 - 13 Oct 2023</h2>
    <ul>
    <li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
    </ul>
    <h2>2.22.2 - 12 Oct 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
    <li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
    </ul>
    <h2>2.22.1 - 09 Oct 2023</h2>
    <ul>
    <li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
    </ul>
    <h2>2.22.0 - 06 Oct 2023</h2>
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/github/codeql-action/commit/407ffafae6a767df3e0230c3df91b6443ae8df75"><code>407ffaf</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2007">#2007</a> from github/update-v2.22.8-192ad9bd5</li>
    <li><a href="https://github.com/github/codeql-action/commit/4af462f4ba4cb64404dcb0bb40591f4e097bf284"><code>4af462f</code></a> Update changelog for v2.22.8</li>
    <li><a href="https://github.com/github/codeql-action/commit/192ad9bd5f0f28e050b84a9790c483b45e47edc1"><code>192ad9b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2001">#2001</a> from github/update-bundle/codeql-bundle-v2.15.3</li>
    <li><a href="https://github.com/github/codeql-action/commit/77c1abbd8342b1b08e8f32b11dff8f461376ffc0"><code>77c1abb</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.3</li>
    <li><a href="https://github.com/github/codeql-action/commit/9f150ba795bcdde5bcd148bb808cc028dc662bd8"><code>9f150ba</code></a> Bump the actions group with 1 update (<a href="https://redirect.github.com/github/codeql-action/issues/2004">#2004</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/e75de4cd731576ebcc78b21a71f82fed992732c5"><code>e75de4c</code></a> Bump typescript from 5.2.2 to 5.3.2 (<a href="https://redirect.github.com/github/codeql-action/issues/2002">#2002</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/80150c2141a5386c7765c47e92d82633a5c47c03"><code>80150c2</code></a> Bump the npm group with 12 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2003">#2003</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/4d999a4f2774d0e772147170353094a40ace7359"><code>4d999a4</code></a> Add changelog note</li>
    <li><a href="https://github.com/github/codeql-action/commit/83267d5070f0935ee677209ba5e088375ed323a6"><code>83267d5</code></a> Update default bundle to codeql-bundle-v2.15.3</li>
    <li><a href="https://github.com/github/codeql-action/commit/4b6aa0b07da05d6e43d0e5f9c8596a6532ce1c85"><code>4b6aa0b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1997">#1997</a> from github/mergeback/v2.22.7-to-main-66b90a5d</li>
    <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/74483a38d39275f33fcff5f35b679b5ca4a26a99...407ffafae6a767df3e0230c3df91b6443ae8df75">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.5&new-version=2.22.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e774e88 View commit details
    Browse the repository at this point in the history
Loading