Repository navigation
Comparing changes
Open a pull request
base repository: flutter/packages
base: 93eede7768d6
head repository: flutter/packages
compare: 10a178cb16d4
- 18 commits
- 91 files changed
- 11 contributors
Commits on Oct 16, 2026
-
[camera]fix camera failure due to wrong jpg extension (#13285)
On native side, we save the file as `jpg` rather than `jpeg`. The integration test simply use the enum type name, which is `jpeg`, hence file path mismatch. This test is skipped on CI, so we didn't catch it before. However, I will need to fix it to continue investigating test failures on my local machine. Fixes flutter/flutter#194528 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 8866126 - Browse repository at this point
Copy the full SHA 8866126View commit details -
[camera]do not sleep to avoid hang due to merged thread (#13289)
Previously, before thread merge, this worked, because sleep only blocks the UI thread. Now, after thread merge, the UI thread and platform thread are the same. So sleep would block all the internal setups (such as dart's event channel set up and DispatchQueue.main.async calls on the native side. Fixes flutter/flutter#194397 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for c9e9622 - Browse repository at this point
Copy the full SHA c9e9622View commit details -
Roll Flutter from 5c7e45ab4d9c to a3d71d82160a (26 revisions) (#13290)
flutter/flutter@5c7e45a...a3d71d8 2026-10-16 [email protected] 0 Initialize variables in the DlComplexityPathReceiver helper (flutter/flutter#194540) 2026-10-16 [email protected] Roll Fuchsia Test Scripts from V-qQL4158Nw6L-QLi... to 2T18KC7-LDQtmQiLP... (flutter/flutter#194527) 2026-10-16 [email protected] Remove BorderMaskBlur (flutter/flutter#194508) 2026-10-16 [email protected] Roll Skia from a577264dc087 to 470b8816a261 (1 revision) (flutter/flutter#194526) 2026-10-16 [email protected] [ios] Use DFS traversal to find engines of a scene automatically (rather than manually manage the engines list) (flutter/flutter#192457) 2026-10-16 [email protected] [Skia][DisplayList] Map local bounds through the local matrix in DlLocalMatrixImageFilter (flutter/flutter#193963) 2026-10-16 [email protected] [framework] Fix avoid_setters_without_getters warnings on mixin declarations (flutter/flutter#193856) 2026-10-16 [email protected] Roll Dart SDK from 84686ea04815 to 55a734a01fb1 (3 revisions) (flutter/flutter#194522) 2026-10-16 [email protected] Roll Skia from d131b7789482 to a577264dc087 (7 revisions) (flutter/flutter#194514) 2026-10-16 [email protected] Roll Fuchsia GN SDK from PDJz3b3CL31uoLOkD... to kFdyRnojbVy0cxvRZ... (flutter/flutter#194510) 2026-10-16 [email protected] Roll GN to f9eca75ae554 (flutter/flutter#194471) 2026-10-16 [email protected] refactor(flutter_tools): migrate RunCommand and RunCommandBase to OptionDescriptor and OptionBundle (flutter/flutter#194362) 2026-10-15 [email protected] refactor(flutter_tools): finish TestCommand OptionDescriptor and OptionBundle migration (flutter/flutter#194361) 2026-10-15 [email protected] [iOS][a11y] Fix VoiceOver announcement for unfocused password fields (flutter/flutter#192851) 2026-10-15 [email protected] Roll pub packages (flutter/flutter#194477) 2026-10-15 [email protected] refactor(flutter_tools): finish DriveCommand OptionDescriptor migration (flutter/flutter#194360) 2026-10-15 [email protected] [flutter_tools] Roll package:vm_service to 15.4.0 (flutter/flutter#194467) 2026-10-15 [email protected] refactor(flutter_tools): migrate AttachCommand to OptionDescriptor and OptionBundle (flutter/flutter#194359) 2026-10-15 [email protected] [flutter_tools] Inject dependencies into update-packages and package_map (flutter/flutter#194046) 2026-10-15 [email protected] [impeller] parallelize opengles shader compiles (flutter/flutter#194022) 2026-10-15 [email protected] Roll pub packages (flutter/flutter#194469) 2026-10-15 [email protected] Restrict web dev server to loopback by default (flutter/flutter#187595) 2026-10-15 [email protected] Roll Packages from a1ed23c to da40eaf (33 revisions) (flutter/flutter#194459) 2026-10-15 [email protected] [web] Render soft hyphens on Skwasm (flutter/flutter#193850) 2026-10-15 [email protected] refactor(flutter_tools): migrate AssembleCommand to OptionDescriptor (flutter/flutter#194358) 2026-10-15 [email protected] [windows] Add OpenGL golden test against ANGLE at D3D11 feature level 10_0 (flutter/flutter#194321) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for df2c368 - Browse repository at this point
Copy the full SHA df2c368View commit details -
[material_ui] Fallback theme follows platform cherry pick (#13278)
**Port of: flutter/flutter#194256 **Issue:** `Theme.of(context)` falls back to a `ThemeData` built once per isolate (`Theme._kFallbackTheme`) when there is no `Theme` ancestor. `ThemeData()` captures `defaultTargetPlatform` at construction, so the fallback's platform is frozen to whatever platform was in effect the first time a theme-less widget called `Theme.of(context)`. Under a `TargetPlatformVariant`, `debugDefaultTargetPlatformOverride` every later theme-less subtree keeps that first platform's selection controls, toolbar, cursor and other adaptive behavior. In a shuffled test run this makes theme-less tests depend on test order: with seed 20261008, text_field_test.dart fails 45 tests that pass in declaration order. **Fix:** Rebuild the cached fallback whenever its platform no longer matches `defaultTargetPlatform`, so a theme-less subtree adapts to the current platform the same way a `MaterialApp` does. `Theme`s built with an explicit platform are unaffected; only the fallback is compared. Adds a regression test in `theme_test.dart` that fails on master for every non-android variant. With the fallback following the variant, the two handle-drag tests in `text_field_test.dart` fail because they had only ever run against Android handles: desktop platforms draw no selection handles, and the Cupertino start handle sits above the line. These tests have been adjusted; restricted to the platforms that draw handles, the iOS start handle is grabbed where it actually is, the Fuchsia toolbar that covers the handles is hidden, and a test asserts that desktop platforms draw no handles. The orphaned no-shuffle tag is removed. **Other alternatives considered:** - `text_field_test.dart` only fix, tests explicitly install their own theme so `Theme.of(context)` does not return leaky fallback. Decided against this since it wouldn't fix this leak for all users as reported in #83788 Fixes [#83788](flutter/flutter#83788) Fixes [#194008](flutter/flutter#194008) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 3675456 - Browse repository at this point
Copy the full SHA 3675456View commit details -
[tool] Exempt
test_apps/from version and changelog checks (#13255)Follow-up to #12686. #12686 added `packages/material_ui/test_apps/a11y_assessments` and marked [`test_apps/` as ignored in `.pubignore`](https://github.com/flutter/packages/blob/ac2db9cfeaf69c5064739e0d477ef8cb9c19cd35/packages/material_ui/test_apps/.pubignore#L1-L2), so [`ValidateCommand.runForPackage`](https://github.com/flutter/packages/blob/ac2db9cfeaf69c5064739e0d477ef8cb9c19cd35/script/tool/lib/src/validate_command.dart#L176-L178) skips `test_apps/*` subpackages via `isPubIgnored`. However, when `validate --check-for-missing-changes` runs on the enclosing `material_ui` package, `checkPackageChangeState` only exempted `test_apps/a11y_assessments/test/...` via `pathComponents.contains('test')` and flagged `test_apps/a11y_assessments/lib/...` as requiring a version and `CHANGELOG.md` update: ``` The following packages had errors: packages/material_ui: Missing version change ``` Example CI failures: - https://ci.chromium.org/b/8668024481194498497 (on #13159) This PR adds `pathComponents.first == 'test_apps'` to `_isTestChange` in `package_state_utils.dart`.
Configuration menu - View commit details
-
Copy full SHA for 5d03858 - Browse repository at this point
Copy the full SHA 5d03858View commit details -
[cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scal…
…ing (#13118) Fixes flutter/flutter#193767 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 8d1c565 - Browse repository at this point
Copy the full SHA 8d1c565View commit details -
[VPAT] Declare input purpose on a11y_assessments text fields (#13243)
## Problem The a11y_assessments text field demos do not declare their input purpose, so on web the email fields render `autocomplete="off"` and the password fields render `autocomplete="on"`. The email demo uses `maxLines: null`, which makes the field a `<textarea>`, and the engine always writes `autocomplete="off"` on those. Neither demo sets `autofillHints`. ## Fix The email fields are now single-line with `keyboardType: TextInputType.emailAddress` and `autofillHints: [AutofillHints.email]`, so they render `<input autocomplete="email">`. The `@gmail.com` suffix and its `Semantics` wrapper are removed, since autofill would produce `[email protected]@gmail.com`. `hintMaxLines: 3` keeps the hint wrapping at large text scales, and the 3x-scale test now checks for ellipsis at 320px instead of a fixed height. The password fields get `autofillHints: [AutofillHints.password]`, which renders `autocomplete="current-password"` once focused. Unfocused and disabled password fields still render `autocomplete="off"`, because autofill hints are not in the semantics tree. That needs an engine change. ## Demo Run the test app on web and inspect the text inputs on #/text-field and #/text-field-password, before and after focusing them.Configuration menu - View commit details
-
Copy full SHA for 0563606 - Browse repository at this point
Copy the full SHA 0563606View commit details -
[google_maps_flutter_ios] Use 'let' for unmutated var (#13300)
This wasn't showing up in CI due to flutter/flutter#194517. Fixes flutter/flutter#194605 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 85e4d42 - Browse repository at this point
Copy the full SHA 85e4d42View commit details -
[camera]delete fake bitrate/fps integration tests (#13291)
## These tests are fake They are intended to verify higher fps/bit rate results in larger files. Based on the [commit history](f3ed1d3), the Android used to do the same test as iOS: ``` for (int n = 0; n < lengths.length - 1; n++) { expect(lengths[n], lessThan(lengths[n + 1]), reason: 'incrementing fps should increment file size'); } ``` But later it fails CI, so it changes to ``` for (int n = 0; n < lengths.length - 1; n++) { expect(lengths[n], greaterThan(0)); } ``` Also note that it still leaves `for (var n = 0; i < lengths.length-1; n++)` - the `-1` bound only made sense when comparing `length[n]` against `length[n+1]`. This is **NOT** the right way to fix a CI failure. The iOS tests passed the CI since we only run it on simulator, so the test is skipped. But if i run it locally, [it may pass or fail based on how I put my phone on the table](flutter/flutter#191202 (comment)) ( <-- Very funny, read it! 😃 ) ## Why remove 1. The test premise is wrong - higher FPS/bit rate setting does not necessarily mean larger file size, as explained in the link above. 2. Camera setting related tests are already deterministically covered in unit testes. Fixes flutter/flutter#194395 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for ddc298b - Browse repository at this point
Copy the full SHA ddc298bView commit details -
[image_picker_ios] Fix Swift warnings in ImagePickerPluginTests (#13299)
Fix bug where `presentingViewControllerWithoutWindowSceneUsesFrame` was asserting always true, so was hiding that the test wasn't really presenting a window. This wasn't showing up in CI due to flutter/flutter#194517. Fixes flutter/flutter#194603 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for e2caa58 - Browse repository at this point
Copy the full SHA e2caa58View commit details -
[pointer_interceptor_ios] Use 'let' for unmutated var (#13297)
This wasn't showing up in CI due to flutter/flutter#194517. Fixes flutter/flutter#194598 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for bd2af66 - Browse repository at this point
Copy the full SHA bd2af66View commit details -
[local_auth_darwin] Fix Swift 6 concurrency analyzer errors from life…
…cycle delegate methods (#13296) `FlutterApplicationLifeCycleDelegate` / `FlutterSceneLifeCycleDelegate` protocol requirements are nonisolated, remove `MainActor`. From #10836 Fixes flutter/flutter#194594 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for f8262d2 - Browse repository at this point
Copy the full SHA f8262d2View commit details -
[camera_avfoundation] Fixes sendability mismatch in completion handler (
#13298) This wasn't showing up in CI due to flutter/flutter#194517. Fixes flutter/flutter#194599 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for d73117f - Browse repository at this point
Copy the full SHA d73117fView commit details -
[file_selector_ios] Drop deprecated UIDocumentPickerMode code path (#…
…13292) ``` FileSelectorTests.swift:33:18: error: 'init(documentTypes:in:)' was deprecated in iOS 14.0 FileSelectorTests.swift:33:72: error: 'UIDocumentPickerMode' was deprecated in iOS 14.0: Use appropriate initializers instead ``` `init(forOpeningContentTypes:asCopy: true)` is equivalent to the previous `.import` mode. Update to Flutter 3.47 which also picks up the iOS 15 minimum. Remove old availability checks. This wasn't showing up in CI due to flutter/flutter#194517. Fixes flutter/flutter#128713 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for e391a79 - Browse repository at this point
Copy the full SHA e391a79View commit details
Commits on Oct 17, 2026
-
Configuration menu - View commit details
-
Copy full SHA for e01c343 - Browse repository at this point
Copy the full SHA e01c343View commit details -
[in_app_purchase_storekit] Add show manage subscriptions path (#12454)
Adds a new `showManageSubscriptions` method which wraps around storekit's [showManageSubscriptions(in:)](https://developer.apple.com/documentation/storekit/appstore/showmanagesubscriptions(in:)) Fixes flutter/flutter#159664 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 817b650 - Browse repository at this point
Copy the full SHA 817b650View commit details -
[shared_preferences] switch to ffi/jni pigeon (#12329)
Updates Android and Foundation implementations to use the latest pigeon with FFI and JNI. Should not change any underlying behaviors. Primarily to validate the latest pigeon functionality.
Configuration menu - View commit details
-
Copy full SHA for 0259ad7 - Browse repository at this point
Copy the full SHA 0259ad7View commit details
Commits on Oct 19, 2026
-
[material_ui] Fixes SearchAnchor and SearchBar semantics (#12680)
fixes flutter/flutter#190884 Too many inkwell and gesture recognizer wrapping the searchAnchor subtree that all tries to provide the same semantics action. This is ok in in renderobject because gesture arena will pick a winer, but not going to work in semantics ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 10a178c - Browse repository at this point
Copy the full SHA 10a178cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 93eede7768d6...10a178cb16d4