Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 83c2c4da97c5
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 129e08c1dff1
Choose a head ref
  • 13 commits
  • 85 files changed
  • 8 contributors

Commits on Jan 18, 2024

  1. Roll Flutter from def6af0 to f77f824 (25 revisions) (#5924)

    flutter/flutter@def6af0...f77f824
    
    2024-01-18 [email protected] Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771)
    2024-01-18 [email protected] Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762)
    2024-01-18 [email protected] Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760)
    2024-01-18 [email protected] Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759)
    2024-01-18 [email protected] Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214)
    2024-01-18 [email protected] Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752)
    2024-01-18 [email protected] Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751)
    2024-01-18 [email protected] Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749)
    2024-01-18 [email protected] Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744)
    2024-01-18 [email protected] Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747)
    2024-01-18 [email protected] [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731)
    2024-01-17 [email protected] Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712)
    2024-01-17 [email protected] Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223)
    2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715)
    2024-01-17 [email protected] Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657)
    2024-01-17 [email protected] Native assets: roll deps (flutter/flutter#141684)
    2024-01-17 [email protected] Run build tests on both x64 and arm64. (flutter/flutter#141206)
    2024-01-17 [email protected] Update tests to Xcode 15 (flutter/flutter#141706)
    2024-01-17 [email protected] [web] prepare for flutter/engine#49786 (flutter/flutter#141700)
    2024-01-17 [email protected] Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676)
    2024-01-17 [email protected] Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654)
    2024-01-17 [email protected] Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656)
    2024-01-17 [email protected] Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683)
    2024-01-17 [email protected] Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632)
    2024-01-17 [email protected] Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2cc0533 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef8ccdb View commit details
    Browse the repository at this point in the history
  3. [ci] Add flags to formatter command to decide which formatters to run (

    …#5905)
    
    Get ready for a world where `swift-format` is available on the `PATH` https://flutter-review.googlesource.com/c/recipes/+/54020
    
    1. Add `format --clang-format --java --kotlin --swift --dart` flags to decide whether to run specific formatters, as opposed to using the `path`.  Keep `swift-format` optional but default the others to run.  This matches the current behavior on Linux.
    2. Add `*-path` variants of each.
    
    This will allow us to run `format --swift --no-clang-format --no-java --no-kotlin --no-dart`  on the macOS bot so it doesn't duplicate same `format` call run on Linux.
    
    Part of flutter/flutter#41129
    jmagman authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8ab9b25 View commit details
    Browse the repository at this point in the history
  4. [google_maps_flutter] Clean up iOS example project (#5925)

    Follows up on #5915 to remove the example-app-level workaround for the lack of arm64 slice, since the `flutter` build process will handle it automatically with current versions (now that the plugin-level workaround has been restored).
    
    Also fixes another problem I noticed while removing those, which is that when I federated this plugin I never removed the RunnerTests and RunnerUITests targets from this project, even though all of the files had moved, leaving missing file references and targets that would not build. This hadn't been noticed because our tooling doesn't even try to run native tests on plugins that indicate that their implementation is in a different package (and we rarely manually open the native projects for the app-facing package).
    stuartmorgan-g authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a5b7875 View commit details
    Browse the repository at this point in the history
  5. Bump github/codeql-action from 3.23.0 to 3.23.1 (#5922)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.23.0 to 3.23.1.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
    <blockquote>
    <h1>CodeQL Action Changelog</h1>
    <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
    <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
    <h2>[UNRELEASED]</h2>
    <p>No user facing changes.</p>
    <h2>3.23.1 - 17 Jan 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
    <li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
    </ul>
    <h2>3.23.0 - 08 Jan 2024</h2>
    <ul>
    <li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
    <li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
    </ul>
    <h2>3.22.12 - 22 Dec 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
    </ul>
    <h2>3.22.11 - 13 Dec 2023</h2>
    <ul>
    <li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
    </ul>
    <h2>2.22.10 - 12 Dec 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
    </ul>
    <h2>2.22.9 - 07 Dec 2023</h2>
    <p>No user facing changes.</p>
    <h2>2.22.8 - 23 Nov 2023</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
    </ul>
    <h2>2.22.7 - 16 Nov 2023</h2>
    <ul>
    <li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
    <ul>
    <li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
    <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
    </ul>
    </li>
    </ul>
    <h2>2.22.6 - 14 Nov 2023</h2>
    <ul>
    <li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
    <li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
    </ul>
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/github/codeql-action/commit/0b21cf2492b6b02c465a3e5d7c473717ad7721ba"><code>0b21cf2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2089">#2089</a> from github/update-v3.23.1-f65ecd09c</li>
    <li><a href="https://github.com/github/codeql-action/commit/ae616145ed5a0d64a670cddaf1306bd35b978202"><code>ae61614</code></a> Update changelog for v3.23.1</li>
    <li><a href="https://github.com/github/codeql-action/commit/f65ecd09c7594dc5bfccb15a694c4d15971c9b73"><code>f65ecd0</code></a> Only delete SARIF in PR check if not running on a fork  (<a href="https://redirect.github.com/github/codeql-action/issues/2084">#2084</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/4d75a10efaeb4b135a886e21e438f08fd32a87ab"><code>4d75a10</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2073">#2073</a> from github/update-bundle/codeql-bundle-v2.16.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/e65c5d92f7c1e067aaca8aa8a9a714db5322e074"><code>e65c5d9</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2086">#2086</a> from github/dependabot/npm_and_yarn/npm-c0441c84d9</li>
    <li><a href="https://github.com/github/codeql-action/commit/6b12e3d9d9976c9372b35297046ba0adddb4fb10"><code>6b12e3d</code></a> Update checked-in dependencies</li>
    <li><a href="https://github.com/github/codeql-action/commit/e292db6207ceb5de549d18b4cd713c4c84d06b45"><code>e292db6</code></a> Bump the npm group with 4 updates</li>
    <li><a href="https://github.com/github/codeql-action/commit/1fea7a57e709f40b2c9f20431ca0c7c325a8ba63"><code>1fea7a5</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/96531062ba46eb11dee25758db76518ad30ee4cf"><code>9653106</code></a> Stop setting <code>CODEQL_RUNNER</code> environment variable if CLI already sets it (<a href="https://redirect.github.com/github/codeql-action/issues/2081">#2081</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/eb14aeb61d80eb999887486ac17a507b970d02f0"><code>eb14aeb</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2080">#2080</a> from github/henrymercer/fix-unconditional-warning</li>
    <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e5f05b81d5b6ff8cfa111c80c22c5fd02a384118...0b21cf2492b6b02c465a3e5d7c473717ad7721ba">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.23.0&new-version=3.23.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    39ffed3 View commit details
    Browse the repository at this point in the history
  6. [pointer_interceptor] fix width and height unset warning on web platf…

    …orm (#5864)
    
    This PR adds width/height to the dom element created by the default factory to prevent the framework from screaming at usages of this plugin.
    
    Needed until this bit becomes `stable`:
    
    * https://github.com/flutter/engine/blob/3106e08e12198d98b75c459ac3290f4101b68574/lib/web_ui/lib/src/engine/platform_views/content_manager.dart#L229-L238
    
    ## Issues
    
    * Fixes flutter/flutter#141323
    
    - [] I updated/added relevant documentation (doc comments with `///`).
    cedvdb authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3e7d502 View commit details
    Browse the repository at this point in the history
  7. [two_dimensional_scrollables] Fix must_call_super (#5921)

    This would fix the analyzer error for `two_dimensional_scrollables` after merging the flutter/flutter#141504.
    Amir-P authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a5dbf45 View commit details
    Browse the repository at this point in the history
  8. [webview_flutter_wkwebview] Add javascript panel interface for wkwebv…

    …iew (#5795)
    
    * There are cases where Web calls System Popup with javascript on webview_flutter
    * At this time, the message comes in the WKUIDelegate part in iOS.
       * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview
       * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview
    * Related issue: flutter/flutter#30358 (comment)
    * Related Interface PR: #5670
    * The PR that contains all changes can be found at #4704
    jsharp83 authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2762c54 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. [camera_avfoundation] Remove development team from Xcode example app (#…

    …5930)
    
    `DEVELOPMENT_TEAM` should not be set in the example Xcode app.  Introduced extraneously in #3272
    jmagman authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1ccc0e1 View commit details
    Browse the repository at this point in the history
  2. [various] Run swift-format on example app Swift files (#5931)

    Run `swift-format` linter/formatter on Swift files in example apps.  This doesn't touch any Swift files in non-example code.
    
    Part of turning on swift-format CI formatting #5928
    jmagman authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4dd91ce View commit details
    Browse the repository at this point in the history
  3. [shared_preferences_foundation] Run swift-format on Swift files (#5933)

    Run `swift-format` linter/formatter on Swift files.
    
    Part of turning on swift-format CI formatting #5928
    jmagman authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    76a6fd2 View commit details
    Browse the repository at this point in the history
  4. [path_provider_foundation] Run swift-format on Swift files (#5935)

    Run `swift-format` linter/formatter on Swift files.
    
    Part of turning on swift-format CI formatting #5928
    jmagman authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9379e4a View commit details
    Browse the repository at this point in the history
  5. [pigeon] Run swift-format on ungenerated example app Swift files (#5934)

    Run `swift-format` linter/formatter on Swift files in example apps.  This only touches Swift files in example/test code.  
    
    This also doesn't format any autogenerated Swift files, which would require changed in the pigeon generator: flutter/flutter#141799
    
    Part of turning on swift-format CI formatting #5928
    jmagman authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    129e08c View commit details
    Browse the repository at this point in the history
Loading