-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Comparing changes
Open a pull request
base repository: flutter/packages
base: 7ae082a7f6cd
head repository: flutter/packages
compare: 582f0e714974
- 8 commits
- 26 files changed
- 6 contributors
Commits on Mar 27, 2026
-
[two_dimensional_scrollables] Add regression test (#11376)
Fixes flutter/flutter#137112 This PR adds a regression test for flutter/flutter#137112, where TableView would crash when focusing a widget outside of the table while a previously focused TextField inside the table was scrolled out of view. While this issue appears to have been resolved by changes in the Flutter framework specifically flutter/flutter#135182 which addressed how focus keeps children alive in two-dimensional scrollables, this PR adds a dedicated test case to the package to ensure this behavior does not regress. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 4e8e8c4 - Browse repository at this point
Copy the full SHA 4e8e8c4View commit details -
Roll Flutter from e79bf6cbc140 to fb03253e32ce (16 revisions) (#11379)
flutter/flutter@e79bf6c...fb03253 2026-03-27 [email protected] flutter_driver: remove @internal annotation on field (flutter/flutter#184235) 2026-03-27 [email protected] Roll Skia from 5299de75c97b to 8c705ac86366 (2 revisions) (flutter/flutter#184245) 2026-03-27 [email protected] Roll Packages from 0dd2410 to 7ae082a (5 revisions) (flutter/flutter#184248) 2026-03-27 [email protected] Roll Skia from 9beded929d5a to 5299de75c97b (1 revision) (flutter/flutter#184243) 2026-03-27 [email protected] Roll Skia from 4f4f07084ef0 to 9beded929d5a (4 revisions) (flutter/flutter#184237) 2026-03-27 [email protected] Roll Dart SDK from ea1bce22b45b to dfd1f8af3c52 (2 revisions) (flutter/flutter#184234) 2026-03-27 [email protected] Roll Skia from 1b7154852825 to 4f4f07084ef0 (1 revision) (flutter/flutter#184231) 2026-03-27 [email protected] Roll Skia from aec9a7ab7ed9 to 1b7154852825 (1 revision) (flutter/flutter#184230) 2026-03-27 [email protected] fix: show window after first frame callback (flutter/flutter#183454) 2026-03-27 [email protected] Roll Dart SDK from 7587a31814c6 to ea1bce22b45b (1 revision) (flutter/flutter#184228) 2026-03-27 [email protected] skip interactive keyboard tests (flutter/flutter#183757) 2026-03-26 [email protected] Build engine for windows_arm on beta and stable (flutter/flutter#176385) 2026-03-26 [email protected] Roll Skia from bee5a06ef578 to aec9a7ab7ed9 (4 revisions) (flutter/flutter#184222) 2026-03-26 [email protected] Update iOS/macOS flutter_tools CODEOWNERS (flutter/flutter#183287) 2026-03-26 [email protected] Update changelog for 3.41.6 stable hotfix (flutter/flutter#184220) 2026-03-26 [email protected] Updates scroll cache extent doc (flutter/flutter#184142) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 312839a - Browse repository at this point
Copy the full SHA 312839aView commit details -
Roll Flutter (stable) from 2c9eb20739df to db50e20168db (6 revisions) (…
…#11380) flutter/flutter@2c9eb20...db50e20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-stable-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 60eb967 - Browse repository at this point
Copy the full SHA 60eb967View commit details -
[Animations] add example to
openCntainer(#11189)Fixes the todo : `TODO(goderbauer): Add example animations and sample code.` ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for cd60860 - Browse repository at this point
Copy the full SHA cd60860View commit details -
Roll Flutter (stable) from 2c9eb20739df to db50e20168db (6 revisions) (…
…#11380) flutter/flutter@2c9eb20...db50e20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-stable-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ea4c006 - Browse repository at this point
Copy the full SHA ea4c006View commit details -
CODEOWNERS was originally added to deal with the problem of routing reviews to the right people, given the highly disparate ownership of packages in this repo. However, it has always had some significant drawbacks due the rigid implementation GitHub has for it, and some are getting worse: - Low-quality PRs that should be handled in initial triage were going directly to individual reviewers, who don't necessarily know what kinds of pre-review filters to apply, causing some wasted reviewer effort - The increase of agent-generated PRs is making this worse, and that trend will almost certainly continue to increase - Some PRs (e.g., rolling all the minimum SDK versions when a new `stable` is released) spam a lot of people who don't actually need to do the review, again wasting some people's time. - The way the new batch release process merges changes across branches will make this much more common. - Plugin PRs are routed to all reviewers at once. In some cases platform reviewers would review implementations before the cross-platform owner reviewed, and either asked for fundamental API changes, or decided it wasn't something we should do at all, which wastes reviewer time and is a terrible experience for the contributor. Ideally the cross-platform owners should sanity-check the proposed change before looping in platform implementation reviewers. - It's impossible to remove people who don't need to review for whatever reason. This means the state of the `Reviewers` section in a PR's sidebar often doesn't (and can't) reflect reality, making triage of current PR states much harder. The `triage-<subeam>` label system that we have added more recently solves a lot of the problems that CODEOWNERS was meant to solve in the first place, without any of the downsides. It will also bring flutter/packages PR handling more in line with flutter/flutter PR handling, which makes our processes more coherent. Rather than eliminating the file entirely, I turned it into a markdown file that we can refer to. I no longer have repo tool enforcement however, to allow for changes in structure over time (e.g., for some low-traffic subteam-owned packages, they may prefer not have specific owners, and just triage to individuals in an ad-hoc way in their subteam triage). As a starting point it has the same people that the CODEOWNERs did, and we can iterate from there (or remove it later if it turns out that keeping it up to date isn't a good use of time).
Configuration menu - View commit details
-
Copy full SHA for e8df95d - Browse repository at this point
Copy the full SHA e8df95dView commit details
Commits on Mar 28, 2026
-
[pigeon] bumps analyzer support to between 10 and 12 (#11358)
Don't land this until [previous bump ](#11346 fixes flutter/flutter#184119 fixes flutter/flutter#182064 fixes flutter/flutter#184269
Configuration menu - View commit details
-
Copy full SHA for 2dc597c - Browse repository at this point
Copy the full SHA 2dc597cView commit details
Commits on Mar 30, 2026
-
Bump lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the all-gith…
…ub-actions group (#11388) Bumps the all-github-actions group with 1 update: [lewagon/wait-on-check-action](https://github.com/lewagon/wait-on-check-action). Updates `lewagon/wait-on-check-action` from 1.5.0 to 1.6.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lewagon/wait-on-check-action/releases">lewagon/wait-on-check-action's releases</a>.</em></p> <blockquote> <h2>v1.6.0</h2> <h3>Added</h3> <ul> <li>Add <code>checks-discovery-timeout</code> option (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/139">#139</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/lewagon/wait-on-check-action/blob/master/CHANGELOG.md">lewagon/wait-on-check-action's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>Unreleased</h2> <h2>v1.6.0 - 2026-03-29</h2> <h3>Added</h3> <ul> <li>Add <code>checks-discovery-timeout</code> option</li> </ul> <h2>v1.5.0 - 2026-01-25</h2> <h3>Added</h3> <ul> <li>Add <code>fail-on-no-checks</code> option</li> </ul> <h3>Fixed</h3> <ul> <li>Bump <code>rexml</code> to 3.4.2</li> </ul> <h2>v1.4.1 - 2025-09-21</h2> <h3>Fixed</h3> <ul> <li>Linux ARM64 support</li> </ul> <h2>v1.4.0 - 2025-06-27</h2> <h3>Added</h3> <ul> <li>Add class docs</li> <li>Add <code>frozen_string_literal</code> comments</li> </ul> <h3>Removed</h3> <ul> <li>Remove OpenStruct instances</li> <li>Remove Double quotes</li> <li>Remove Double assertions</li> <li>Remove <code>allow_any</code> uses</li> </ul> <h3>Fixed</h3> <ul> <li>Fix spelling mistakes</li> <li>Fix CI gem caching</li> <li>Convert <code>config.verbose</code> to a boolean</li> <li>Bump <code>rexml</code> to 3.3.9</li> </ul> <h2>v1.3.4 - 2024-04-04</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/a08fbe2b86f9336198f33be6ad9c16b96f92799c"><code>a08fbe2</code></a> Bump version: 1.5.0 → 1.6.0</li> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/9499267060f00ae49f3c9ab42d90b34ce8ef15a1"><code>9499267</code></a> Add v1.6.0 changelog notes (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/141">#141</a>)</li> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/fa9c37b680741f9eed88d118e00381fa6db79486"><code>fa9c37b</code></a> Add checks-discovery-timeout documentation (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/140">#140</a>)</li> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/e183d729a755a90b696839fe3c72176ce23750b7"><code>e183d72</code></a> fix/wait for check discovery (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/139">#139</a>)</li> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/8ad3eafc3636da3a4cd99725a070b2499207c62a"><code>8ad3eaf</code></a> Bump faraday from 2.3.0 to 2.14.1 (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/136">#136</a>)</li> <li><a href="https://github.com/lewagon/wait-on-check-action/commit/93f813337c107ef5cad38ea830b5787f941a29ef"><code>93f8133</code></a> Set repo-token as required and validate required inputs (<a href="https://redirect.github.com/lewagon/wait-on-check-action/issues/135">#135</a>)</li> <li>See full diff in <a href="https://github.com/lewagon/wait-on-check-action/compare/74049309dfeff245fe8009a0137eacf28136cb3c...a08fbe2b86f9336198f33be6ad9c16b96f92799c">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>
Configuration menu - View commit details
-
Copy full SHA for 582f0e7 - Browse repository at this point
Copy the full SHA 582f0e7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7ae082a7f6cd...582f0e714974