Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 771ec9b42a38
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9bcf4bfa493f
Choose a head ref
  • 12 commits
  • 78 files changed
  • 6 contributors

Commits on Jul 6, 2023

  1. Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (#4387)

    flutter/flutter@35085c3...bc49cd1
    
    2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877)
    2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854)
    2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040)
    2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804)
    2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741)
    2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879)
    2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860)
    2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035)
    2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663)
    2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008)
    2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023)
    2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902)
    2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303)
    2023-07-05 [email protected] Add .env file support for  option `--dart-define-from-file` (flutter/flutter#128668)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5727ee3 View commit details
    Browse the repository at this point in the history
  2. [file_selector] Update to 1.0 (#4362)

    `file_selector` now supports all platforms, and all of the API-changing requests that have been made in the life of the plugin have been made, so a 1.0 version better reflects the current state of the plugin.
    
    As part of the breaking version change, removes the deprecated `getSavePath`; while the deprecation is recent, the transition to `getSaveLocation` is trivial, and there are very few published dependencies on `file_selector` so ecosystem impact will be extremely minimal.
    stuartmorgan-g authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ee84c2a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38dd934 View commit details
    Browse the repository at this point in the history
  4. [ci] Switch master Linux custom package tests to LUCI (#4386)

    Enables the new LUCI target for `master`, and removes the Cirrus version.
    
    I only pre-tested `master`, and it turns out that `stable` is blocked by flutter/flutter#130071.
    
    Part of flutter/flutter#114373
    stuartmorgan-g authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6bc75c8 View commit details
    Browse the repository at this point in the history
  5. [ci] Add partial LUCI Android platform tests (#4381)

    Adds an initial Android platform tests LUCI script, and initial targets in bringup mode (using 6 shards instead of the 8 we have in Cirrus since the added shards were to try to address what in retrospect was likely a device availability issue, and since for now this will be running fewer tests; once everything is migrated we can evaluate whether we need more shards).
    
    Rather than wait for emulator and/or FTL support in LUCI to do the migration of this target, this will partially migrate; the script currently does only the parts that don't require any kind of device. That will let us set up a baseline of LUCI Android platform tests bots to easily expand from as we figure out those pieces, and we can turn down these parts of the tests in Cirrus once these come out of bringup mode to minimize duplication.
    
    To avoid having to run a full `flutter build` for both versions, this also updates the repo tooling to use the new `flutter build apk --config-only` option to create `gradlew` without doing a full build.
    
    Part of flutter/flutter#114373
    stuartmorgan-g authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ff00264 View commit details
    Browse the repository at this point in the history
  6. [url_launcher] Remove nested third_party safari checker (#4330)

    Remove nested third_party safari checker
    
    - Replace nested third party safari checker with clean room implementation. 
    - Fixes flutter/flutter#129575
    
    - [x ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.)
    victorsanni authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    443e041 View commit details
    Browse the repository at this point in the history
  7. [local_auth] Update Windows Pigeon version (#4388)

    Updates to the latest version of Pigeon.
    
    This is largely a no-op, the generated output changes are formatting tweaks and picking up one bugfix to the error code/message ordering. The goal here is just to be using a newer version of Pigeon to minimize future dependency issues along the lines of #4383
    stuartmorgan-g authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    3fec7e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    56e3b1c View commit details
    Browse the repository at this point in the history
  9. Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#4302)

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
    <blockquote>
    <h2>v2.2.0</h2>
    <h2>What's Changed</h2>
    <ul>
    <li>:seedling: Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock"><code>@�spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192">ossf/scorecard-action#1192</a></li>
    </ul>
    <h2>Scorecard Result Viewer</h2>
    <p>Thanks to contributions from <a href="https://github.com/cynthia-sg"><code>@�cynthia-sg</code></a> and <a href="https://github.com/tegioz"><code>@�tegioz</code></a> at <a href="https://github.com/cncf/clomonitor">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=&lt;project-url&gt;</code>.</p>
    <ul>
    <li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406">ossf/scorecard-webapp#406</a></li>
    <li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422">ossf/scorecard-webapp#422</a></li>
    </ul>
    <p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard">here</a>
    Checkout our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#scorecard-badge">README</a> to learn how to link your README badge to the new visualization page.</p>
    <h2>Publishing Results</h2>
    <p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p>
    <ul>
    <li>Runs that fail our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#workflow-restrictions">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150">ossf/scorecard-action#1150</a>)</li>
    <li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191">ossf/scorecard-action#1191</a>)</li>
    </ul>
    <h2>Docs</h2>
    <ul>
    <li>� Update README to accept fine-grained tokens by <a href="https://github.com/pnacht"><code>@�pnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
    <li>� Update installation instructions to match current GitHub UI  by <a href="https://github.com/joycebrum"><code>@�joycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153">ossf/scorecard-action#1153</a></li>
    <li>� Document the GitHub action workflow restrictions when publishing results. by <a href="https://github.com/spencerschrock"><code>@�spencerschrock</code></a> in</li>
    </ul>
    <h2>New Contributors</h2>
    <ul>
    <li><a href="https://github.com/bobcallaway"><code>@�bobcallaway</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1140">ossf/scorecard-action#1140</a></li>
    <li><a href="https://github.com/pnacht"><code>@�pnacht</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0">https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/ossf/scorecard-action/commit/08b4669551908b1024bb425080c797723083c031"><code>08b4669</code></a> 🌱 Bump docker tag to for v2.2.0 release. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1194">#1194</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/3c7470f58c4371d8ac58beaeeacf771227d63ce8"><code>3c7470f</code></a> 📖 Update README badge link to use new uri param. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1185">#1185</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/a164dbc12a66d9fae8ec379fff6ba200da366366"><code>a164dbc</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1192">#1192</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/597960e1d95e5c741af238a819f03655e2fa43b8"><code>597960e</code></a> 📖 Update README to accept fine-grained tokens (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1175">#1175</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/8808ed28c3b8ba5a7d8059bd0360d8374ff6adb3"><code>8808ed2</code></a> 🌱 Retry external network calls when publishing results (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1191">#1191</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/0eed6cb5da014387b234df059cd4a2db5dbe9e1f"><code>0eed6cb</code></a> 🌱 Bump golang.org/x/net from 0.10.0 to 0.11.0</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/6c6335c126308fd03da1c3bb267c1ebc3a34db0c"><code>6c6335c</code></a> 🌱 Bump github/codeql-action from 2.3.6 to 2.20.0</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/7f1baf380a4f4418b4864d5a57bee1beba03e2eb"><code>7f1baf3</code></a> 📖 Switch recommended badge link to the new viewer. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1176">#1176</a>)</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/df98bbc13d1c3001cc90b8a2791ffde7ba29f061"><code>df98bbc</code></a> 🌱 Bump actions/checkout from 3.5.2 to 3.5.3</li>
    <li><a href="https://github.com/ossf/scorecard-action/commit/75886d414a5cd048874360697f1e8edb5b1e55ca"><code>75886d4</code></a> 🌱 Bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1172">#1172</a>)</li>
    <li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/80e868c13c90f172d68d1f4501dee99e2479f7af...08b4669551908b1024bb425080c797723083c031">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.3&new-version=2.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b267e31 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. [ci] Add partial LUCI version of repo_checks (#4389)

    Adds a bringup-mode version of the parts of `repo_checks` that can currently be run on LUCI.
    
    When this is enabled in a follow-up I'll remove the relevant checks from the Cirrus version, leaving `repo_checks` split across the two systems for now, but without duplication. This has a slight overhead in terms of machine setup, but allow better isolating the parts of the CI that are still actually blocked from migration.
    
    Part of flutter/flutter#114373
    stuartmorgan-g authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0f2f62b View commit details
    Browse the repository at this point in the history
  2. [webview_flutter] Enable unawaited_futures lint (#4271)

    Removes the exception, and enables the lint, fixing violations.
    
    Although this does make the tests more verbose, explicitly marking everything as unawaited is preferable to turning it off for the whole file since we have had bugs with not correctly awaiting important parts of tests in the past (such as completers).
    
    Part of flutter/flutter#127323
    stuartmorgan-g authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    fd04153 View commit details
    Browse the repository at this point in the history
  3. [ci] Add LUCI web platform tests (#4391)

    Adds web platform tests for LUCI in bringup mode.
    
    The Cirrus version of the test starts `chromedriver` at the beginning and just leaves it running, which is fine since it's a fresh docker image each run. For LUCI we don't want that behavior though, so instead this adds tooling support for running chromedriver as part of running the integration tests, controllable with a flag. This will also be useful for running locally.
    
    Part of flutter/flutter#114373
    stuartmorgan-g authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9bcf4bf View commit details
    Browse the repository at this point in the history
Loading