Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5b48c446976f
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d37fb0a716e7
Choose a head ref
  • 14 commits
  • 79 files changed
  • 9 contributors

Commits on Jan 31, 2024

  1. [in_app_purchase] Add play country code api (#5941)

    - Initial add of country code, no tests
    - Add tests for getBillingConfig
    
    fixes flutter/flutter/issues/141627
    
    Hold merging on:
    reidbaker authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7b1ae1f View commit details
    Browse the repository at this point in the history
  2. [in_app_purchase] Convert storefront(), transactions(), canMakePaymen…

    …t(), and addPayment() to pigeon (#5910)
    
    Part 1 of flutter/flutter#117910
    
    This PR converts storefront(), addPayment(), transactions(), and
    canMakePayment().
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    LouiseHsu authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    871a24b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be0124d View commit details
    Browse the repository at this point in the history
  4. [two_dimensional_scrollables] Merged cells for TableView (#5917)

    Fixes flutter/flutter#131224
     
    ��  [Design Doc](https://docs.google.com/document/d/1UekXjG_VKmWYbsxDEzMqTb7F-6oUr05v998n5IqtVWs/edit?usp=sharing) �� 
    
    This adds support for merged cells in TableView.
    This contains a breaking change that will require all children of the TableView to be a TableViewCell.
    
    ![Screenshot 2024-01-25 at 4 38 49�PM](https://github.com/flutter/packages/assets/16964204/02f4c158-23e9-401e-ac84-b6303d999095)
    Piinks authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2d0f24f View commit details
    Browse the repository at this point in the history
  5. [tool] Extend flutter test workaround to other desktops (#6024)

    Expand the multiple-test-files workaround in `drive-examples` from macOS to all of the desktop platforms, now that we know it's not macOS-specific.
    
    See flutter/flutter#135673
    stuartmorgan-g authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    60a1ffc View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. [webview_flutter] Support for handling basic authentication requests (#…

    …5727)
    
    ## Description
    This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455.
    
    Issues fixed by PR:
    Closes flutter/flutter#83556
    JeroenWeener authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    013763d View commit details
    Browse the repository at this point in the history
  2. Roll Flutter from ace9181 to 75a2e5b (16 revisions) (#6017)

    flutter/flutter@ace9181...75a2e5b
    
    2024-01-30 [email protected] Reset
    framesEnabled to default value at the end of each test
    (flutter/flutter#141844)
    2024-01-30 [email protected] Fix SliverMainAxisGroup geometry
    cacheExtent (flutter/flutter#142482)
    2024-01-30 [email protected] Roll Flutter Engine from
    0e586d1c28c8 to f02a4a80a77e (3 revisions) (flutter/flutter#142528)
    2024-01-30 [email protected] Roll Packages from
    516648a to 25abb5d (6 revisions) (flutter/flutter#142527)
    2024-01-30 [email protected] Roll Flutter Engine from
    438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (flutter/flutter#142515)
    2024-01-30 [email protected] Using
    `initExpensiveAndroidView` for Android Hybrid Composition Mode
    (flutter/flutter#142399)
    2024-01-30 [email protected] Roll Flutter Engine from
    ed73d40a8c93 to 438e9b4d7d4e (1 revision) (flutter/flutter#142508)
    2024-01-30 [email protected] Organize leak tracking TODOs.
    (flutter/flutter#142460)
    2024-01-30 [email protected] Roll Flutter Engine from
    5584a78a439b to ed73d40a8c93 (1 revision) (flutter/flutter#142504)
    2024-01-30 [email protected] Roll Flutter Engine from
    df5f1afd4991 to 5584a78a439b (2 revisions) (flutter/flutter#142503)
    2024-01-30 [email protected] Roll Flutter Engine from
    65bf8b1db4d1 to df5f1afd4991 (1 revision) (flutter/flutter#142501)
    2024-01-30 [email protected] Roll Flutter Engine from
    c9268c7db03c to 65bf8b1db4d1 (1 revision) (flutter/flutter#142496)
    2024-01-30 [email protected] Roll Flutter Engine from
    e21208583956 to c9268c7db03c (1 revision) (flutter/flutter#142492)
    2024-01-29 [email protected] Roll Flutter Engine from
    bedafa8794b6 to e21208583956 (1 revision) (flutter/flutter#142483)
    2024-01-29 [email protected] Revert "Reland:
    "Fix how Gradle resolves Android plugin" (#137115)"
    (flutter/flutter#142464)
    2024-01-29 [email protected] Marks Mac_pixel_7pro
    native_assets_android to be unflaky (flutter/flutter#141675)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Packages:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    be4dd93 View commit details
    Browse the repository at this point in the history
  3. Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (#6026)

    Manual roll requested by [email protected]
    
    flutter/flutter@75a2e5b...c65ab4d
    
    2024-01-31 [email protected] Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583)
    2024-01-31 [email protected] Add `DropdownMenu.focusNode` (flutter/flutter#142516)
    2024-01-31 [email protected] Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042)
    2024-01-31 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039)
    2024-01-31 [email protected] Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040)
    2024-01-31 [email protected] Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041)
    2024-01-31 [email protected] Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647)
    2024-01-31 [email protected] Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569)
    2024-01-31 [email protected] Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566)
    2024-01-31 [email protected] M3 - Fix Chip icon and label colors (flutter/flutter#140573)
    2024-01-31 [email protected] Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564)
    2024-01-30 [email protected] Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611)
    2024-01-30 [email protected] use PDI to end the isolated scope for RLI (flutter/flutter#141345)
    2024-01-30 [email protected] Style correctness improvements for toStrings and related fixes (flutter/flutter#142485)
    2024-01-30 [email protected] Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554)
    2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553)
    2024-01-30 [email protected] Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551)
    2024-01-30 [email protected] Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548)
    2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543)
    2024-01-30 [email protected] Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476)
    2024-01-30 [email protected] Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675)
    2024-01-30 [email protected] Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    aee1980 View commit details
    Browse the repository at this point in the history
  4. Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (#6028)

    Manual roll Flutter from c65ab4d to e02e207 (38 revisions)
    
    Manual roll requested by [email protected]
    
    flutter/flutter@c65ab4d...e02e207
    
    2024-02-01 [email protected] Roll Flutter Engine from f4fbabf1eb9f to 68943afd62d1 (9 revisions) (flutter/flutter#142690)
    2024-02-01 [email protected] Introduce tone-based surfaces and accent color add-ons - Part 1 (flutter/flutter#142654)
    2024-02-01 [email protected] improve error message when `--base-href` argument does not start with `/` (flutter/flutter#142667)
    2024-02-01 [email protected] Roll Flutter Engine from c4247c5e31ba to f4fbabf1eb9f (1 revision) (flutter/flutter#142675)
    2024-02-01 [email protected] Roll Flutter Engine from c83617eee093 to c4247c5e31ba (3 revisions) (flutter/flutter#142662)
    2024-02-01 [email protected] [Impeller] opt vulkan tests into GPU tracing. (flutter/flutter#142649)
    2024-02-01 [email protected] Convert button `.icon` and `.tonalIcon` constructors to take nullable icons. (flutter/flutter#142644)
    2024-02-01 [email protected] Fix token usages on Regular Chip and Action Chip (flutter/flutter#141701)
    2024-02-01 [email protected] Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#141818)
    2024-01-31 [email protected] Roll Flutter Engine from 5b89189b8b5f to c83617eee093 (2 revisions) (flutter/flutter#142656)
    2024-01-31 [email protected] [flutter_tools] add debugging to ios/core_devices.dart (flutter/flutter#142187)
    2024-01-31 [email protected] Fix showDialog docs (flutter/flutter#142458)
    2024-01-31 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 5.0.2 to 6.0.0 (flutter/flutter#142650)
    2024-01-31 [email protected] Roll Flutter Engine from 20e53614c16c to 5b89189b8b5f (2 revisions) (flutter/flutter#142640)
    2024-01-31 [email protected] Refactor ShaderTarget to not explicitly mention impeller or Skia (flutter/flutter#141460)
    2024-01-31 [email protected] Roll Flutter Engine from 9ccd81d7595b to 20e53614c16c (3 revisions) (flutter/flutter#142628)
    2024-01-31 [email protected] Show Mac Designed For iPad in 'flutter devices' (flutter/flutter#141718)
    2024-01-31 [email protected] Marks Mac_arm64_ios basic_material_app_ios__compile to be unflaky (flutter/flutter#142594)
    2024-01-31 [email protected] Fix ParentDataWidget crash for  multi view scenarios (flutter/flutter#142486)
    2024-01-31 [email protected] Roll Flutter Engine from e0d8f472a1b6 to 9ccd81d7595b (1 revision) (flutter/flutter#142625)
    2024-01-31 [email protected] Marks Mac_arm64 tool_tests_commands to be unflaky (flutter/flutter#142593)
    2024-01-31 [email protected] "System back gesture" explanation (flutter/flutter#142254)
    2024-01-31 [email protected] Marks Mac_x64 tool_tests_commands to be unflaky (flutter/flutter#142592)
    2024-01-31 [email protected] Marks Mac_x64_ios integration_test_test_ios to be unflaky (flutter/flutter#142595)
    2024-01-31 [email protected] Marks Mac_x64 native_ui_tests_macos to be unflaky (flutter/flutter#142598)
    2024-01-31 [email protected] Marks Mac_x64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky (flutter/flutter#142597)
    2024-01-31 [email protected] Marks Mac_arm64 native_ui_tests_macos to be unflaky (flutter/flutter#142599)
    2024-01-31 [email protected] Marks Windows_android hot_mode_dev_cycle_win__benchmark to be flaky (flutter/flutter#142609)
    2024-01-31 [email protected] Marks Mac_arm64_ios integration_test_test_ios to be unflaky (flutter/flutter#142596)
    2024-01-31 [email protected] Mark test that leaks image. (flutter/flutter#142539)
    2024-01-31 [email protected] Roll Flutter Engine from b9bc256156b8 to e0d8f472a1b6 (1 revision) (flutter/flutter#142623)
    2024-01-31 [email protected] Fix unresponsive mouse tooltip (flutter/flutter#142282)
    2024-01-31 [email protected] Marks Linux_android_emu android_defines_test to be unflaky (flutter/flutter#142591)
    2024-01-31 [email protected] Roll Flutter Engine from 447dd212447e to b9bc256156b8 (6 revisions) (flutter/flutter#142617)
    2024-01-31 [email protected] Roll Packages from 25abb5d to 5b48c44 (4 revisions) (flutter/flutter#142616)
    2024-01-31 [email protected] Fix null operator error when tapping on 'MenuItemButton' (flutter/flutter#142230)
    2024-01-31 [email protected] Roll Flutter Engine from 8e7df85f7d11 to 447dd212447e (2 revisions) (flutter/flutter#142587)
    2024-01-31 [email protected] Split out AppBar/SliverAppBar material tests (flutter/flutter#142560)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    ...
    engine-flutter-autoroll authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    65122e5 View commit details
    Browse the repository at this point in the history
  5. [camerax] Change buildPreview to return Texture versus `FutureBui…

    …lder` (#6021)
    
    Changes the `buildPreview` implementation to return a `Texture` versus a `FutureBuilder` that would ultimately return that same `Texture`.
    
    The `FutureBuilder` depended on checking a condition that should be true by default assuming `createCamera` was called prior. This seems to be an assumption made consistently across other platform implementations (including `camera_android`-- see [source](https://github.com/flutter/packages/blob/7b1ae1f4cceea02f330716e701c6dcd9f0ca3f7e/packages/camera/camera_android/lib/src/android_camera.dart#L520)), so this PR is achieving consistency with them.
    
    Fixes flutter/flutter#140567. Thanks to @davidmartos96 for the push to investigate deeper on that issue!
    camsim99 authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    450251a View commit details
    Browse the repository at this point in the history
  6. [file_selector] Fix comment typo (#6027)

    Replaces "pltaform" with "platform" in each instance.
    stuartmorgan-g authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9a7ca13 View commit details
    Browse the repository at this point in the history
  7. [tool] Add details to missing gradle coverage error (#6029)

    When failing a package due to missing gradle coverage, explain what needs to be done to fix it.
    
    Fixes flutter/flutter#132453
    stuartmorgan-g authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    cbaa340 View commit details
    Browse the repository at this point in the history
  8. Update the emulator versions and expose cipd. (#6025)

    Update the android virtual device to use the proto config as the version instead of the integer version. This is more robust from the recipes side as the chromium team is changing names.
    
    Expose the avd_cipd_version flag so developers can update this without touching recipes.
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    Fixes flutter/flutter#142261
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    ricardoamador authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0f677d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Add a link the different possible Android virtual device configs (#6033)

    *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    ricardoamador authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d37fb0a View commit details
    Browse the repository at this point in the history
Loading