Repository navigation
Comparing changes
Open a pull request
base repository: flutter/packages
base: 5620e6543317
head repository: flutter/packages
compare: 951f2f723e3d
- 16 commits
- 59 files changed
- 17 contributors
Commits on Oct 2, 2026
-
[repo] Update AGENTS.md with dependency allowance and versioning guid…
…ance (#12579) Updates `AGENTS.md` to add guidance on common presubmit validation requirements: - Clarifies that modifying non-exempt files (such as `pubspec.yaml` or tool configs) triggers version and `CHANGELOG.md` requirements during repository validation unless explicit override labels are requested. ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests --------- Co-authored-by: Reid Baker <[email protected]> Co-authored-by: Reid Baker <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bc9395 - Browse repository at this point
Copy the full SHA 2bc9395View commit details -
[cupertino_ui] Remove redundant null arguments in Completer.complete (#…
…13008) This is work towards dart-lang/sdk#59150 (https://dart-review.googlesource.com/c/sdk/+/491341). The `avoid_redundant_argument_values` lint rule is being updated to flag redundant `null` argument values passed to optional nullable parameters with no default value (such as `Completer.complete([FutureOr<T>? value])`). ## Pre-Review Checklist
Configuration menu - View commit details
-
Copy full SHA for 585b3d1 - Browse repository at this point
Copy the full SHA 585b3d1View commit details -
[image_picker] Subsample large images when resizing on Android (#13038)
`ImageResizer.resizeImageIfNeeded` created a fresh `BitmapFactory.Options` and passed it to `calculateSampleSize`, which read `options.outWidth` and `options.outHeight`. That object had never been used for a decode, so both were 0 and the sample size was always 1: every resize with `maxWidth` or `maxHeight` decoded the full-size bitmap (about 48 MB for a 12 MP photo) before scaling it down. The original dimensions were already read by `readFileDimensions`, into a different `Options`. This PR passes those original dimensions to `calculateSampleSize` instead. The sample size stays the largest power of two that still decodes at least the target size, so the output dimensions are unchanged. The new `onResizeImageIfNeeded_whenDownscaling_shouldSubsampleFromOriginalSize` test resizes a 12x7 image to a width of 3 and checks the pixel decode uses `inSampleSize == 2` (before the fix it was 1) and that the output is still 3x2. This is not a regression: subsampling has never taken effect, since `inSampleSize` has been 1 from when it was introduced in #3423, and before that the full image was decoded too. Fixes flutter/flutter#193036 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 72fcf09 - Browse repository at this point
Copy the full SHA 72fcf09View commit details -
Redistribute iOS/macOS Suggested Reviewers (#13076)
Redistributes iOS/macOS Suggested Reviewers between team ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 57dde33 - Browse repository at this point
Copy the full SHA 57dde33View commit details -
[url_launcher] Fix supportsCloseForLaunchMode to query close support (#…
…12926) Fixes flutter/flutter#192758 `supportsCloseForLaunchMode` was calling `UrlLauncherPlatform.supportsMode` (the launch-support check) instead of `supportsCloseForMode`, so it reported whether a mode can be launched rather than whether an in-app web view opened with that mode can be closed. This changes it to call `supportsCloseForMode`, and adds a regression test (the shared mock is extended so the two platform methods can return different values).
Configuration menu - View commit details
-
Copy full SHA for 1cbff93 - Browse repository at this point
Copy the full SHA 1cbff93View commit details -
[material_ui] Migrate
SwitchAPI doc snippets to {@example} (batch ……8) (#13052) This PR addresses batch 8 of the migration detailed in flutter/flutter#188530 (comment). Non-trivial changes: * For switch.snippet.0, the original version incorrectly used `thumbColor` and this has been corrected by this PR (the snippet.1.dart now shows trackColor customization). ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for aa3575f - Browse repository at this point
Copy the full SHA aa3575fView commit details -
Roll Flutter from e89fd0a274ae to d03768eef055 (23 revisions) (#13111)
flutter/flutter@e89fd0a...d03768e 2026-10-02 [email protected] Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694) 2026-10-02 [email protected] [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005) 2026-10-02 [email protected] Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692) 2026-10-02 [email protected] Remove unused Fuchsia sysmem header files (flutter/flutter#193244) 2026-10-02 [email protected] [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968) 2026-10-02 [email protected] [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222) 2026-10-02 [email protected] [Embedder] Support render texture for vulkan (flutter/flutter#188855) 2026-10-02 [email protected] Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429) 2026-10-02 [email protected] Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714) 2026-10-02 [email protected] [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836) 2026-10-02 [email protected] [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963) 2026-10-02 [email protected] [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678) 2026-10-02 [email protected] [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427) 2026-10-02 [email protected] Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676) 2026-10-01 [email protected] Fix analysis failures due to missing `const` (flutter/flutter#193685) 2026-10-01 [email protected] Removes a11y_assessment app (flutter/flutter#193671) 2026-10-01 [email protected] test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529) 2026-10-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193666) 2026-10-01 [email protected] Avoid using relative path in Process.start (flutter/flutter#193664) 2026-10-01 [email protected] [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488) 2026-10-01 [email protected] ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580) 2026-10-01 [email protected] [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591) 2026-10-01 [email protected] [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 749a38f - Browse repository at this point
Copy the full SHA 749a38fView commit details -
[material_ui] Fix DropdownButtonFormField underline alignment at bott…
…om (#12606) This PR fixes the visual issue where the underline of a `DropdownButtonFormField` did not align at the bottom of its expanded container. Fixes flutter/flutter#162350 Port of flutter/flutter#181040. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for b0ae3b2 - Browse repository at this point
Copy the full SHA b0ae3b2View commit details -
[material_ui] Remove unconditional dart:io import from about.dart (#1…
…2774) `about.dart` imported `dart:io` unconditionally, only to read `Platform.resolvedExecutable` as the fallback application name when no `Title` ancestor is found. Because `about.dart` is reachable from the `material_ui` barrel, pana 0.23.18's static platform analysis marks the whole package as not supporting the web, which drops the `platform:web` and `is:wasm-ready` tags on pub.dev. It also means that fallback path throws `UnsupportedError` when it is actually reached on the web. This PR moves the executable-name lookup behind a conditional import (`_about_io.dart` / `_about_web.dart`), following the same pattern `package:flutter`'s foundation library uses for `_platform_io.dart` / `_platform_web.dart`. On the web the fallback name is the empty string, matching the existing empty-string default for the application version. The `[Platform.resolvedExecutable]` doc references are kept resolvable with a `@docImport`. Verified locally with pana 0.23.x on this branch: `Supports 6 of 6 possible platforms`, and the `platform:web` / `is:wasm-ready` tags are back. Fixes flutter/flutter#191887 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 7368361 - Browse repository at this point
Copy the full SHA 7368361View commit details -
[video_player] Ignore late position updates after disposal (#12971)
A platform seek can finish after `VideoPlayerController.dispose()`, causing `_updatePosition` to write to the disposed notifier and throw. This also happens in the controller's own `VideoEventType.completed` pause/seek chain, without the caller invoking a method after disposal. Checks `_isDisposed` at the shared position-update boundary. Adds regressions for an explicit pending seek and the pending seek from a playback-completed event. Both tests fail on the unmodified controller and pass with the guard. The patch updates the package to 2.14.1 and incorporates the existing `NEXT` changelog entry as required by the release instructions. Fixes flutter/flutter#193147 Validation with Flutter 3.44.9 / Dart 3.12.2: - Full Dart package suite: 118 passed, one existing skipped test. - `dart analyze --fatal-infos` for the package and example: no issues. - Repository Dart formatter run; unrelated pre-existing caption-test reformatting excluded from the diff. - Repository `publish-check`: passed after committing the four-file patch. - `git diff --check`: passed. Repository-wide `validate` could not complete in the sparse checkout because the root README references packages outside the checkout (`animations`). Native/integration tests were not run; this change is limited to the Dart controller. No public API or dartdoc changes are needed. ## Pre-Review Checklist
Configuration menu - View commit details
-
Copy full SHA for e18a541 - Browse repository at this point
Copy the full SHA e18a541View commit details -
[material_ui] Add Material 3 Expressive migration skill (#12818)
This PR is to add an agent skill for Material 3 Expressive component migration work in `packages/material_ui`. Related to https://github.com/orgs/flutter/projects/250. Will wait until flutter/flutter#192519 lands. Once this PR is landed, use prompts like * /material-3-expressive-migration Migrate `<component name>` in `packages/material_ui`. * Use the `material-3-expressive-migration` skill to migrate `<component name>` in `packages/material_ui`. to invoke the skill. ## Pre-Review Checklist
Configuration menu - View commit details
-
Copy full SHA for df4d712 - Browse repository at this point
Copy the full SHA df4d712View commit details -
[ci] Add material_ui and cupertino_ui to customer testing (#13114)
Adds material_ui and cupertino_ui to the customer testing shard Will not run golden file tests. Similar to our google_testing shard, this will ensure we catch regressions and breaking changes ahead of time, especially since flutter/packages tests against flutter/flutter's main branch in addition to stable. Fixes flutter/flutter#172940 (comment) Some examples we have run into already: - Dart regression not caught until it reached the Flutter roll into flutter/packages like: dart-lang/sdk#64326 (comment) - API breaks in the framework like: flutter/flutter#185152 After this: - we need to bump the flutter/packages hash in flutter/tests - and then bump the flutter/tests hash in flutter/flutter ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 29611ec - Browse repository at this point
Copy the full SHA 29611ecView commit details -
[cupertino_ui] Fix CupertinoMagnifier focal point with custom size (#…
…13029) `CupertinoMagnifier` used `kDefaultSize.height` instead of `size.height` to compute its focal point, so magnified content was not vertically centered with a custom `size`. The default size is unchanged. Fixes flutter/flutter#151740 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
HibaChamkhi authoredOct 2, 2026 Configuration menu - View commit details
-
Copy full SHA for 8dcefb4 - Browse repository at this point
Copy the full SHA 8dcefb4View commit details -
[cupertino_ui] Forward showDragHandle from showCupertinoSheet to Cupe…
…rtinoSheetRoute (#13011) Port of flutter/flutter#187803 to `cupertino_ui`, following the process in flutter/flutter#188444. The original PR was approved by dkwingsmt and navaronbracke but couldn't land because of the Material/Cupertino code freeze. `showCupertinoSheet` accepts a `showDragHandle` parameter and documents what it does, but never passes it to the `CupertinoSheetRoute` it builds — so setting it to `true` has no effect. This forwards it on both paths (the plain route and the nested-navigation route). The regression test calls `showCupertinoSheet(showDragHandle: true)` and checks the drag handle is actually rendered. I checked that it fails with the forwarding removed and passes with it, in its new location under `packages/cupertino_ui/test/`. The original commit was cherry-picked as the porting guide describes. It hit one conflict: since the copy, `main` added `hasPlatformViews: hasPlatformViews` to the same two `CupertinoSheetRoute` constructor calls. I resolved it by keeping both arguments; the bug itself is still present on `main` (`showDragHandle` is declared but never forwarded). The only new commit adds the pending changelog entry (`version: patch`). Fixes flutter/flutter#187693 ## Pre-Review Checklist I used AI tooling while working on this, and reviewed and tested all of it myself. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 4111f39 - Browse repository at this point
Copy the full SHA 4111f39View commit details -
[material_ui] Migrate M3 Motion template to use new gen_defaults (#13058
) Work toward flutter/flutter#187899. Fixes flutter/flutter#188422. This PR migrates the M3 Motion defaults template to use the new gen_defaults in material_ui. The generated defaults remain unchanged. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 10cde9a - Browse repository at this point
Copy the full SHA 10cde9aView commit details
Commits on Oct 5, 2026
-
[material_ui] Add scrollPadding property to DropdownMenuFormField (#1…
…2735) Port of flutter/flutter#184059 to flutter/packages, per the instructions in flutter/flutter#188444. This change adds the `scrollPadding` property to `DropdownMenuFormField` and forwards it to the underlying `DropdownMenu`, bringing the form field variant into parity with `DropdownMenu`. ## Related Issues The original issue has been closed, but the following comment explains the remaining gap that this PR addresses: flutter/flutter#182890 (comment) > The merged PR [#183109](flutter/flutter#183109) covers `DropdownMenu`, but `DropdownMenuFormField` still doesn't expose `scrollPadding`. I'm opening a follow-up PR to address that remaining gap. [#184059](flutter/flutter#184059) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Configuration menu - View commit details
-
Copy full SHA for 951f2f7 - Browse repository at this point
Copy the full SHA 951f2f7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5620e6543317...951f2f723e3d