Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5351d8c0f8df
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ac87e65333e1
Choose a head ref
  • 4 commits
  • 13 files changed
  • 4 contributors

Commits on Jul 31, 2026

  1. [camera_android_camerax] Update AGENTS.md to improve video recordin…

    …g integration tests (#12301)
    
    Adds note to `AGENTS.md` to hint to agents that if they add integration tests for video recording, they should add a delay between starting/stopping recordings to ensure the camera has enough time to initialized and get a valid recording.
    
    Inspired by an agent running into this while creating #12145 (see #12145 (comment))
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    camsim99 authored Jul 31, 2026
    Configuration menu
    Copy the full SHA
    a404e4c View commit details
    Browse the repository at this point in the history
  2. [vector_graphics] Provide textDirection for semantics label to avoid …

    …crash without Directionality (#11962)
    
    ## Description
    
    When a `VectorGraphic` (and therefore `SvgPicture`, which delegates to
    it) is given a `semanticsLabel` but there is no `Directionality`
    ancestor in the widget tree, the app crashes at frame flush with:
    
    ```
    A SemanticsData object with label "..." had a null textDirection.
    package:flutter/src/semantics/semantics.dart: Failed assertion: 'attributedLabel.string == '' || textDirection != null'
    ```
    
    The `Semantics` node created for the label in
    `_VectorGraphicWidgetState.build` passed a non-empty `label` but never
    supplied a `textDirection`, and did not resolve the ambient
    `Directionality`. With no `Directionality` in scope, the null text
    direction propagated to `SemanticsData`, which asserts. (This is why the
    issue only reproduces outside of a `MaterialApp`/`WidgetsApp`, where a
    `Directionality` is normally present — a triager was previously unable
    to reproduce it for that reason.)
    
    This PR resolves the text direction with
    `Directionality.maybeOf(context) ?? TextDirection.ltr`, so a labeled
    decorative graphic no longer crashes when no `Directionality` is in
    scope.
    
    The pre-existing test `Can add semantic label` had to wrap the widget in
    a `Directionality` to pass; this PR adds a regression test that omits
    the wrapper and verifies no exception is thrown and the label is
    present.
    
    ## Issues fixed by this PR
    
    Fixes flutter/flutter#175532
    
    ## Pre-Review Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran [the
    auto-formatter].
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [x] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [x] I followed [the version and CHANGELOG instructions].
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    test-exempt.
    - [x] All existing and new tests are passing.
    mbcorona authored Jul 31, 2026
    Configuration menu
    Copy the full SHA
    caddb39 View commit details
    Browse the repository at this point in the history
  3. [google_sign_in_android] Keep default_web_client_id resource from b…

    …eing stripped by resource shrinker (#12075)
    
    Adds a keep rule for `@string/default_web_client_id`, which gets merged into the main app's keep rules during the build.
    
    Fixes flutter/flutter#188363
    
    ### Why this is needed
    
    As documented in [Customize which resources to keep](https://developer.android.com/topic/performance/app-optimization/customize-which-resources-to-keep):
    > You should rarely need to keep resources. The use of getIdentifier() is an exception; however, retrieving resources by identifier is more efficient than retrieving them by name with getIdentifier().
    
    The plugin retrieves `default_web_client_id` dynamically via `Resources.getIdentifier()` in [`GoogleSignInPlugin.java`](https://github.com/flutter/packages/blob/main/packages/google_sign_in/google_sign_in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java#L201-L204):
    
    ```java
    int webClientIdIdentifier =
        context
            .getResources()
            .getIdentifier("default_web_client_id", "string", context.getPackageName());
    ```
    
    Without this keep rule, Android's resource shrinker discards `@string/default_web_client_id` in release builds because there are no static bytecode references to the resource ID.
    gmackall authored Jul 31, 2026
    Configuration menu
    Copy the full SHA
    a5beb57 View commit details
    Browse the repository at this point in the history
  4. [google_fonts] Remove failed loads from pendingFonts (#12240)

    Failed font loads remain in `pendingFontFutures` because the current cleanup
    callback runs only after successful completion. As a result, every later
    `GoogleFonts.pendingFonts()` call rethrows the same completed error.
    
    This change removes a tracked load on either completion path while preserving
    the original error for the caller currently awaiting `pendingFonts()`. It adds
    regression coverage showing that the first call reports the load failure and a
    later call is no longer poisoned by it.
    
    Fixes flutter/flutter#182430.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Yusufihsangorgel authored Jul 31, 2026
    Configuration menu
    Copy the full SHA
    ac87e65 View commit details
    Browse the repository at this point in the history
Loading