Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 33c2b4e53ad7
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cccf5d24d703
Choose a head ref
  • 6 commits
  • 21 files changed
  • 6 contributors

Commits on Nov 2, 2023

  1. [flutter_image] [flutter_markdown] Do not use dynamic in an == operat… 

    …or override (#5298)

Fixes flutter/flutter#117838

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [ ] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    @srawlins
    srawlins authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9ec7ee6 View commit details
    Browse the repository at this point in the history

  2. Fix mounted checks (#5305) 

    Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561.

The change referenced above tightens the `use_build_context_synchronously` lint to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up violations in the flutter/packages repo in preparation of this new enforcement.
    @goderbauer
    goderbauer authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8aef4b8 View commit details
    Browse the repository at this point in the history

  3. [google_sign_in] Fix Obj-C formatting bug (#5310) 

    Fix a formatting mistake from the conversion to Pigeon; the `;` here doesn't affect the behavior, but it's confusing, and makes the autoformatter unhappy.
    @stuartmorgan-g
    stuartmorgan-g authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5842d3d View commit details
    Browse the repository at this point in the history

  4. [go_router]Fixes the problem what pathParameters is null in redirect … 

    …when the Router is recreated. (#5258)

fixes flutter/flutter#135761
    @yiiim
    yiiim authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e4c5159 View commit details
    Browse the repository at this point in the history

  5. [camerax] Fix _getResolutionSelectorFromPreset NPE (#5287) 

    Fixes a mistake causing a NPE in `_getResolutionSelectorFromPreset`. Essentially, `boundSize` cannot be null except for one case (choosing the maximum available resolution), but the mistake I made was not allowing for that case to be valid.

(1/2 fixes really) Fixes flutter/flutter#135293.
    @camsim99
    camsim99 authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5b03a38 View commit details
    Browse the repository at this point in the history

  6. [go_router] Fixes crashes when dynamically updates routing tables wit… ( 

    #5242)

�h named routes.
fixes flutter/flutter#137133
    @chunhtai
    chunhtai authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cccf5d2 View commit details
    Browse the repository at this point in the history
Loading