Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 31fc7b5dd000
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b9b6d38e012b
Choose a head ref
  • 8 commits
  • 29 files changed
  • 7 contributors

Commits on Jan 4, 2024

  1. [url_launcher] Add InAppBrowserConfiguration parameter (#5758)

    This is #5166 portion of platform interface changes. Adds `InAppBrowserConfiguration` parameter, as well as `InAppBrowserConfiguration.showTitle` parameter that configures whether to show or not to show webpage title
    Alex-Usmanov authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7beab0d View commit details
    Browse the repository at this point in the history
  2. [tool] Handle Flutter dev dependencies (#5775)

    A non-Flutter package can have Flutter-based tests (e.g., cupertino_icons), in which case we need to use `flutter test` rather than `dart test` just like we would for a package with a non-dev Flutter dependency. This updates the `requiresFlutter` check to include dev dependencies as well as normal dependencies.
    stuartmorgan-g authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e573185 View commit details
    Browse the repository at this point in the history
  3. [file_selector_android] Attempt to close system dialogs before integr…

    …ation tests run (#5805)
    
    Attempt to close any system dialogs before running the test. This idea
    came from
    https://stackoverflow.com/questions/39457305/android-testing-waited-for-the-root-of-the-view-hierarchy-to-have-window-focus.
    
    There may be a system dialog before the test runs that prevents the
    FlutterView from getting focus. Which also prevents any of the espresso
    actions to run
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [ ] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style].
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    bparrishMines authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    c6b86c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. [pigeon] java non null void (#5786)

    Fixes java requiring `Null` to be `NonNull`.
    
    fixes: flutter/flutter#139194
    
    apparently also fixes an extra space that I removed a month ago and never merged.
    tarrinneal authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a5bb26d View commit details
    Browse the repository at this point in the history
  2. [video_player] Fix initial frame on macOS (#5781)

    As with seeking while paused, initing a video and not playing it should show the first frame as soon as it is available, but it currently doesn't because the display link isn't running. This uses the same mechanism added for seek to ensure that a video reports a frame to the engine (thus populating the initially-blank textture) as soon as one is available after the player is created, even if it's not played.
    
    Fixes flutter/flutter#140782
    stuartmorgan-g authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e8fb05f View commit details
    Browse the repository at this point in the history
  3. [image_picker] Remove input element after completion (#5654)

    This PR attempts to remove the input element added to the DOM after image selection is completed.
    
    Fixes flutter/flutter#139442
    Amir-P authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    15115f3 View commit details
    Browse the repository at this point in the history
  4. [ci] Run 'flutter build --config-only for iOS and macOS during fetch …

    …deps (#5804)
    
    For iOS and macOS move fetch deps from explicity running `pub get` and `pod install` to instead run `flutter build x --config-only` which smartly fetches deps and lays down the required native pieces.  I didn't guard it on whether certain files are present since the command already has similar guards, and runs pretty fast if the native code has already been generated.
    
    This fixes an issue where `pod install` is run before the Flutter native bits and migrations are run.
    
    Fixes issues seen in the Flutter roll #5792 (comment)
    ```
    Running command: "pod install" in /Volumes/Work/s/w/ir/x/w/packages/packages/camera/camera_avfoundation/example/ios
    Analyzing dependencies
    [!] CocoaPods could not find compatible versions for pod "Flutter":
      In Podfile:
        Flutter (from `Flutter`)
    
    Specs satisfying the `Flutter (from `Flutter`)` dependency were found, but they required a higher minimum deployment target.
    
    [!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.
    Unable to "pod install"
    ```
    
    Caused by flutter/flutter#140478
    jmagman authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0009545 View commit details
    Browse the repository at this point in the history
  5. Manual roll Flutter from 11def8e to cc40425 (118 revisions) (#5806)

    Manual roll Flutter from 11def8e to cc40425 (118 revisions)
    
    Manual roll requested by [email protected]
    
    flutter/flutter@11def8e...cc40425
    
    2024-01-05 [email protected] Roll Flutter Engine from
    0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993)
    2024-01-04 [email protected] Roll Flutter Engine from
    b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990)
    2024-01-04 [email protected] [web] Fix and unskip a few more CanvasKit
    tests (flutter/flutter#140821)
    2024-01-04 [email protected] Roll Flutter Engine from
    bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986)
    2024-01-04 [email protected] Pin package:vm_service
    (flutter/flutter#140972)
    2024-01-04 [email protected] Add scrollbar
    for menus (flutter/flutter#140941)
    2024-01-04 [email protected] manual pub roll to pick up dds
    fixes (flutter/flutter#140979)
    2024-01-04 [email protected] Roll Flutter Engine from
    b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980)
    2024-01-04 [email protected] Temporarily remove env variable for leak
    tracking bots. (flutter/flutter#140978)
    2024-01-04 [email protected] Add Flutter CI status to README
    (flutter/flutter#140513)
    2024-01-04 [email protected] Reland "integrate testWidgets with leak
    tracking" (#140521) (flutter/flutter#140928)
    2024-01-04 [email protected] Run half of iOS
    devicelab tests with Xcode 15 (flutter/flutter#140927)
    2024-01-04 [email protected] Fix
    `SegmentedButton` states update logic (flutter/flutter#140772)
    2024-01-04 [email protected] Roll Flutter Engine from
    f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973)
    2024-01-04 [email protected] [Fix] Consistency in
    ButtonStyleButton related Tests (flutter/flutter#140610)
    2024-01-04 [email protected] Roll Packages from
    bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967)
    2024-01-04 [email protected] Fix local engine use in macOS plugins
    (flutter/flutter#140222)
    2024-01-04 [email protected] Roll Flutter Engine from
    7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959)
    2024-01-04 [email protected] Roll Flutter Engine from
    1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946)
    2024-01-04 [email protected] Roll Flutter Engine from
    c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943)
    2024-01-04 [email protected] Roll Flutter Engine from
    bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939)
    2024-01-04 [email protected] Roll Flutter Engine from
    28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937)
    2024-01-04 [email protected] Roll Flutter Engine from
    ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936)
    2024-01-04 [email protected] Roll Flutter Engine from
    e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933)
    2024-01-03 [email protected] Roll Flutter Engine from
    7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929)
    2024-01-03 [email protected] Remove deprecated bitcode stripping from
    tooling (flutter/flutter#140903)
    2024-01-03 [email protected] Add Windows leak
    tracking targets (flutter/flutter#140423)
    2024-01-03 [email protected] [github actions] refactor and fix
    cherry pick actions (flutter/flutter#140499)
    2024-01-03 [email protected] Migrate Xcode projects last version checks
    to Xcode 15.1 (flutter/flutter#140256)
    2024-01-03 [email protected] Roll Flutter Engine from
    bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920)
    2024-01-03 [email protected] fix typo and reflow
    (flutter/flutter#140925)
    2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts
    "Re-land integrate testWidgets with leak tracking."
    (flutter/flutter#140926)
    2024-01-03 [email protected] Roll Flutter Engine from
    bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915)
    2024-01-03 [email protected] Changes the regular cursor to a
    floating cursor when a long press occurs. (flutter/flutter#138479)
    2024-01-03 [email protected] Add
    `SegmentedButton.styleFrom` (flutter/flutter#137542)
    2024-01-03 [email protected] Roll Flutter Engine from
    c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910)
    2024-01-03 [email protected] Re-land integrate testWidgets with leak
    tracking. (flutter/flutter#140521)
    2024-01-03 [email protected] Roll Flutter Engine from
    98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905)
    2024-01-03 [email protected] [flutter_tools] add support for
    --enable-impeller to test device. (flutter/flutter#140899)
    2024-01-03 [email protected] Roll Flutter Engine from
    cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897)
    2024-01-03 [email protected] Handle
    KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808)
    2024-01-03 [email protected] Add Lucas Saudon to AUTHORS
    (flutter/flutter#139965)
    2024-01-03 [email protected] Link to wiki page
    about updating dependencies in each `pubspec.yaml` file
    (flutter/flutter#140826)
    2024-01-03 [email protected] Marks Linux_pixel_7pro
    native_assets_android to be unflaky (flutter/flutter#140866)
    ...
    
    ---------
    
    Co-authored-by: Tarrin Neal <[email protected]>
    engine-flutter-autoroll and tarrinneal authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    b9b6d38 View commit details
    Browse the repository at this point in the history
Loading