Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 31d332900d98
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 910fabb4886b
Choose a head ref
  • 11 commits
  • 185 files changed
  • 6 contributors

Commits on May 29, 2024

  1. [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetSt…

    …ateProperty (#6743)
    
    Part of flutter/flutter#148218
    Part of flutter/flutter#148361
    
    Migrates off MaterialStateProperty
    Piinks authored May 29, 2024
    Configuration menu
    Copy the full SHA
    8b7b00b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4405f77 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (#6829)

    flutter/flutter@a1a33e6...c85fa6a
    
    2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223)
    2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
    2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
    2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
    2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
    2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
    2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
    2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
    2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594)
    2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
    2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199)
    2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
    2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
    2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079)
    2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
    2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042)
    2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184)
    2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
    2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150)
    2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 29, 2024
    Configuration menu
    Copy the full SHA
    82a811f View commit details
    Browse the repository at this point in the history
  4. [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Grad…

    …le version to 7.0.2 (#6742)
    
    Re-lands #6591.
    
    The only difference between that PR and this one is that this PR bumps the required Flutter version of Android facing packages to the latest Flutter stable version (3.22) that weren't doing so already. That is because the stable version includes the warning about using older versions of Android dependencies.
    camsim99 authored May 29, 2024
    Configuration menu
    Copy the full SHA
    5c60fdc View commit details
    Browse the repository at this point in the history
  5. [camerax] Add notes about Android permissions (#6741)

    Adds notes in the camera/camera and camera/camera_android_cameraX READMEs about the used `WRITE_EXTERNAL_STORAGE` permission used in the plugin and the foreground service permission that is required to specify if you wish to allow image streaming in the background.
    
    Fixes flutter/flutter#146935 and addresses flutter/flutter#131116 (comment).
    camsim99 authored May 29, 2024
    Configuration menu
    Copy the full SHA
    d3b60e5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e35f291 View commit details
    Browse the repository at this point in the history
  7. Migrate camera/android from SurfaceTexture->SurfaceProducer. (#…

    …6461)
    
    _**WIP**: We do not plan to land this PR until the next stable release (>= April 3rd 2024)_.
    
    Work towards flutter/flutter#145930.
    
    ## Details
    
    Migrates uses of `createSurfaceTexture` to `createSurfaceProducer`, which is intended to have no change in behavior, but _does_ change the backend rendering path, so it will require more testing (and we're also open to minor API renames or changes before it becomes stable).
    
    ## Background 
    
    Android plugins previously requested a `SurfaceTexture` from the Android embedder, and used that to produce a `Surface` to render external textures on (i.e. `video_player`).  This worked because 100% of Flutter applications on Android used OpenGLES (via our Skia backend), and `SurfaceTexture` is actually an (opaque) OpenGLES-texture.
    
    Starting soon (roughly ~Q3, this is not a guarantee and just an estimate), Flutter on Android will start to use our new Impeller graphics backend, which on newer devices (`>= API_VERSION_28`), will default to the Vulkan, _not_ OpenGLES. In other words, `SurfaceTexture` will cease to work (it is possible, but non-trivial, to map an OpenGLES texture over to Vulkan).
    
    After consultation with the Android team, they helped us understand that vending `SurfaceTexture` (the _consumer-side_ API) was never the right abstraction, and we should have been vending the _producer-side_ API, or `Surface` directly. The new `SurfaceProducer` API is exactly that - it generates a `Surface`, and similar to our platform view strategy, picks the "right" _consumer-side_ implementation details _for_ the user/plugin packages.
    
    The new `SurfaceProducer` API has 2 possible rendering types (as an implementation detail):
    
    - `SurfaceTexture`, for older OpenGLES devices, which works exactly as it does today.
    - `ImageReader`, for newer OpenGLES _or_ Vulkan devices.
    
    These are some subtle nuances in how these two APIs work differently (one example: flutter/flutter#144407), but our theory at this point is we don't expect these changes to be observed by any users, and we have other ideas if necessary. 
    
    > [!NOTE]
    > These invariants are [tested on CI in `flutter/engine`](https://github.com/flutter/engine/tree/main/testing/scenario_app/android#ci-configuration).
    
    Points of contact: 
    - @matanlurey or @jonahwilliams  (Flutter Engine)
    - @johnmccutchan or @reidbaker  (Flutter on Android)
    matanlurey authored May 29, 2024
    Configuration menu
    Copy the full SHA
    058851b View commit details
    Browse the repository at this point in the history
  8. Migrate CameraX from SurfaceTexture to SurfaceProducer. (#6462)

    _**WIP**: We do not plan to land this PR until the next stable release (>= April 3rd 2024)_.
    
    Work towards flutter/flutter#145930.
    
    ## Details
    
    Migrates uses of `createSurfaceTexture` to `createSurfaceProducer`, which is intended to have no change in behavior, but _does_ change the backend rendering path, so it will require more testing (and we're also open to minor API renames or changes before it becomes stable).
    
    ## Background 
    
    Android plugins previously requested a `SurfaceTexture` from the Android embedder, and used that to produce a `Surface` to render external textures on (i.e. `video_player`).  This worked because 100% of Flutter applications on Android used OpenGLES (via our Skia backend), and `SurfaceTexture` is actually an (opaque) OpenGLES-texture.
    
    Starting soon (roughly ~Q3, this is not a guarantee and just an estimate), Flutter on Android will start to use our new Impeller graphics backend, which on newer devices (`>= API_VERSION_28`), will default to the Vulkan, _not_ OpenGLES. In other words, `SurfaceTexture` will cease to work (it is possible, but non-trivial, to map an OpenGLES texture over to Vulkan).
    
    After consultation with the Android team, they helped us understand that vending `SurfaceTexture` (the _consumer-side_ API) was never the right abstraction, and we should have been vending the _producer-side_ API, or `Surface` directly. The new `SurfaceProducer` API is exactly that - it generates a `Surface`, and similar to our platform view strategy, picks the "right" _consumer-side_ implementation details _for_ the user/plugin packages.
    
    The new `SurfaceProducer` API has 2 possible rendering types (as an implementation detail):
    
    - `SurfaceTexture`, for older OpenGLES devices, which works exactly as it does today.
    - `ImageReader`, for newer OpenGLES _or_ Vulkan devices.
    
    These are some subtle nuances in how these two APIs work differently (one example: flutter/flutter#144407), but our theory at this point is we don't expect these changes to be observed by any users, and we have other ideas if necessary. 
    
    > [!NOTE]
    > These invariants are [tested on CI in `flutter/engine`](https://github.com/flutter/engine/tree/main/testing/scenario_app/android#ci-configuration).
    
    Points of contact: 
    - @matanlurey or @jonahwilliams  (Flutter Engine)
    - @johnmccutchan or @reidbaker  (Flutter on Android)
    matanlurey authored May 29, 2024
    Configuration menu
    Copy the full SHA
    47d5eb2 View commit details
    Browse the repository at this point in the history
  9. [google_maps_flutter] Undeprecate BitmapDescriptor methods (#6832)

    Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes
    
    * Undeprecates `BitmapDescriptor.fromAssetImage`.
    * Undeprecates `BitmapDescriptor.fromBytes`.
    * Fixes issues with deprecation in version 2.7.0.
    
    The new formats won't be supported until #6826 lands.
    Deprecation notices can be re-added after the implementation PRs have landed.
    
    Fixes: flutter/flutter#149183
    jokerttu authored May 29, 2024
    Configuration menu
    Copy the full SHA
    28e8afd View commit details
    Browse the repository at this point in the history
  10. Migrate video_player/android from SurfaceTexture->`SurfaceProduce…

    …r`. (#6456)
    
    _**WIP**: We do not plan to land this PR until the next stable release (>= April 3rd 2024)_.
    
    Work towards flutter/flutter#145930.
    
    ## Details
    
    Migrates uses of `createSurfaceTexture` to `createSurfaceProducer`, which is intended to have no change in behavior, but _does_ change the backend rendering path, so it will require more testing (and we're also open to minor API renames or changes before it becomes stable).
    
    ## Background 
    
    Android plugins previously requested a `SurfaceTexture` from the Android embedder, and used that to produce a `Surface` to render external textures on (i.e. `video_player`).  This worked because 100% of Flutter applications on Android used OpenGLES (via our Skia backend), and `SurfaceTexture` is actually an (opaque) OpenGLES-texture.
    
    Starting soon (roughly ~Q3, this is not a guarantee and just an estimate), Flutter on Android will start to use our new Impeller graphics backend, which on newer devices (`>= API_VERSION_28`), will default to the Vulkan, _not_ OpenGLES. In other words, `SurfaceTexture` will cease to work (it is possible, but non-trivial, to map an OpenGLES texture over to Vulkan).
    
    After consultation with the Android team, they helped us understand that vending `SurfaceTexture` (the _consumer-side_ API) was never the right abstraction, and we should have been vending the _producer-side_ API, or `Surface` directly. The new `SurfaceProducer` API is exactly that - it generates a `Surface`, and similar to our platform view strategy, picks the "right" _consumer-side_ implementation details _for_ the user/plugin packages.
    
    The new `SurfaceProducer` API has 2 possible rendering types (as an implementation detail):
    
    - `SurfaceTexture`, for older OpenGLES devices, which works exactly as it does today.
    - `ImageReader`, for newer OpenGLES _or_ Vulkan devices.
    
    These are some subtle nuances in how these two APIs work differently (one example: flutter/flutter#144407), but our theory at this point is we don't expect these changes to be observed by any users, and we have other ideas if necessary. 
    
    > [!NOTE]
    > These invariants are [tested on CI in `flutter/engine`](https://github.com/flutter/engine/tree/main/testing/scenario_app/android#ci-configuration).
    
    Points of contact: 
    - @matanlurey or @jonahwilliams  (Flutter Engine)
    - @johnmccutchan or @reidbaker  (Flutter on Android)
    matanlurey authored May 29, 2024
    Configuration menu
    Copy the full SHA
    a5dd314 View commit details
    Browse the repository at this point in the history
  11. Amend package:web tweaks to allow package:web roll (#6793)

    dart-lang/web@7604578 adds a number of APIs in order to get a more consistent API surface. This includes disablePictureInPicture and disableRemotePlayback, which both take in a bool and not a JSBoolean. However, it can't be rolled into google3 as this package will now be broken due to the way extension type methods take a higher precedence over extension methods.
    
    This CL aligns those methods with the package:web equivalent so that usages of these methods can be consistent. controlsList is also amended to take in a String so that if it's ever added to the Web IDL, it doesn't conflict with the package:web definition that will be added then.
    srujzs authored May 29, 2024
    Configuration menu
    Copy the full SHA
    910fabb View commit details
    Browse the repository at this point in the history
Loading