Repository navigation
Comparing changes
Open a pull request
base repository: flutter/packages
base: 23a05b6ad5d5
head repository: flutter/packages
compare: a8549ae8080b
- 10 commits
- 36 files changed
- 8 contributors
Commits on Oct 26, 2026
-
Fix AI guidelines link in PR template (#13411)
The AI contribution guidelines were moved to a separate page; this updates the checklist to link to the new location.
Configuration menu - View commit details
-
Copy full SHA for ae20ca6 - Browse repository at this point
Copy the full SHA ae20ca6View commit details
Commits on Oct 27, 2026
-
[shared_preferences_foundation] Fix web compilation of apps that impo…
…rt the package (#13447) Since 2.6.0 (#12329), `package:shared_preferences_foundation/shared_preferences_foundation.dart` transitively imports `dart:ffi` and `package:objective_c`, causing multi-platform apps that import it (for example to use `SharedPreferencesAsyncFoundationOptions`) to fail compilation on web. This currently breaks `shared_preferences/example` web drive tests in CI. Following the same approach as `shared_preferences_android` in #13380, this conditionally exports a stub of the plugin classes when `dart.library.ffi` is unavailable and moves `SharedPreferencesAsyncFoundationOptions` into its own FFI-free file.
Configuration menu - View commit details
-
Copy full SHA for d9db25a - Browse repository at this point
Copy the full SHA d9db25aView commit details -
[material_ui] Update out-of-date typography documentation (#13372)
Updates out-of-date documentation for typography, which is missing reference to the 2021 theme (the current default). Fixes flutter/flutter#195013 ## Pre-Review Checklist **Text exemption:** Documentation changes only. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for d96c511 - Browse repository at this point
Copy the full SHA d96c511View commit details -
[material_ui] Fix
TextThemeandTypographydebugFillProperties……defaults (#13374) `TextTheme.debugFillProperties` and `Typography.debugFillProperties` decide which values to report by comparing them against a default. Both defaults were out of date: - `TextTheme` compared against `Typography.material2018(...).black` - `Typography` compared against `Typography.material2014()` This PR: - compares `TextTheme` styles against `ThemeData.fallback().textTheme`. - compares `Typography` text themes against `ThemeData.fallback().typography`. This matches how `ThemeData.debugFillProperties` already reports typography. - Treats null `TextTheme` styles as default. When a `TextTheme` is merged into a `ThemeData`, a null style falls back to the default style, so it shouldn't be reported as a difference. Fixes flutter/flutter#194981 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 3ada763 - Browse repository at this point
Copy the full SHA 3ada763View commit details -
[cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: na…
…v_bar_transition_test, refresh_test, route_test, text_field_cursor_test (#13439) Removes the whole-file `@TestOn('!chrome')` annotations from four `cupertino_ui` test files so they run on the web: - `nav_bar_transition_test.dart` - `refresh_test.dart` - `route_test.dart` (keeps the existing targeted web skip on the state restoration test) - `text_field_cursor_test.dart` All of the newly enabled tests pass on Chrome under both CI web renderers: CanvasKit (`flutter test --platform chrome`) and Skwasm (`flutter test --platform chrome --wasm`). None of them use golden files. Leaving the skips in place hides web regressions in these widgets. Part of flutter/flutter#33615 (the original web limitation behind these skips is closed; the one test that still depends on state restoration stays skipped on web). This is a test-only change, so it is exempt from version and CHANGELOG updates. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for b48550d - Browse repository at this point
Copy the full SHA b48550dView commit details -
[vector_graphics_compiler] Handle coordinate lists on text and tspan (#…
…13287) SVG allows `x`, `y`, `dx` and `dy` on `text` and `tspan` to be a list, one value per character. The compiler parsed them as a single number, so a list like `x="0 4.86 10.01"` threw a confusing `FormatException: Invalid double`. Lists aren't supported, so it now throws an `UnimplementedError` that names the attribute and value. Single values work as before. Fixes flutter/flutter#165490 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for e71b3fd - Browse repository at this point
Copy the full SHA e71b3fdView commit details -
[material_ui] Add Checkbox.markInsets (#12690)
This PR ports my changes from flutter/flutter#188258 to flutter/packages, as part of flutter/flutter#188444 Adds `Checkbox.markInsets` and `CheckboxThemeData.markInsets`, which inset the check mark and the indeterminate dash within the checkbox without changing the size of the box itself. The mark and its stroke shrink proportionally, and the mark is not painted if the insets leave no room. Fixes flutter/flutter#188031 ## Tests Added to `packages/material_ui/test/checkbox_test.dart`: - `Checkbox.markInsets` defaults to null - Checkbox with no `markInsets` paints the check at full stroke width (backward-compat) - `Checkbox.markInsets` shrinks the check mark and its stroke - `Checkbox.markInsets` shrinks the indeterminate dash - `Checkbox.markInsets` larger than the box collapses the mark without crashing - `Checkbox.markInsets` falls back to `CheckboxThemeData.markInsets` - `Checkbox.markInsets` overrides `CheckboxThemeData.markInsets` ## Pre-Review Checklist submitting PRs. am not using AI tools. brackets, e.g. `[shared_preferences]` and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. indicate which [test exemption] this PR falls under[^1]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for d2e97da - Browse repository at this point
Copy the full SHA d2e97daView commit details -
[material_ui] Fix MenuAnchor non-Unicode shortcut labels on JS web (#…
…13370) Delegate unlocalized trigger fallback in `_LocalizedShortcutLabeler.getShortcutLabel` directly to `trigger.keyLabel` instead of masking `keyId` with `LogicalKeyboardKey.planeMask` (`0x0ff00000000`), which truncates to `0` under 32-bit JS bitwise `&` and renders keys like `Tab` and `F1` as raw char codes (`\t`, `\u0801`). Fixes flutter/flutter#195003 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for d155a33 - Browse repository at this point
Copy the full SHA d155a33View commit details -
[shared_preferences] Defer SharedPreferences fetch in `LegacySharedPr…
…eferencesPlugin` until first use on Android (#13431) Defers `getSharedPreferences` in `LegacySharedPreferencesPlugin` out of `onAttachedToEngine` until first use, avoiding synchronous disk I/O on the Android main thread during startup. The following screenshot shows that the time taken for `RegisterFlutterPlugin` significantly decreases with the change, which validates the fix: <img width="1920" height="552" alt="shared_preferences_registration_comparison_perfetto" src="https://github.com/user-attachments/assets/c1fea032-a499-4fa4-91de-13648ea03999" /> I also previously implemented this in my app, which was later negated by an upgrade of the shared_preferences packages into g3 and caused cold startup latency regression alerts on my app. Hoping to upstream the fix to get this optimization to all Flutter users. flutter/flutter#195313 will be fixed by this PR. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 587ee23 - Browse repository at this point
Copy the full SHA 587ee23View commit details -
[material_ui] Deprecate the black/white parameters in `Typography.mat…
…erial2021` (#13443) Adds a deprecation message to the black/white parameters in the `Typography.material2021` factory constructor. Fixes flutter/flutter#195200 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for a8549ae - Browse repository at this point
Copy the full SHA a8549aeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 23a05b6ad5d5...a8549ae8080b