Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 21c2ebb39c07
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c070b0a7a80a
Choose a head ref
  • 3 commits
  • 54 files changed
  • 2 contributors

Commits on Sep 28, 2023

  1. [tool] Don't lint Flutter shim podspecs (#5007) 

    The Flutter build process creates podspecs that are just shims pointing to the local Flutter framework, and which don't pass the linter since they aren't intended for publishing. When finding podspecs to lint, skip those.

This avoids incorrect failures when running on a tree that isn't clean (in particular, where macOS and/or iOS builds have happened), which is very common locally.
    @stuartmorgan-g
    stuartmorgan-g authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    95c88f8 View commit details
    Browse the repository at this point in the history

  2. [go_router] Avoid logging when debugLogDiagnostics is false (#4875) 

    Fixes flutter/flutter#134187
    @ValentinVignal
    ValentinVignal authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    79461c2 View commit details
    Browse the repository at this point in the history

  3. [video_player] Add macOS support (#4982) 

    Adds macOS support to `video_player`, sharing almost all of the code with iOS.

Notes about changes at a high level:
- macOS does not have `CADisplayLink` (prior to 14, and even there without all the functionality we need), so this adds macOS compilation branches that use the lower-level `CVDisplayLink` instead. Per the TODO, this code should be extracted later to reduce `ifdef`s in what is already a complicated file.
- Adds KVO unregistration on `dealloc` if it wasn't done in `dispose`, since unit tests were crashing on macOS with that.
- Temporarily ifdef's out `publish:` for macOS, with a TODO to re-enable it after the next stable.

Most of flutter/flutter#41688
Once this lands, the app-facing package will be updated to endorse it for macOS.
    @stuartmorgan-g
    stuartmorgan-g authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c070b0a View commit details
    Browse the repository at this point in the history
Loading