Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19daf6f36df7
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3d358d921a84
Choose a head ref
  • 4 commits
  • 65 files changed
  • 4 contributors

Commits on Jul 25, 2024

  1. [flutter_migrate] Remove one set of parens that wrap a single String …

    …literal (#7216)
    
    In order to address dart-lang/linter#4354, we are reporting a few more
    cases in `unnecessary_parenthesis`. `('text') * 2` is one such case.
    This change is being made in
    https://dart-review.googlesource.com/c/sdk/+/376540. (These are the only
    newly-reported unnecessary parentheses for this change.)
    
    This is the _same_ change as
    flutter/flutter#152031
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [ ] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [ ] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [ ] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style], or this PR is [exempt from
    CHANGELOG changes].
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    [linked to at least one issue that this PR fixes]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
    [exempt from CHANGELOG changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    srawlins authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    94f8b2f View commit details
    Browse the repository at this point in the history
  2. [tool] Add a package-level pre-publish hook (#7156)

    Adds the ability for a package to specify a script that should be run before publishing. To minimize the chance of such a script breaking things only in the post-submit `release` step, if the script is present it will also be run during `publish-check`.
    
    These should be used with caution since they can cause the published artifacts to be different from that is checked in, but in the intended use case of extension builds this risk is far preferable to the risks associated with checking in binaries that were built on local, ad-hoc basis. (Longer term, we may need an alternate solution however, as generating artifacts in CI can have its own supply chain validation issues.)
    
    Also does some minor refactoring to custom test script code to make it follow the same pattern as this new code.
    
    Fixes flutter/flutter#150210
    stuartmorgan-g authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    50238e7 View commit details
    Browse the repository at this point in the history
  3. [tool] Adds --wasm flag to the drive-examples command (#7162)

    I was unsure if we wanted to add a new platform option for this or add a `--wasm` flag to the command. Adding a `--wasm` flag seems more complicated since we would probably want to add extra handling around proper use of the flag, whereas adding a `web-wasm` platform should require no additional checks.
    
    This is in preparation for flutter/flutter#151664
    Rexios80 authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0489bda View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. [many] Ignore NewerVersionAvailable in android lint (#7218)

    - **Updates android lint to ignore NewerVersionAvailable**
    - **Update changelog**
    
    Fixes flutter/flutter#152316
    reidbaker authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3d358d9 View commit details
    Browse the repository at this point in the history
Loading