Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 13d38e0d97a8
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0b72e92bf5dd
Choose a head ref
  • 6 commits
  • 28 files changed
  • 6 contributors

Commits on Oct 28, 2026

  1. Roll Flutter from d4c857754c0e to 0c2473cd50c8 (21 revisions) (#13470)

    flutter/flutter@d4c8577...0c2473c
    
    2026-10-28 [email protected] Roll Packages from a8549ae to 13d38e0 (9 revisions) (flutter/flutter#195488)
    2026-10-28 [email protected] Use int.oneBitCount in PersistentHashMap and scope 53-bit caps to JS (flutter/flutter#195005)
    2026-10-28 [email protected] Roll pub packages (flutter/flutter#195483)
    2026-10-28 [email protected] [iPhone Duo] Use the correct UIScreen to report the display size and update when fold/unfold (flutter/flutter#195199)
    2026-10-28 [email protected] [fuchsia] Fix portable_ui_test.h includes for newer Fuchsia SDKs (flutter/flutter#195420)
    2026-10-28 [email protected] Change default pipeline options to match production draw calls (flutter/flutter#194597)
    2026-10-28 [email protected] Roll Fuchsia Test Scripts from 2T18KC7-LDQtmQiLP... to xl1LWBuppzu-BnOzV... (flutter/flutter#195450)
    2026-10-27 [email protected] [flutter_tools] Inject dependencies into Darwin build targets, native assets, and Xcode build settings (flutter/flutter#194052)
    2026-10-27 [email protected] Revert: Reland square corners fix (flutter/flutter#195436)
    2026-10-27 [email protected] [flutter_tools] Add DeviceService app launch and flutter run support for tool extensions (flutter/flutter#194589)
    2026-10-27 [email protected] [engine] Honor targetWidth/targetHeight for animated images (flutter/flutter#194615)
    2026-10-27 [email protected] [Android][a11y] Set visibleToUser=false for hidden semantics nodes (flutter/flutter#194411)
    2026-10-27 [email protected] Fix repo deletion test flake (flutter/flutter#195349)
    2026-10-27 [email protected] Roll Packages from 23a05b6 to a8549ae (10 revisions) (flutter/flutter#195434)
    2026-10-27 [email protected] [web] Capture pointers to the Flutter view so drags survive platform view iframes (flutter/flutter#195187)
    2026-10-27 [email protected] [web] Add opt-in raw samples, measured sample count and warm-up phase hook to the web benchmark recorder (flutter/flutter#195118)
    2026-10-27 [email protected] Link migration guide in deprecation messages (flutter/flutter#195361)
    2026-10-27 [email protected] Pin basic_material_app_macos__compile to macOS 26 (flutter/flutter#195429)
    2026-10-27 [email protected] Add benchmark for warmed pipeline usage (flutter/flutter#195001)
    2026-10-27 [email protected] [flutter_tools] Add device log streaming support to DeviceService and ExtensionBackedDevice (flutter/flutter#194964)
    2026-10-27 [email protected] Roll Dart SDK from 1d16c04dc346 to 65fc979759ca (4 revisions) (flutter/flutter#195383)
    
    If this roll has caused a breakage, revert this CL and set the roller
    to dry run mode using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 28, 2026
    Configuration menu
    Copy the full SHA
    6f61327 View commit details
    Browse the repository at this point in the history
  2. [tool] Fix package matching logic for --package-tags filter (#13472)

    #12763 introduced a new `--package-tags` flag that can be used to specify which flags to filter a package's tests with. After some investigation, I realized it wasn't working on CI.
    
    This is because we were trying to match the package key set in the [YAML file](https://github.com/flutter/packages/blob/13d38e0d97a8e1227379f2887847bc178f22c73a/script/configs/web_dart_unit_test_tags.yaml#L5) (in this case `material_ui`) to [`RepositoryPackage.displayName`](https://github.com/flutter/packages/blob/9919dfd51491a82547033aa1a8aa9aa5a185c61c/script/tool/lib/src/common/repository_package.dart#L41) which removes everything in the path up to the first path component named `packages`. On CI, the repository is checked out into a directory named packages, so `RepositoryPackage.displayName`  returned the package's path with a leading `packages/` (e.g. `packages/material_ui`). As a result, it never matched in CI. Tag lookup now uses `_packageTagKey`, which returns the package's path relative to the `packages/` directory that contains it (e.g. `material_ui`), regardless of where the repository is checked out.
    
    Work towards flutter/flutter#192308
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    elliette authored Oct 28, 2026
    Configuration menu
    Copy the full SHA
    0f3656e View commit details
    Browse the repository at this point in the history
  3. [flutter_svg] Throw on non-2xx responses in SvgNetworkLoader (#13403)

    `SvgNetworkLoader.prepareMessage` returned `response.bodyBytes` without checking the status code, so a 404 or 503 HTML error page was handed to the SVG parser and failed with a misleading `StateError: Bad state: Invalid SVG data`. This PR makes it throw an `http.ClientException` naming the status code and URL for any status outside 200–299, so the real failure is visible.
    
    It also moves closing an internally created client into a `finally`, so that client is closed on the error path too (and if `get` itself throws). Tests cover a 404 (throws, client still closed) and a 200 (returns the body).
    
    Fixes flutter/flutter#195162
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    francisrath authored Oct 28, 2026
    Configuration menu
    Copy the full SHA
    9d6cf9a View commit details
    Browse the repository at this point in the history
  4. [cupertino_ui] Document translucent default background of CupertinoSl…

    …idingSegmentedControl (#13178)
    
    Fixes flutter/flutter#164073
    Ports flutter/flutter#186645. Part of flutter/flutter#188444.
    
    Documents that the default background of CupertinoSlidingSegmentedControl is translucent, so content behind unselected segments shows through unless an opaque color is passed. The original issue is flutter/flutter#164073. Tracking issue: flutter/flutter#188444.
    
    cc @NadeemIqbal
    
    Docs-only change, so this is test-exempt. I used AI assistance to port the approved documentation.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    samar70 authored Oct 28, 2026
    Configuration menu
    Copy the full SHA
    4dd0e3e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2026

  1. [pigeon] update jni dependency to ^1.1.1 and remove workaround progua…

    …rd rules (#13464)
    
    This should remove the need for manual proguard rules
    tarrinneal authored Oct 29, 2026
    Configuration menu
    Copy the full SHA
    2def459 View commit details
    Browse the repository at this point in the history
  2. [material_ui] Mirror the GappedSliderTrackShape secondary track corre…

    …ctly in RTL (#13226)
    
    In RTL, `GappedSliderTrackShape` drew the secondary track from `secondaryOffset.dx - trackGap` to `thumbCenter.dx`. That filled the gap next to the thumb, which the main track segments and the LTR secondary track keep empty. The corner radii were also copied from the LTR case instead of being mirrored, so the far end had the small inside corners and the end by the thumb was fully rounded.
    
    This PR draws the RTL secondary track from `secondaryOffset.dx` to `thumbCenter.dx - trackGap`, with the fully rounded corners on the far end and the small inside corners next to the thumb. That is the mirror image of the LTR case. The existing visibility check just above already used `thumbCenter.dx - trackGap`, so it matches the new geometry.
    
    Before and after, LTR on top and RTL below, with `Slider(year2023: false, secondaryTrackValue: ...)` and `trackHeight: 24`:
    
    <details open>
    <summary>Screenshots demonstration</summary>
    
    | State | Direction | Screenshot |
    | :---: | :---: | :---: |
    | **Before** | <kbd>LTR ➔</kbd><br><br><br><kbd>⬅ RTL</kbd> | <img width="1200" height="320" alt="2_gapped_BEFORE" src="https://github.com/user-attachments/assets/dfc9eb92-9b0c-4fd6-a087-253e7a0b586d" /> |
    | **After** | <kbd>LTR ➔</kbd><br><br><br><kbd>⬅ RTL</kbd> | <img width="1200" height="320" alt="2_gapped_AFTER" src="https://github.com/user-attachments/assets/99599f28-dd24-41b6-80f3-cf889bc2fa74" /> |
    
    </details>
    
    I extended the existing `Default Slider when year2023 is false` test. It now also asserts the exact LTR secondary track, and has a new RTL block with the mirrored inactive, active and secondary tracks, including corner radii. The RTL block fails without the fix.
    
    Fixes flutter/flutter#194279
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    SalehTZ authored Oct 29, 2026
    Configuration menu
    Copy the full SHA
    0b72e92 View commit details
    Browse the repository at this point in the history
Loading